Also switched to the dev version because of this.
Maybe it's time to release a new version, the dev version seems to be the better choice right now.
Code review pass, all are looking ok.
Testing without the fix against current 4.0.x I couldn't upload a WebP logo.
Applying the fix I could upload a WebP logo and I could see it in the sidebar.
Approved.
Well done
checking
Testing this, I did get the empty space without the patch/MR applied. Applying the changes everything worked as expected.
The testing notes are useful for getting into the edge case of having an empty region. @anruether if you can describe what you do to come up with that region being empty then I can check further.
In any case, the MR is clean, well written and approved.
Well done all
checking
Can we get this merged please?
@tr that's the plan, it's a monthly thing. Do you want me to remove the tag?
Attaching patch for latest non-dev version (v2.0.2) for use on production site.
The MR is against the dev version.
@adrienliegmann you should update to Drupal 10.3.x or higher. Reverting the change seems like a step back.
Merging following the "looks perfect" review. Thanks both of you.
Should the need arise for further improvements we can open a new issue in the future.
Related 🐛 Layout builder fails to assign inline block access dependencies for the overrides section storage on entities with pending revisions Needs work
There is a patch on that thread that looks to be on the right track too
I believe we need to change the target branch to 11.1 or something. The commits are awfully wrong in Gitlab after the rebase.
It's been less than 10 commits, we are seeing things already merged in Core.
List of issues that we were looking at: https://www.drupal.org/project/issues/search?issue_tags=GreeceWinterSpri... →
vensires → credited bserem → .
PS, `field_items` class is introduced to single value fields with the work on the branch. Thinking about it too
LB related tests fixed, working on CKEditor ones (the ones we haven't solved in years)
In the meanwhile, I don't really like the naming conventions and some of the classes that we are introducing here
- field--multivalue-field -> field--multiple-value-field, or field--multiple which is what already exists in Core
- field--single-value-field -> as is, or field--single which is what already exists Core
- field--has-multiple-items
- field--has-single-item -> field--has-one-item
- field--items-count-X -> is this really needed? Do we care about something like that or do we just pollute the DOM?
Attached screenshot with before and after.
MR !10503 fixes the schema.
Nice find @eduardo
Reviewed and merged.
A new version will be released next month, assuming there are no issues with the current dev version.
Thanks all!
Reviewed and merged
bserem → made their first commit to this issue’s fork.
Thanks for the work and the test.
Merged
bserem → made their first commit to this issue’s fork.
Reviewed and merged, thanks
None of the provided patches work for me. In my case I am trying to add translations to blocks using Drupal 10.2
None of the latest patches apply anymore. Trying to apply them by hand ends in deprecation warnings.
Patch #5 does work. #8 does not. Given how much of a difference this makes to imported content readability, I'll push this forward.
#25 works fine here too. I'll update the status so that this might get some more action.
Added an MR based on patch on #61, updated to not rely on jquery once but on core/once.
Just by checking at the code, the patch in #61 (and all previous ones) rely on jQuery Once, but this is not supported on Drupal 10 any more.
The patch is not compatible with Drupal 10.
This is the common way of communicating with another DB, but not the way to do it in DDEV.
Read here: https://ddev.readthedocs.io/en/latest/users/usage/faq/#can-different-pro...
And add the ddev-project-db as host as described in the documentation. No need to edit settings files in PHP.
@dewalt I assume you meant patch 59 was the source, as there is no patch in 56, and 56 is just a typo mistake.
@Hardik_Patel_12 this has been fixed already, in the dev version
Hello again, thanks for your commitment in this.
The attached logo is foggy, has low quality and has blue pixels on the edges. Furthermore, it still fails to communicate what we wan't it to communicate.
Obviously it's not related to Time, but like I said, I'd to get some feedback if anyone has a thing to say or two.
I'll try to add some flood control checks in the near future. As far as I know the contact module is completely incompatible with Time, that's why I started my attempts on a contact form. If I missed something here please let me know.
@roshni27 the provided files fail to communicate that this is about a module that sends an email, or that it is for a static site. They also look like they were copied from an icons website.
I like the initiative, can we please try and communicate what this module does?
@roshni27 how is that any different from what we have already? Did you read my initial post, where I say that the current one is very small?
It is completely unrelated to CKEditor. The editor was about users and builders, the dev environment is about developers. Making the user experience better meant the world for them.
Alternatives died because they were not up to the competition.
A Dev or company can pick their environment, but suggesting something for newcomers and those looking for a shift from old ways is only going to help.
And like said above, DDEV is a non profit: https://ddev.com/foundation/
It is hard imagining it will go less open source. Keep in mind that Acquia controls much of Drupal and is not an open source company, or non profit. Why would you fear DDEV more than Acquia?
Keep in mind that DDEV is increasing in popularity for other platforms too, so it's not going anywhere anytime soon. Developers love it, companies love it (saves them money). So we be at peace knowing it's not gonna have ADDs fate.
Recommending it sounds like a nice step forward. After all, power users can use whatever they want, but newcomers will benefit a lot from seeing a recommended solution instead of going with WAMP/MAMP nowdays, which I still see people do! I even see ADD more often than it makes sense.
And if people contribute towards DDEV (financially or otherwise) the situation is only going to improve
That' a very valid point!
Docksal is created by FFW. I do not wanna say it is for-profit (FFW certainly is) as things might have change since it was created. I believe they are still the ones behind docksal, but can't tell for sure.
+1, this takes care of all the warnings
Manually editing the config yml file fixed things:
diff --git a/config/sync/commerce_exchanger.commerce_exchange_rates.ecb.yml b/config/sync/commerce_exchanger.commerce_exchange_rates.ecb.yml index cbbac13500..a1a7d518a6 100644 --- a/config/sync/commerce_exchanger.commerce_exchange_rates.ecb.yml +++ b/config/sync/commerce_exchanger.commerce_exchange_rates.ecb.yml @@ -1,9 +1,6 @@ uuid: langcode: en status: true -dependencies: - config: - - commerce_exchanger.latest_exchange_rates.ecb
Thanks @valic
DDEV nowdays feels superior to Lando/Docksal. Regionally there might be tendencies in favour of on or the other, but avoid biases, DDEV wins in tricky areas:
- xdebug is a one click breeze with ddev. Can't say that with Lando and Docksal
- ddev get, the addons market, has too many option readily available, and it is easy to create your own and add it to the market
- snapshots! Unless the other two added them and I lost the notication. Snapshots are amazing, especially when dealing with DB updates. It's very easy to get to the previous state and re-test
- overall it is faster than the competition
I'm also in favour of promoting DDEV.
bserem → created an issue.
Hey Valic! I did update db first and export config right after. A new export doesn't change anything, yet the import does fail.
Let me get back to you on Monday about this. I'll try to edit the file by hand as you suggest.
Thanks
Patch #2 is enough, there doesn't seem to be anything extra required. The errors highlighted at #6 are fixed by #2.
A new -dev release is created. If no issues appear I'll publish a new version soon (a month or so I guess).
Thanks @MrDaleSmith for the patch and the very thorough explanation of the issue, and @attiks for the test!
RTBC here too. I'm gonna bump this to critical, as the module is marked as D10 ready and there are production sites facing the issue after the upgrade.
Feel free to downgrade this back if I'm wrong here.