Mandatory parameters missing

So this is an entity type where $entity->toUrl() is broken - that is quite interesting. Looking at https://git.drupalcode.org/project/group_content_menu/-/blob/3.0.x/src/E... it looks like the entity that is causing this is quite broken. It's tricky to know what to do here. We can change

    try {
      $this->urls[$this->key($entity)] = $entity->toUrl()->toString();
    }
    catch (EntityMalformedException | UndefinedLinkTemplateException) {
      // If we cannot create a URL then there is no URL to record.
    }

to catch more generic exceptions to work around broken entities but I think the correct thing here is for the group_content_menu to throw an EntityMalformedException exception. So I'm going to move this issue to that module and do that change.

The funny thing about this is that the entity being saved here is going to be deleted when

/**
 * Implements hook_ENTITY_TYPE_delete().
 */
function group_content_menu_group_delete(EntityInterface $entity) {
  // Remove the group menu and recursively its links on group deletion.
  foreach (group_content_menu_get_menus_per_group($entity) as $group_relationship) {
    $group_relationship->getEntity()->delete();
  }
}

runs...

So the save is a complete waste of energy...

That said this change is still correct - we should emit the correct exception at this point.

Potentially 📌 Plugin config: Delete entity along with GroupContent Needs review would help with #5 - but as said there I think this fix is worth it in its own right.

Always helpful with a test.

Automatically closed - issue fixed for 2 weeks with no activity.