- Issue created by @tgoeg
- 🇦🇹Austria tgoeg
Looks good to me, perfect!
You chose "visually-hidden" and it seems to work well on a bootstrap-based theme. I wonder if this is universally applicable to all templates? It seems to be inherited from the "stable" theme in my case. I am not 100% we can rely on this to exist anywhere?
- 🇬🇷Greece bserem
Merging following the "looks perfect" review. Thanks both of you.
Should the need arise for further improvements we can open a new issue in the future.
Why not just remove the label element entirely and use an aria-label on the button?
That's how I've got it patched. If you go that route I won't need to patch it anymore.
'#attributes' => [ [...] 'aria-label' => 'Answer Yes, this page was helpful',The label markup appears replicated when rendering, which might be another issue that this solves too.
- 🇦🇹Austria tgoeg
I am not an a11y pro - my initial description stems from an a11y certification authority that suggested to solve it that way.
https://stackoverflow.com/questions/22039910/what-is-aria-label-and-how-... mentions bad support for aria-label. The referenced page seems quite dated. Do you know whether things have changed to the better in the meantime?
The description of `aria-label` indeed seems to fit better than adding a label that has to be hidden anyway.
- Status changed to Fixed
2 months ago 3:44pm 17 February 2025 Automatically closed - issue fixed for 2 weeks with no activity.