- 🇷🇺Russia shra
For 2.1.3 patch honeypot-js_timelimit_for_cached_pages-2820400-53-1.patch has an issue - module already has implemented hook_update_8101, so we need to change function name to honeypot_update_8103() in the patch.
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - 🇬🇷Greece bserem
Just by checking at the code, the patch in #61 (and all previous ones) rely on jQuery Once, but this is not supported on Drupal 10 any more.
The patch is not compatible with Drupal 10.
- last update
over 1 year ago PHPLint Failed - Status changed to Needs review
over 1 year ago 12:14pm 28 December 2023 - last update
over 1 year ago Patch Failed to Apply - 🇬🇷Greece bserem
Added an MR based on patch on #61, updated to not rely on jquery once but on core/once.
- 🇺🇸United States tr Cascadia
Yes, that's exactly what the "Patch Failed to Apply" results in #61 are telling you. It is a malformed patch.
If you would like to help, please re-roll the patch so that it applies. The MR in #63 is also malformed, with different problems.
- Status changed to Needs work
12 months ago 5:53pm 24 April 2024 - 🇺🇸United States tr Cascadia
Should still be "Needs work" because neither the patch nor the MR apply.
- last update
11 months ago 26 pass, 4 fail - 🇺🇸United States tr Cascadia
I don't know what #69 is supposed to be. There are all sorts of out-of-scope changes in there, as well as regressions and outright wrong changes like removing update functions and changing the schema.
Please clean up your patch and provide an interdiff and explanation for what you've changed since #61.
- 🇮🇪Ireland anthonylindsay
Adjusting a patch from the MR at 63 so that it applies to 2.1.4 and doesn't clash with update hook numbers.
- 🇺🇸United States tr Cascadia
@anthonylindsay: Not going to do this in 2.1.x, this will need to go into 2.2.x.
Can you update the MR? Drupal.org no longer tests .patch files, so the only way to get the automated tests to run is to put it into a MR. Probably easier to just open a new MR for the 2.2.x branch rather than deal with rebasing from 2.1.x.To get this issue back on track we really need an MR that passes all tests, and that includes a new test for the features introduced by this patch.
- 🇨🇦Canada joseph.olstad
@TR, please add a link to the antibot module in the project page of this project. I realize that honeypot has been around a lot longer however antibot is a serious alternative.
Maybe also steal some ideas.
- 🇺🇸United States tr Cascadia
Done. It would be nice to get this issue completed however and get those contributions put in here.
- First commit to issue fork.
- 🇺🇸United States tr Cascadia
@bserem: You added the "anrt-sprinting" tag 18 days ago - is your group still planning to contribute to this issue?
@hmdnawaz: Thank you for contributing, but how does your MR differ from MR!22?
The new MR fails eslint, phpcs, and phpstan tests.
Additionally, there are no new tests added to test this new functionality.These are why the issue was marked as "Needs work", and it should stay as "Needs work" until they are fixed.
- 🇵🇰Pakistan hmdnawaz
It differs from MR 22 because MR 22 is for version 2.1 and this new MR is for the 2.2.x version.
I will try to fix the phpcs and eslint issues in the new MR
- 🇮🇪Ireland anthonylindsay
Testing the latest MR and I don't think it works :(
It applies cleanly to latest 2.2 release, but turning on time-limit protection breaks page cache. - 🇬🇷Greece bserem
@tr that's the plan, it's a monthly thing. Do you want me to remove the tag?
- 🇺🇸United States tr Cascadia
@bserem: The tag is fine. Your help would be greatly appreciated