Drupal 10 compatibility

Thank you, for having time maintain this important bulk uploading module.
Which saves big time for editors.

Hoping for a soft commit to the 8.x-2.x branch, to ease testing with Drupal 10 sites.
As soft tag release ( pre-release ) would speed up testing with Drupal ~10.0 using the composer.

Testing now with git clone --branch '8.x-2.x' https://git.drupalcode.org/project/media_bulk_upload.git
And git apply for the patch

Not sure if a new branch 3.0.x could be in uses. It is not listed in the Branch to work from or in Releases
It feels that you had a 3.0.0 tag release, but had it changed to not supported.
Happy with basic soft release on the 8.x-2.x

Facing the following issue in Drupal 10 and Drupal 9
#1903010: Notice: Undefined index: #field_name in file_managed_file_save_upload() →

Had Real physical testing round for Media Bulk Upload 3.0.x-dev with Drupal ~10

Build Drupal ~10.0 sandbox test site and have Drush ~11.0

mkdir -p /var/www/html/sandboxes
composer create-project drupal/recommended-project:~10.0 /var/www/html/sandboxes/drupal10media_bulk_upload_3__test
cd /var/www/html/sandboxes/drupal10media_bulk_upload_3__test/
composer require drush/drush:~11.0;

Change minimum stability to dev for testing on the recommended Drupal 10 project template

composer config minimum-stability dev

Add the required DropzoneJS module.

composer require drupal/dropzonejs:~2.0 ;

Add assets repository

composer config repositories.assets composer https://asset-packagist.org
composer config --unset repositories.0
composer config repositories.drupal composer https://packages.drupal.org/8
composer config --json extra.installer-types '["npm-asset", "bower-asset"]'
composer config --json extra.installer-paths.web\/libraries\/dropzone '["npm-asset/dropzone"]'
composer config --unset extra.installer-paths.web\/libraries\/\{\$name\}
composer config --json extra.installer-paths.web\/libraries\/\{\$name\} '["type:drupal-library", "type:bower-asset", "type:npm-asset"]'

composer require oomphinc/composer-installers-extender:~2.0
composer require npm-asset/dropzone:~5.0 ;

Add the Media Bulk Upload module

mkdir -p /var/www/html/sandboxes/drupal10media_bulk_upload_3__test/web/modules/contrib
cd /var/www/html/sandboxes/drupal10media_bulk_upload_3__test/web/modules/contrib/
git clone --branch '3.0.x' https://git.drupalcode.org/project/media_bulk_upload.git

Git apply the needed patch

cd /var/www/html/sandboxes/drupal10media_bulk_upload_3__test/web/modules/contrib/media_bulk_upload/
wget https://www.drupal.org/files/issues/2023-01-16/3333989_media_bulk_upload_2.patch
git apply 3333989_media_bulk_upload_2.patch

Change file/directory mod and ownership of files:

cd /var/www/html/sandboxes/drupal10media_bulk_upload_3__test/
sudo chmod 775 -R .;sudo chown www-data:$USER -R .;

Install with Drush

./vendor/drush/drush/drush site:install standard --yes --site-name="Media Bulk Upload 3.0.x-dev - Real physical testing with Drupal ~10" --account-name="webmaster" --account-pass="d" --account-mail="test@drupal.org" --db-url="mysql://root:123___@localhost/sandboxes_drupal10media_bulk_upload_3__test" -vvv ;

./vendor/drush/drush/drush pm:enable media_bulk_upload

# The following module(s) will be enabled: media_bulk_upload, media
# 
#  Do you want to continue? (yes/no) [yes]:
#  > 
# 
#  [success] Successfully enabled: media_bulk_upload, media

./vendor/drush/drush/drush pm:enable media_bulk_upload_dropzonejs

# The following module(s) will be enabled: media_bulk_upload_dropzonejs, dropzonejs
# 
#  Do you want to continue? (yes/no) [yes]:
#  > yes
# 
#  [success] Successfully enabled: media_bulk_upload_dropzonejs, dropzonejs

Rebuild the cache:

sudo chmod 775 -R .;sudo chown www-data:$USER -R .;
./vendor/drush/drush/drush cache:rebuild

Open a browser and change the address to: http://localhost/sandboxes/drupal10media_bulk_upload_3__test/web/

Tested after a configuring under Drupal 10 and Drupal 9
Tested upload with media_bulk_upload_dropzonejs
It is working in both D10 and D9.

Having the Full Real Physical Testing Round command in the following attached file
Real-physical-testing-round-for-media_bulk_upload-3-0-x-dev--with-d10-and-d9.zip →

This is the one of few modules which prevent our upgraded to D10!
Please add a new version.

Created an issue fork for #2
Thanks, Aleksander

git clone git@git.drupal.org:issue/media_bulk_upload-3333898.git
cd media_bulk_upload-3333898/
git checkout 3333898-8-x-2-x
wget https://www.drupal.org/files/issues/2023-01-16/3333989_media_bulk_upload_2.patch
git apply 3333989_media_bulk_upload_2.patch
git commit -m 'Issue #3333898: Drupal 10 compatibility' --author="Aleksander Riumshin <39979-stomusic@users.noreply.drupalcode.org>" .
git push origin 3333898-8-x-2-x 

MR !6 worked fine for me.

Tested on the 3.0.x branch too
Create a MR for the branch

git clone git@git.drupal.org:issue/media_bulk_upload-3333898.git
cd media_bulk_upload-3333898/
git checkout 3333898-3-0-x
wget https://www.drupal.org/files/issues/2023-01-16/3333989_media_bulk_upload_2.patch
git apply 3333989_media_bulk_upload_2.patch
git commit -m 'Issue #3333898: Drupal 10 compatibility' --author="Aleksander Riumshin <39979-stomusic@users.noreply.drupalcode.org>" .
git push origin 3333898-3-0-x

Tested patch #2. Good to release.

Any schedule for the release? Do you need another tester?

I tested #9 this morning successfully. Something went wrong with letting drush do the installation and so I backed up and re installed it through the main user interface. Then I successfully uploaded about ten files.

Thx.

I've been added as a co-maintainer so I'm going to look at this one now and try to get it merged in shortly.

Switching to 3.0.x branch. For some reason, there is no 3.x branch. If there was, I would create a 3.1.0 release after merging this but instead I'll do a patch release even though that seems a bit odd.

See related issue regarding versions: 📌 Sort out versions for Media Bulk Upload Fixed

I've tested on 9.5.7 and 10.0.7 by:

1. Installed and configuring dropzonejs and media_bulk_upload per the README files
2. Added two media_bulk_upload config forms
3. Went to content media page and clicked the bulk button
4. Chosen one of the forms
5. Chose media and uploaded
6. Verified media was in media list
7. Checked the media was correct

9.5.7

10.0.7

I see that the code changes to use setPermanent so I checked and D8.0 does have this function. If we are keeping, D8 support in the info file like it is now, we really should test it on D8, but I'm going to skip that given there is the 8.x-1.x branch they can use which is identical other than moving the dropzonejs support into a submodule.

https://git.drupalcode.org/project/drupal/-/blob/8.0.x/core/modules/file...

I think I've convinced myself this can be merged to the 3.0.x branch since I'm not going to create a 3.1.x branch.

I assigned credits. I've not yet added credit for these people:

@java008 The issue should not be moved to RTBC before testing. When you said you reviewed the PR, it's assumed you mean the code. In the future, you should be more explicit about what you have done and understand the process to know what else needs to be done before moving to RTBC. Check out my blog post for more details: https://www.kristen.org/content/my-drupal-issue-queue-rtbc-cheat-sheet

@rckstr_rohan "MR !6 worked fine for me." is not enough information when reviewing and testing an issue. Please see the RTBC post noted above. You are expected to provide much more information than what you have. Also see #23 where I tested and noted my rough testing steps and provided screenshots. This issue could have also have had a video instead of screenshots.

@le72 @roaldnel Just passing comments so credit is not normally given for these.

For @java008 and @rckstr_rohan, I will consider giving your credit here if you read the blog post noted above and add a comment here that you read it and understand how to contribute better on future issues. Thanks!

Merged to 3.0.x branch. Thanks, everyone! I look into making a release next.

Automatically closed - issue fixed for 2 weeks with no activity.