- π³π±Netherlands Coen van Vliet
Adding a patch with the suggested change.
- π³π±Netherlands Martijn de Wit π³π± The Netherlands
Think we also have to modify the way, the extra fields are going to display in the new CK5 link pop-up
- πΊπΈUnited States chrissnyder Maryland
For CKEditor 5, the ckeditor_link_styles β module provides similar functionality.
- π¬π§United Kingdom danthorne Devon, UK
Thanks @ChrisSnyder
Just had a play with your module but currently there's no way to choose only one style. Example there could be 2 button styles and the editor could tick both by mistake.
Also this module adds attributes in the editor like
data-drupal-button-link="button" data-drupal-button-link-style="button--primary"
instead of just adding the class, which avoids admin theme conflict. Example, the gin admin theme also has a class of button, which looks different to the button that will be rendered in the frontend. - πΊπΈUnited States bakulahluwalia Houston
#7 patch works just fine. No issues in the existing buttons as well. Any plans to merge it to upcoming release?
Hi,
Any updates on this please?
We would need a fix as well.
We've applied the patch but I don't see the type and styles dropdowns anymore.
Thanks!- π³π±Netherlands Martijn de Wit π³π± The Netherlands
Will check this in coming weeks.
- π«π·France ericdsd France
Hi is there any progress on this, i'd be happy to help testing as a non dev.
- Assigned to Martijn de Wit
- π³π±Netherlands Martijn de Wit π³π± The Netherlands
Seems we have to rewrite a part of the module and create an upgrade path.
- Status changed to Needs work
about 1 year ago 10:04am 30 October 2023 - @martijn-de-wit opened merge request.
- Issue was unassigned.
- π«π·France ericdsd France
Great to see this issue is moving, i'll be glad to help testing once needed.
-
Martijn de Wit β
committed 175c901c on 3.0.x authored by
beljaako β
Issue #3307959 - Bugfix | add condition (cherry picked from commit...
-
Martijn de Wit β
committed 175c901c on 3.0.x authored by
beljaako β
-
Martijn de Wit β
committed c4d08d82 on 3.0.x
Issue #3307959 - work in progress @todo write all javascript / ckeditor...
-
Martijn de Wit β
committed c4d08d82 on 3.0.x
- π¬π§United Kingdom danthorne Devon, UK
CKEditor 4 is no longer supported as of today.
- π³π±Netherlands Martijn de Wit π³π± The Netherlands
We are developing the new version at the 3.x branch.
PHP part is roughly done. JS part has to be done. - πͺπΈSpain dima.iluschenko Malaga
Hi @Martijn de Wit!
Do you know the approximate date when this will be ready?