Contrib.social

Automated Drupal 11 compatibility fixes for duration_field

Open on Drupal.org →
Created on 17 March 2024, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

2.1

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment about 1 year ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-121090

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !12Automated Project Update Bot fixes → (Open) created by project update bot
  • Comment 10 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-181965

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.1
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.1
  • Comment 10 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-185727

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.1
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.1
  • Comment 10 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-188138

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.2
  • Comment 10 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-199781

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Comment 7 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    Not addressed yet but maybe a good hint for follow ups:

    Deprecated API use for APIs removed in future Drupal major versions is not required to fix yet.

    web/modules/contrib/duration_field/src/Element/DurationElement.php 41 Class Drupal\duration_field\Element\DurationElement extends deprecated class Drupal\Core\Render\Element\FormElement. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. use Drupal\Core\Render\Element\FormElementBase instead.

    web/modules/contrib/duration_field/src/Element/GranularityElement.php 20 Class Drupal\duration_field\Element\GranularityElement extends deprecated class Drupal\Core\Render\Element\FormElement. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. use Drupal\Core\Render\Element\FormElementBase instead.

  • First commit to issue fork.
  • Merge request !20Drupal 11 compatibility → (Open) created by Unnamed author
  • First commit to issue fork.
  • Pipeline finished with Failed
    4 months ago
    Total: 272s
    #363625
  • Pipeline finished with Success
    4 months ago
    Total: 249s
    #363640
  • Comment 4 months ago →
    heddn Nicaragua

    MR20 is now green. LGTM as it blocks https://www.drupal.org/project/datetime_extras → . All I did to this MR was review and make one minor fix to a test to get it green. I think that means I can still mark this RTBC.

  • Pipeline finished with Success
    4 months ago
    Total: 261s
    #363657
  • Pipeline finished with Failed
    3 months ago
    Total: 1695s
    #381931
  • Pipeline finished with Failed
    3 months ago
    Total: 210s
    #382425
  • Pipeline finished with Canceled
    3 months ago
    Total: 380s
    #382442
  • Comment 3 months ago →
    🇮🇳India abhi_khandelwal Gandhinagar
  • Comment 3 months ago →
    🇮🇳India manishvaity

    MR!20 Makes this module compatible with Drupal 11. Functionality is working as expected.

    RTBC +1

  • Comment 3 months ago →
    heddn Nicaragua

    With force pushes and a series of confusing commits, I'm not sure what has happened since #12 when I last RTBCed this thing. It looks like my changes even disappeared. And we've regressed from green passing tests to failures. This is not RTBC ready.

  • Comment 3 months ago →
    🇪🇸Spain Francisco Sierra Madrid

    Hi, folks. Thanks for maintaining this very useful module.
    Are there any plans for releasing a D11 compatible version shortly?
    Thanks!

  • Comment 3 months ago →
    🇭🇺Hungary nagy.balint

    I tried to reach out to the maintainers via their contact form, but received no response so far.

    @heddn, Hi! Do you have your version from #12 somewhere so we could restart from there?

  • Comment 2 months ago →
    🇺🇸United States weekbeforenext Asheville, NC

    If anyone needs a patch that can apply to 2.1.0 you can use this file. The MR patches don't apply because the packaging info is in the duration_field.info.yml file. This is a bandaid fix.

  • First commit to issue fork.
  • Status changed to Needs work about 2 months ago
  • Comment about 2 months ago →
    🇺🇸United States bluegeek9

    bluegeek9 → changed the visibility of the branch 8.x-2.x to hidden.

  • Comment about 2 months ago →
    🇺🇸United States bluegeek9

    bluegeek9 → changed the visibility of the branch 3429986-automated-drupal-11 to hidden.

  • Comment 13 days ago →
    🇩🇪Germany Anybody Porta Westfalica

    Drupal 11 is out for some time and the module still isn't D11 compatible while widely used. Any further plans, at least for the dev version?
    Thanks! :)

  • Comment 13 days ago →
    🇷🇴Romania claudiu.cristea Arad 🇷🇴

    Two issues here:

    1. It would be good to address also #8 📌 Automated Drupal 11 compatibility fixes for duration_field Needs review because is listed by upgrade_status as an issue
    2. To make sure everything works, we need to add a .gitlab-ci.yml that ensures testing for both, Drupal 10 and 11.
  • Comment 12 days ago →
    🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

    Is the plan to go D11 at 2.x and 3.x or only 3.x ?

  • Comment 12 days ago →
    🇺🇸United States bluegeek9

    Testing is expanded to D10 and D11 here: 📌 Set up initial CI/CD automation Active

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024