🇭🇺Hungary @nagy.balint

interdiff

@drupov
Hi!
Thanks for the merge request.

I needed to be able to select the allowed text formats, and also the schema was missing the new settings.

I made a patch file for now for review, but if it is good then we can add it to the merge request of course.

Thanks!

If I understand correctly, this will fix new routes, but already created routes remain broken, and so an update hook would be required?

On one of our sites where content entity builder was used to create a base field on an entity, we got the undefined index as in the title.

The patch #4 fixes the issue.

I sent a message via the contact form to @ajay_reddy at 27th of September 2025

nagy.balint → created an issue.

Then would simply installing this module work as well?
https://www.drupal.org/project/jquery_deprecated_functions →

Thanks!

Thank you for the patch!

I have the following feedback:

1. We use ConfigLogDatabaseSubscriber::$type to define "custom" so the line
+ ':input[name="log_destination[custom]"]' => ['checked' => TRUE],
should also use that.

And likely below in the getValue as well.

2. $config_log_conf->get('logs_to_keep') might be problematic if a site updates to this version and the config does not exist. It would be better to add a fallback value to that.

3. config_log.schema.yml and config_log.settings.yml is missing the new config item.

4. If logs_to_keep is int type, then it might be better to store a 0 in the else instead of $config->set('logs_to_keep', '');

Hi!

I cannot decide on this matter personally, as I am not the original owner of the project, but I committed your two merge requests.

Thanks!

Seems like phpcs is still failing.

Can't we improve the library instead?
https://github.com/noli42/chosen

Thanks!

Thanks!

Thanks!

Same here, issue fixed by patch #14

Based on my testing MR50 #6 fixes my issue. Seems to have no side effect in my case.

I have the same issue now.

I believe this commit broke the module, since
Fatal error: Uncaught Error: Class "Drupal\languagefield\Plugin\Field\FieldType\TranslatableMarkup" not found in languagefield/src/Plugin/Field/FieldType/LanguageItem.php:38

as the commit introduced

  label: new TranslatableMarkup("Language"),
  description: new TranslatableMarkup("An entity field to store a custom language."),

but TranslatableMarkup is not in the "use" section.

Branch is incorrectly named, will fix soon.

Hi!

14 days passed, and I am still interested!

Hi!

If you can fix phpunit in a separate issue that would be awesome!

I can commit it quickly and then we can return to this.

This merge request is somehow incorrect, but the issue has been fixed in the Drupal 11 compatibility issue.

Thanks!

Thank you!

Hello!

14 days passed, and I am still interested.

I think that 4.x will only get small improvements and security/critical fixes but if it is a small change which has likely no negative effects then we can commit it.

If setTimeout is the simplest and more robust solution then we can go with that.

Likely easy to do since we already have chosen.claro defined, and just need to extend it with the gin specific ones.

So based on 🐛 Add Better Exposed Filters support Fixed
data-bef-auto-submit-exclude attribute was added, which was also in 4.x so by earlier version perhaps you meant 3.x

the issue that was solved by this is

As a consecuence, after updating to Better Exposed Filters to 6.0.4 or newer, and using Chosen on a select filter, makes the input search unusable because it auto-submits the form right after the user type just a character.

So then the solution here is to revert that change, but to solve the original issue in a better way.

As far as I saw core is also moving away from jQuery, so I think we will need a solution without jQuery.

Hi!

This issue description is incorrect since 5.x uses no jQuery.

More than a month passed without reply.

Moving to the project ownership queue.

Thanks!

We will need to fix the tests to make a new release though.

Thanks!

I guess it is best to commit this here.

Thanks!

Hello!

14 day passed.

I am still interested.

Thanks!

Thanks!

Moved it to Drupal.org project ownership as 1 month has passed already.

Not yet unfortunately.

I will move it to the project ownership queue.

Since the common practice is to create a new branch when we drop compatibility for major versions of Drupal,
I am pretty sure that defining core version as >=10 is not a good idea,
as we also know that this module will become incompatible with either Drupal 12 or Drupal 13, when the hook system is deprecated for example.

So it is better to define the compatibility the normal way
core_version_requirement: ^10 || ^11

Message sent via contact form to @adcillc at 20th of July 2025.

nagy.balint → created an issue.

2 weeks passed without reply.

I think this is an outdated issue at this point.

Can you provide more details on how I could reproduce the issue?

From the formatter definition

 * @FieldFormatter(
 *   id = "image_url_formatter",
 *   label = @Translation("Image URL Formatter"),
 *   field_types = {
 *     "image"
 *   }
 * )

This module currently only supports image field.

I think the gitlab ci file was not according to standards in the merge request, so I put in the correct one.

Also it is time to switch to the semver version, especially as we change the drupal core requirement to 10 and 11, then usually we would create a new branch anyways.

This is now fixed on the 2.0.x branch.

Issue created:
💬 Offering to co-maintain Image URL Formatter Active

I sent a message via contact form to @howard ge at 14th of July 2025

nagy.balint → created an issue.

Ok, thanks!

@nwom, Hi! Then likely we need to close this issue, as we surely do not want to officially mark the module unsupported for weeks.

It seemed that there was a way if the module became abandoned to then quickly promote a new maintainer, but then it seems it is not possible.

So I will need to create a new issue and start over the 2 week period unfortunately.

The 5.x branch is also available where we have a Vanilla JS version of Chosen, and there are already some accessibility fixes there, but we can add more: https://github.com/noli42/chosen
https://www.drupal.org/project/chosen/releases/5.0.2 →

I think that going forward mostly the 5.x branch will be maintained,
as to me it seems problematic that we need to add extra JS for things that should really be in the library itself.

Hi!

It is https://www.drupal.org/project/image_url_formatter →

I guess whichever solution gives us the shortest wait time. I guess if the project is marked abandoned then we don't need to wait another month?

I sent a mail via the contact form to @tamerzg at 10th of July 2025.

nagy.balint → created an issue.

I sent a message via the contact form to @sudishth at 10th of July 2025

Hi!

I can join as co-maintainer.
While I have no contributions on this project personally, but you can check my profile as reference for other projects.

We used the project on one of our sites, and I could help pushing out a D11 compatible release.

nagy.balint → created an issue.

Just marking 🐛 Weird updating issues with the dev version Active as duplicate, as likely my issue was the same as here.

I sent an email via contact form to @dave reid at 3rd of July, 2025.

nagy.balint → created an issue.

Switching to the OOP Hooks would require quite a big jump in Drupal core requirement, and so would likely be a new branch.

I would not mix these together, as parts of the module in the currently supported branch does not work currently, and so it requires this quickfix.

I can confirm that the patch in #2 fixed the issue.

I would argue that this is a critical issue since in its current state the node submodule does not do anything.

I share the patch file, since I have it already anyways.

nagy.balint → created an issue.

Now it is available at
https://asset-packagist.org/package/npm-asset/noli42--chosen
https://www.npmjs.com/package/@noli42/chosen

I think wrong queue.

I am not sure if the latest version of the module is used, since

$paragraph = $parent->getEntity(); is at line 80, and not 64.

Can you check if there is a dblog entry with an error message when this happens?

Are you using the "Mercury Editor" module or it is only a normal install and the edit page of a node?

I tried but could not reproduce it on my site.