- Issue created by @nagy.balint
- πΊπΈUnited States john.oltman
The class is no longer needed due to enhancements in the core registration module. Make sure you updated that module in tandem. I kept the test file as it exercises the link formatter in ways that only commerce registration can, so it is worth keeping. I do see that I need to update the comment in that test file, which I will take care of.
As far as the error goes, clear cache and it should go away. If that doesn't do it, I'll need the name of the include file or a full trace, you should be able to get that from the logs. Tests are passing so it is unlikely anything other than the comment in the test file needs changing, but we will see.
- ππΊHungary nagy.balint
Thank you for the quick reply!
Unfortunately cache clear did not help, but I will have time to check tomorrow, to see what more information I can provide.
- ππΊHungary nagy.balint
Thank you again,
It seems the issue is that this site I took over actually extended this plugin.
I will see if I can add back the plugin in custom code.
- πΊπΈUnited States john.oltman
Ah, I was afraid of that. I wonder if you can change the extending class to inherit from the link formatter in registration core. If you need any assistance please feel free to ping me directly through my Drupal.org contact form.
- πΊπΈUnited States john.oltman
There is also a case to be made that I should have deprecated the two formatter classes I removed but kept them there as null classes - meaning they simply extend the core registration formatters with no overrides - so as to avoid the issue you are running into. Let's see how your rewrite goes. For now I will reopen the issue in case I decide to add the classes back.
- ππΊHungary nagy.balint
Just an update.
After some more review it seemed that the formatter that was in the Commerce Registration module is basically the same as the one in the Registration module in the new version at least.
So I inherited from the Registration module and then it started to work, however I still had to patch the formatter in the Registration module because there are new conditions now that was not there in the past like that the user needs to have permission to create a registration entity to see the button.
This is only an issue because the idea was that anonymous user sees the button, and then it goes to a login screen.However I was thinking that maybe an empty class that inherits everything from the main Registration module could work to avoid the error for others. But it is true that due to the condition changes it won't be perfect.