Support time entries in FlatpickrDateBef filter plugin

Created on 22 January 2025, 3 months ago

Problem/Motivation

As discussed on BEF module's #3500976 issue , BEF datepicker support days / months / years but not time entries. Since the jQuery UI datepicker they are using doesn't support time entries itself, and since Flatpickr does, it would be nice if the datetime_flatpickr_bef submodule could handle it.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Active

Version

3.0

Component

Code

Created by

🇫🇷France MacSim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @MacSim
  • 🇭🇺Hungary nagy.balint

    This will need more testing, but I got a first working version.

    It has an issue where on first setup it throws an error, but then if the view is saved it works fine afterwards. Not sure why it does that.

    I did not test it with min-max (2 date filter) yet, but tests run fine.

  • 🇭🇺Hungary nagy.balint

    It works with is between now too.

    I leave it as needs work, because of the issue when enabling the plugin the first time.

  • 🇫🇷France MacSim
      - Syncing drupal/datetime_flatpickr (dev-3.0.x 9798387) into cache
    Gathering patches for root package.
    Gathering patches for dependencies. This might take a minute.
      - Installing drupal/datetime_flatpickr (dev-3.0.x 9798387): Cloning 9798387fdf from cache
      - Applying patches for drupal/datetime_flatpickr
        https://www.drupal.org/files/issues/2025-01-25/support-time-entry-in-bef-3501292-2.patch (Support time entries in FlatpickrDateBef filter plugin)
       Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2025-01-25/support-time-entry-in-bef-3501292-2.patch
    
  • 🇭🇺Hungary nagy.balint

    I am not sure about the previous comment, as it is already committed see #4

    I just left it open since BEF throws an error when it is initially added, maybe it is a BEF issue, not sure at this point.

  • 🇫🇷France MacSim

    My bad I saw the "needs work" status and the patch and didn't realised it was already merged to 3.0.x

Production build 0.71.5 2024