- Issue created by @michaellander
- Status changed to Needs review
4 months ago 4:18pm 7 August 2024 - πΊπΈUnited States michaellander
This version seems to fix issues around overriding the
Drupal\image\Controller\ImageStyleDownloadController
completely and is much more elegant. We will need to test to make sure everything is flushing correctly when the image is replaced. - πΊπΈUnited States michaellander
This should give us a path forward for modules like ImageAPI Optimize AVIF β to run alongside this module without needing glue modules like ImageAPI Optimize AVIF & WebP β .
- Status changed to Needs work
4 months ago 6:38pm 7 August 2024 - πΊπΈUnited States michaellander
I had this consistently working and now with a fresh install it's not... needs more work.
- Status changed to Needs review
4 months ago 8:08pm 7 August 2024 - π«π·France tostinni
For those still on 2.0.0 here is a patch from the MR16.
- π³π±Netherlands Martijn de Wit π³π± The Netherlands
Needed this path after we've got an error after upgrading the module
PHP Fatal error: Declaration of Drupal\imageapi_optimize_webp\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style) must be compatible with Drupal\image\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style, string $required_derivative_scheme) in ..../web/modules/contrib/imageapi_optimize_webp/src/Controller/ImageStyleDownloadController.php on line 36
we are on php v 8.3.1
using D Core 10.3.6