🇫🇷France @tostinni

Allow entities in CKEditor

Here is a patch to update the module to use seboettg/citeproc-php

tostinni → created an issue.

Issue is outadted, see 📌 Automated Drupal 10 compatibility fixes Needs review which also provides Drupal 9 compatibility.

Here is an updated patch that also includes :

• Update of .info.yml file for Drupal 10 compatibility
• Fixes for class attributes that need to be arrays
• Various notice or unused variables cleaned

I think this can be marked as duplicate of 📌 Automated Drupal 10 compatibility fixes Needs review

See 🐛 Removal of jquery_ui_draggable in 2.0.3 causes failures with upgrade on some sites Active .

+1, in fact 8.x-1.1 and also 8.x-1.2 (tagged but not published) are compatible with Drupal 10, so a release needs to be published.

Fixes made for D10 :

• 💬 Drupal 10 compatibility Fixed
• 💬 Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Fixed

Hi @scott_euser, I created a MR for @olivier.br to commit only the change in the source file.

tostinni → made their first commit to this issue’s fork.

Hi @scott_euser, sorry for the late reply, I let this slipped a little too long.
Regarding your comment about not touching the compiled filed, I had done it this way as only assets/js/ckeditor/plugin.js was modified and also this was for CK 4 which, imho, doesn't come with compiled JS.

I created a MR if it's easier for you to review.
Thank you

Well for the moment, this project has been pretty quiet as you were the first to make an issue.

Have a look at the code and if you see some big improvement, yes that could be an option.

Do you currently use it ? Is your project requiring OpenID Connect V1.4 or 3.0 ?

Hi mably, sorry for the late reply.

This module was part of a project we don't maintain anymore and we haven't take the time to document it properly for an official release.

This is now fixed with a Drupal 10 version available.

Don't hesitate to contact me if you need more details regarding FranceConnect implementation.

We also added a text change when the user is a moderator, this could probably use a new configuration text.

      $default_text = $entity->access('update') ? $this->t('Moderate Meeting') : $this->t('Join Meeting');
      $form['submit'] = [
        '#type' => 'submit',
        '#value' => $display_options["join_button_text"] ? $display_options["join_button_text"] : $default_text,
        '#attributes' => ['class' => ['btn-accent']],
      ];

tostinni → created an issue.

Using 1.2.0 on a fresh install we still ahve this issue.
As mentioned by trickfun in #6 the problem appears when Sendinblue is sending some fields with no type.
Patch in #7 fix the issue.

Sorry for the commit against 1.0.x branch, here is the MR

tostinni → changed the visibility of the branch 1.0.x to hidden.

tostinni → created an issue.

tostinni → created an issue.

Switch to needs review

tostinni → created an issue.

It looks like it has been commited, see https://git.drupalcode.org/project/term_merge/-/blob/2.0.0-beta6/src/For...

Can anyone share an updated YAML to migrate a CT using this patch ?
Thank you very much.

Parts of other patches were included in #16, updating with patch working against beta6.

You might be interesed by the solution offered in ✨ Use checkbox and radio instead of Select, Provide better user experience Needs review (with a search box and "Display all terms" option) or also ✨ Offer an autocomplete version Needs review .

This can be closed as it's been fixed in 2.0.0-beta6, see 855fee6a.

This can be closed as it's been fixed in 2.0.0-beta6, see 855fee6a.

This can be closed as it's been fixed in 2.0.0-beta6, see 855fee6a.

This can be closed as it's been fixed in 2.0.0-beta6, see 855fee6a.

We had a website with 10k terms which created 2 problems:

• huge and slow term merge page
• need to search for a specific term

We decided to adress this by limitating the display of terms to 20 and add a "Display all terms" checkbox to load the whole list (we could have added a load more, but with the search feature, this doesn't seem that useful).

We also added an ajax search input that will search for terms matching the characters in it.

I put this as a patch to avoid highjacking the MR, but if there is some interest I can create a new MR.
The code could use some work to polish what is done but is functional.

tostinni → created an issue.

tostinni → created an issue.

tostinni → created an issue.

Thanks for the improvements, I added a natural sort using natcasesort() so terms with lowercase/uppercase get grouped together.

Regarding the checkbox, yes that's an improvement, but I was wondering about providing an empty radio for the target list of terms because contrary to select list, once you checked a radio you can't uncheck it. I haven't implemented this yet.

tostinni → made their first commit to this issue’s fork.

Switching to need review

tostinni → created an issue.

tostinni → made their first commit to this issue’s fork.

MR created.

tostinni → created an issue.

MR done.

tostinni → created an issue.

tostinni → created an issue.

We had a problema applying #141 following the change of getMetada() into getRawMedata in ✨ Add a hook to modify oEmbed resource data Needs work #59

So here is a patch to apply those changes.

Thank you Scott.

Indeed when we implemented this, we hid the footnote number field as we thought it was confusing to the editor and let the system calculate the number. Then this patch made sense.

Thanks for the followup and the patch for ✨ Provide a JS alternative to the PHP-driven Footnotes Group like Footnotes All Block module Needs review

scott_euser → credited tostinni → .

Hi quantum3k, have you found a solution ?

Thanks

Switching to needs review.

Here is the patch updated for 5.0.0-beta3 and the reroll diff (only some very light changes in the patch due to #3075276: Adding option to prepend referenced entities if desired → creating some offset).

Here is a patch to cast this number as a string so the width is correctly calculated.
It also add a default value of 0 only in the render of CKEditor when we used to have fn.

Although I prefer the old fn I kept the decision to render 0 instead.

tostinni → created an issue.

Here is an updated version of the patch to handle the changes in ImageFormatter Class.

@marcoka have a look at https://www.drupal.org/project/ckeditor5_embedded_content → which is pretty neat to have a UI for formatting content.

Is there any reason to having added this line in importTaxonomiesForce()

@@ -697,6 +726,7 @@ class TaxonomiesController extends ControllerBase {
 
               $entity_properties = [
                 'vid' => $vid,
+                'tid' => $taxonomy['tid'],
                 'langcode' => $taxonomy['langcode'],
                 'name' => $taxonomy['name'],
                 'description' => [

Because it will break when importing taxonomies in a site where newer terms have been created.

As this patch currently only works with force, I recommend to use it with #3271724: Force import for taxonomy deletes all terms regardless if they're managed by structure sync →

@mogio_hh using the patch commited and staying on Drupal 9.5.10
As I'm not into using dev version, I prefer using the patch directly in composer.json

        "patches": {
            "drupal/paragraphs_ee": {
                "[3383301] Paragraphs are shown under the Add Paragraph button": "https://git.drupalcode.org/project/paragraphs_ee/-/commit/7273fedd312954f8229677dc0a873d11d47d20c5.diff"
            }
        }

I stumbled upon this searching for a simple way to put a nid IN (1, 23, 456) inside my view so here are my solutions:

Using exposed filter:

For this you add the ID and choose regex and put your value like this: (^1$|^23$|^456$)
This way, using ^1$ will match only 1 and not all ID containing 1.

Using contextual filter

This is the easiest way, add an ID contextual filter, and choose  "Provide default value", put 1+23+456 and don't forget to check "Allow multiple values" in the more section.

I can confirm this is fixing the error when using Drupal 9.5.10, paragraphs 8.x-1.16 and Gin admin theme.
Thank you

For those stumbling on this issue, Paragraphs 8.x-1.16 fixes this problem, see 🐛 Paragraphs actions button are removed when Claro admin theme is used Fixed

Here is the patch to fix this.

tostinni → created an issue.

Here is the correct patch.

As we could have a multidimensionaly array, I decided to flatten it like this:

$items_values = array_merge([], ...$item['items']);
$info_markup .= implode('</li><li>', $items_values);

Pervious patch was buggy with some configurations, adding a new patch.

Adding MR for this code.

For those interesting to test it you need to change your composer.json repositories section like this:

    "repositories": [
      {
          "type": "git",
          "url": "https://git.drupalcode.org/issue/daterangepicker-3383923.git"
      },
      {
          "type": "composer",
          "url": "https://packages.drupal.org/8",
          "exclude": ["drupal/daterangepicker"]
      }
    ],

And then launch composer require drupal/daterangepicker:dev-3383923-jquery-ui-datepicker-2.0

tostinni → created an issue.

Still happening on Drupal 10.1 and Smart Date 4.0.3

We've changed a little bit the patch so it can apply to Claro but also to Gin and works a little better with submenus as shown in #47 video.

We haven't tested yet on RTL theme and also the vertical admin menu bar for Gin is not functional, so keeping status as Need work.

Fix code for Drupal 10 and add an alternative using hook_form_alter

Patch is working fine on Drupal 10.1

This is a duplicate of 🐛 PHP Warning when no role settings saved. RTBC

tostinni → created an issue.

Duplicate of 🐛 Site crashes after uninstalling module Active

Here is the patch to fix those problems.

tostinni → created an issue.

I guess this is a duplicate of 🐛 InvalidArgumentException empty string Closed: duplicate

@andrew.farquharson yes this was the code I was refering to.
As said @louis-cuny I guess we'll keep this for the moment and see during the rewrite how to implement this as a service.

A small change to support Translatable menu link uri → module through the link_override field.

This way you can translate the URI and it will be exported to.

Thanks for you help @keshav.k but you only changed the camel case.

Here is an updated patch to fix all 3 points mentioned by @louis-cuny in #4

Regarding the dependency injection, I'm not 100% sure if it's the correct approach as we had a statically instantiated class MenuLinksController() so I called it like this (I got this idea from Ajax Comments module and it's used in several parts in Core):

    $menuLinksController = MenuLinksController::create(\Drupal::getContainer());
    $menuLinksController->exportMenuLinks($form, $form_state);

Thanks for the patch, it fixes the permission problems that we had when the editor was able to modify the content but not viewing it.

Ok it seems this patch seems no longer useful, for 1.0, I'm removing this patch and maybe someone could confirm and this issue ?

Fixed patch

FYI, this issue ✨ Support for translations of menu items Needs review contains code that handles extra fields besides multilingual.

I had also some problems with the previous patch using the UI (Warning: Illegal string offset 'menu_name') and the safe import, so here is an updated patch that Works for me™ ^^

Thank you for the work on this.

Thank you I hadn't seen this issue :)

Here is the patch to sort the menu link content.

It retrieves first the menu tree using

$tree = \Drupal::menuTree()->load($menu_name, new \Drupal\Core\Menu\MenuTreeParameters());

And then a recursive function to flatten it and finally sort the links using this flattened array.

There may be a better function, but this one is working fine for us.

tostinni → created an issue.

Following comment from @daveiano adding the test if the user can add new terms to the current vocabulary.

tostinni → made their first commit to this issue’s fork.

MR created for this fix.

tostinni → created an issue.

I updated the patch for 7.x-1.0

Adding a small fix that prevent a link in the footnote that would being replaced by (0).

@srdtw this should fix the (0) that are visible in your screenshot ;)

Thanks for the patch.

What was the idea of implementing some hooks for this instead of automatically export/import all fields ? Because this would require an extra task to create a custom module in order to fully export/import a menu with fields.

The method suggested in structure_sync.api.php wasn't working for us, probably because we're on an old Drupal (8.9.20) as this code was returning an empty value $options = $menuLink->link->first()->options;

So here is an implementation using the API to find the fields of the menu and export them. It will however work only for single valued fields and would need to be extended to entity reference, formatted text etc...

/**
 * Implments hook_structure_sync_menu_link_export_alter() to deploy field_subtitle.
 */
function souk_deploy_structure_sync_menu_link_export_alter(&$item, \Drupal\menu_link_content\Entity\MenuLinkContent $menuLink) {
  // Retrieve all extra fields from the menu link and export them
  $fields = $menuLink->getFieldDefinitions();
  foreach ($fields as $field_name => $field_definition) {
    if (!empty($field_definition->getTargetBundle())) {
      if (!$menuLink->{$field_name}->isEmpty()) {
        $item[$field_name] = $menuLink->{$field_name}->value;
      }
    }
  }
}

tostinni → created an issue.

I can confirm that this patch also fixed these errors that we had after testing 9.5.5 which was breaking the language switcher.

- Notice: Trying to get property 'links' of non-object in Drupal\dropdown_language\Plugin\Block\DropdownLanguage->build() (line 147 of modules/contrib/dropdown_language/src/Plugin/Block/DropdownLanguage.php).
- Warning: Invalid argument supplied for foreach() in Drupal\dropdown_language\Plugin\Block\DropdownLanguage->build() (line 186 of modules/contrib/dropdown_language/src/Plugin/Block/DropdownLanguage.php).
- Warning: count(): Parameter must be an array or an object that implements Countable in Drupal\dropdown_language\Plugin\Block\DropdownLanguage->build() (line 238 of modules/contrib/dropdown_language/src/Plugin/Block/DropdownLanguage.php).