Contrib.social

Attribute alt (and image_style) not allowed on element div in HTML5

Open on Drupal.org →
Created on 7 October 2019, over 5 years ago
Updated 7 July 2023, almost 2 years ago

Problem/Motivation

Attribute alt not allowed on element div in HTML5. This causes errors in HTML validation. If you provide it to Google Search, AMP pages will not appear in search results.

<div data-embed-button="media_browser"
     data-entity-embed-display="media_image"
     data-entity-embed-display-settings="small"
     data-entity-type="media"
     data-entity-uuid="XXXXXXXXXXXX"
     alt="myImageAlt" //This causes errors
     title="myImageTitle"
     data-langcode="ja"
     class="embedded-entity align-center">
    <amp-img src="/sites/default/files/styles/small/public/images/myImage.jpg?itok=XXXXXXXX"
             width="700"
             height="510"
             alt="myImageAlt"
             title="myImageTitle"
             layout="responsive">
    </amp-img>
</div>

Proposed resolution

Remove alt attribute from div element that rendered from <drupal-entity> .

<div data-embed-button="media_browser"
     data-entity-embed-display="media_image"
     data-entity-embed-display-settings="small"
     data-entity-type="media"
     data-entity-uuid="XXXXXXXXXXXX"
     // just removed alt with `attributes.removeAttribute('alt')` in twig.
     title="myImageTitle"
     data-langcode="ja"
     class="embedded-entity align-center">
    <amp-img src="/sites/default/files/styles/small/public/images/myImage.jpg?itok=XXXXXXXX"
             width="700"
             height="510"
             alt="myImageAlt"
             title="myImageTitle"
             layout="responsive">
    </amp-img>
</div>

Remaining tasks

reviews needed

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇯🇵Japan Tomotsugu Kaneko

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024