Catch TamperException to prevent import from crashing

tnx potassiumchloride!
20# work for me

Updating patch in #17 fixing the broken tests.

We are using this patch internally and it is working as expected.

Pablo's patch also worked for us.

Gracias por compartir,
m.

#22 worked for me.
+1 for RTBC

Can this be converted to an MR? That way the tests can be run for additional confirmation.

tostinni → changed the visibility of the branch 8.x-2.x to hidden.

We've been using this patch for preventing crash when exploding empty values.
Here is a MR with it.

Setting to "Needs work" as the phpunit tests aren't passing.

Seems that the test that is not passing is not from this patch Drupal\Tests\feeds_tamper\Functional\FeedTypeListBuilderTest::testDeltaIncreaseWithManyTampers
https://git.drupalcode.org/issue/feeds_tamper-2983197/-/pipelines/386006...

It would be worthwhile to also check if ✨ Improve handling of empty data Active could solve some issues. I would love some feedback there on the latest changes.

The issue with the solution here is that it results into Tampers getting skipped and that could be bad (see #10). Though letting the import crash is probably worse. I hope to address this issue in more depth in a few months, after I got the Tamper module into the beta stage.

Upon an exception, an item can now get marked as invalid. This causes the item to fail validation and the item will not be imported.

Depends on ✨ Allow parsers and event subscribers to mark an item as invalid Needs work .

Result of applying the Tamper plugin "Filter items" while the source data is a string instead of an array:

And in the log (Feeds Log module):

I confirm that the patch works fine along with the patch on the Feeds module.

I'm also attaching a patch that applies successfully to beta4 version in case someone needs to use the sateble version of the module instead of dev.

I merged the code! This issue took a long time to resolve, because in the past years I had put most of the time into getting Feeds to a stable release.

For the most optimal experience the latest dev of Feeds is required. ✨ Allow parsers and event subscribers to mark an item as invalid Needs work has been merged as well.

When this gets into a release of Feeds Tamper I plan to create a new Feeds release on the same day.

Automatically closed - issue fixed for 2 weeks with no activity.