- Status changed to Needs review
about 2 years ago 12:26pm 5 June 2023 - last update
about 2 years ago 37 pass - 🇪🇸Spain plopesc Valladolid
Updating patch in #17 fixing the broken tests.
We are using this patch internally and it is working as expected.
- 🇪🇸Spain mbria Sabadell
Pablo's patch also worked for us.
Gracias por compartir,
m. - 🇯🇵Japan ptmkenny
Can this be converted to an MR? That way the tests can be run for additional confirmation.
- First commit to issue fork.
- 🇫🇷France tostinni
tostinni → changed the visibility of the branch 8.x-2.x to hidden.
- 🇫🇷France tostinni
We've been using this patch for preventing crash when exploding empty values.
Here is a MR with it. - 🇯🇵Japan ptmkenny
Setting to "Needs work" as the phpunit tests aren't passing.
- 🇫🇷France tostinni
Seems that the test that is not passing is not from this patch
Drupal\Tests\feeds_tamper\Functional\FeedTypeListBuilderTest::testDeltaIncreaseWithManyTampers
https://git.drupalcode.org/issue/feeds_tamper-2983197/-/pipelines/386006... - 🇳🇱Netherlands megachriz
It would be worthwhile to also check if ✨ Improve handling of empty data Active could solve some issues. I would love some feedback there on the latest changes.
The issue with the solution here is that it results into Tampers getting skipped and that could be bad (see #10). Though letting the import crash is probably worse. I hope to address this issue in more depth in a few months, after I got the Tamper module into the beta stage.
- 🇳🇱Netherlands megachriz
Upon an exception, an item can now get marked as invalid. This causes the item to fail validation and the item will not be imported.
Depends on ✨ Allow parsers and event subscribers to mark an item as invalid Needs work .
Result of applying the Tamper plugin "Filter items" while the source data is a string instead of an array:
And in the log (Feeds Log module):