Allow parsers and event subscribers to mark an item as invalid

Open on Drupal.org →

Created on 20 June 2019, almost 6 years ago

Updated 19 April 2025, about 2 months ago

Problem/Motivation

🐛 Catch TamperException to prevent import from crashing Needs work tries to prevent an import from crashing if an unapplicable tamper plugin gets applied to a source. A tamper plugin is for example not applicable to a source if the tamper plugin expects the source to be in certain format when the source isn't. For example, the tamper plugin "implode" expects the source to be an array and throws an exception if it doesn't.

The patch from the issue noted above now catches an exception and records an error message for it. The problem is that the import of the item goes through, only just without the tampers applied. This can possible lead to unintended values being imported.

Removing the item from the parser result is also not an option, because then it might be removed from the site if the feed type is configured to delete previously imported items.

Proposed resolution

A possible solution is to be able to mark an item as invalid, by adding new methods to \Drupal\feeds\Feeds\Item\ItemInterface.

Then, during processing, Feeds needs to detect that the item is marked invalid. And if so, don't import it. And report which item is invalid.

Remaining tasks

Implement a solution.
Add test coverage.
Review.
Commit.

User interface changes

None.

API changes

\Drupal\feeds\Feeds\Item\ItemInterface gets new methods.

Data model changes

None.

Release notes snippet

New methods are added to \Drupal\feeds\Feeds\Item\ItemInterface: items can now be marked as invalid.

✨ Feature request

Status

Needs work

Version

3.0

Component

Code

Created by

🇳🇱Netherlands megachriz

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Merge Requests

!210Allow parsers and event subscribers to mark an item as invalid
Open
🇳🇱Netherlands megachriz
updated 17 days ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Merge request !210Patch from #6, with changes to EntityProcessorBase removed for now, to make... → (Open) created by megachriz
Comment about 1 month ago →
🇳🇱Netherlands megachriz
For backwards compatibility I have moved the new methods to a new interface called ValidatableItemInterface. Feeds Tamper can then check if the item implements that interface before trying to call the new methods. This way, Feeds can still be compatible with older Feeds versions.

Let's see if the test passes now.
Comment about 1 month ago →
🇳🇱Netherlands megachriz
I see that the new properties are also exported when calling BaseItem::toArray(), which I think we don't want. So these properties should not be exported. So that should get fixed, but perhaps before we do that it makes sense to finalize 🐛 Creation of dynamic property Drupal\feeds\Feeds\Item\SyndicationItem::$parent:fid is deprecated Needs work first, because in that issue BaseItem::toArray() gets also changed. And I think that issue is good to go, just waiting a few more days for possible feedback on that one.
Comment 17 days ago →
🇳🇱Netherlands megachriz
This is now ready to be tested in combination with 🐛 Catch TamperException to prevent import from crashing Needs work for Feeds Tamper.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024