@pearls

Thanks all. I just tested MR!2 now. It works fine with custom/default comment types.
Just started a new little problem;
There's a warning as "/history/get_node read timestamps" in recent dblogs when a member replies a comment.

pearls → created an issue.

I tried your advices. This patch is not for v5 and there has been no progress after a long time..It didn't work.
Also I tried this module ( Views Default Argument: Entity Field Values → - similar to your advice).

After three days, my searches and different attempts have not yielded any results.
I guess I have to go back to book module.
I have given up.
Thank you very much for your support.

I still think this feature is necessary because a book(any content) can be a creative final work that no one wants it to be expanded upon by others. There are situations where no one wants to interfere with other people's work.
Therefore, members should be limited to choosing their own content.
No one should be able to add their own content to someone else's book or parent content. Or, permissions can be extended or limited based on the type of node.
Another benefit is that the outline list will be shorter when selecting/searching for a book/parent from a bunch of books.

+1 for following
Facing same problem.

pearls → created an issue.

Hi Lee,
Yes , You're right. It'a about revisions.

I created two test.

First one
Parent:Course
Child:Lesson
Create new revision option: No

It worked perfect.

Then I created new one
Second example
Parent:Teacher
Child:Student
Create new revision option: Checked

When I create a lesson-course or class-teacher contents I saw the same error.
The same error appears in some of the contents(lessons) in the first example, which I do not understand.

I also created another block with revision id but the result is the same.

Then I deleted class-teacher contents and also content types.
Just only first example remained.

Now I can see sibling lessons again.

I couldn't understand why another type of content being revisable would cause an error.

So, any advice please. Thanks

pearls → created an issue.

pearls → created an issue.

pearls → created an issue.

I have encountered this error before, but I think the problem is related to MR!43.

Tested with Drupal 10.4.1 ECK 2.1.0-beta1 & 2.x-dev .
The error seems to be a bit serious. After these attempts, the test site cannot return to its previous state, sql:drop is required. A fresh test site was used each time.Since I could not pass this stage, I did not have the opportunity to test it with other related eck modules.

Here's the dblog records with fresh install.

When I try to add the entity type, if I don't select the revisionable option;

Drupal\Core\Entity\Exception\UnsupportedEntityTypeDefinitionException: The entity type organization does not have an "revision_created" entity revision metadata key. in Drupal\eck\Entity\EckEntity::revisionLogBaseFieldDefinitions() (line 35 of core/lib/Drupal/Core/Entity/RevisionLogEntityTrait.php).

If I select the revisionable option;

Drupal\Core\Entity\Exception\UnsupportedEntityTypeDefinitionException: The entity type organization does not have an "owner" entity key. in Drupal\eck\Entity\EckEntity::ownerBaseFieldDefinitions() (line 33 of core/modules/user/src/EntityOwnerTrait.php).

Detailed log

The website encountered an unexpected error. Try again later.

Drupal\Core\Entity\Exception\UnsupportedEntityTypeDefinitionException: The entity type organization does not have an "owner" entity key. in Drupal\eck\Entity\EckEntity::ownerBaseFieldDefinitions() (line 33 of core/modules/user/src/EntityOwnerTrait.php).
Drupal\eck\Entity\EckEntity::baseFieldDefinitions() (Line: 230)
Drupal\Core\Entity\EntityFieldManager->buildBaseFieldDefinitions() (Line: 195)
Drupal\Core\Entity\EntityFieldManager->getBaseFieldDefinitions() (Line: 454)
Drupal\Core\Entity\EntityFieldManager->getFieldStorageDefinitions() (Line: 490)
Drupal\Core\Entity\EntityFieldManager->getActiveFieldStorageDefinitions() (Line: 187)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->__construct() (Line: 149)
Drupal\Core\Entity\Sql\SqlContentEntityStorage::createInstance() (Line: 280)
Drupal\Core\Entity\EntityTypeManager->createHandlerInstance() (Line: 84)
Drupal\trash\TrashEntityTypeManager->createHandlerInstance() (Line: 68)
Drupal\trash\TrashEntityTypeManager->getHandler() (Line: 51)
Drupal\trash\TrashEntityTypeManager->getStorage() (Line: 69)
Drupal\Core\Entity\EntityTypeListener->onEntityTypeCreate() (Line: 150)
Drupal\eck\EntityUpdateService->doEntityUpdate() (Line: 120)
Drupal\eck\EntityUpdateService->applyUpdates() (Line: 144)
Drupal\eck\Entity\EckEntityType->postSave() (Line: 563)
Drupal\Core\Entity\EntityStorageBase->doPostSave() (Line: 489)
Drupal\Core\Entity\EntityStorageBase->save() (Line: 257)
Drupal\Core\Config\Entity\ConfigEntityStorage->save() (Line: 354)
Drupal\Core\Entity\EntityBase->save() (Line: 617)
Drupal\Core\Config\Entity\ConfigEntityBase->save() (Line: 194)
Drupal\eck\Form\EntityType\EckEntityTypeFormBase->save()
call_user_func_array() (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers() (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm() (Line: 597)
Drupal\Core\Form\FormBuilder->processForm() (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 57)
Drupal\advban\AdvbanMiddleware->handle() (Line: 50)
Drupal\ban\BanMiddleware->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)

pearls → created an issue.

I saw same issue as mentioned in #31. Patch #18 fails.

MR!3 ( #29) is applied but now other problems.

When creating a new pattern it shows

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "node_type" plugin does not exist

For existing patterns, I see the error mentioned in the screenshot below.

Versions: Drupal version 10.4.1 Viev mode page: 4.0.3

+1 for "I need these answers too."

Thanks @shivam. MR !5 worked for me.
+1 for RTBC

I tested with Drupal 10.4 It may be about my test environment.
We can close this issue.

pearls → created an issue. See original summary → .

If a comparison cannot be made, I think there is no big point in Storage Module instead of using node revisions.
When I try to compare revisions in the views table the following log appears.

Symfony\Component\Routing\Exception\RouteNotFoundException: Route "entity.storage.revisions_diff" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 211 of core/lib/Drupal/Core/Routing/RouteProvider.php).

Maybe the maintainer is so busy or has stopped supporting the module because the scheduling isn't working either.

pearls → created an issue.

MR22 worked but MR24 didn't work for me.

pearls → created an issue.

#22 worked for me.
+1 for RTBC

New warning (line 129 of ...) repeats 4 times in my project after #2 patch.

pearls → created an issue.

pearls → created an issue.

I have the same issue. Also, you cannot remove the module clearly.

Be sure to back up your database and configuration before trying this module.

There were errors validating the config synchronization.                                                                             
  Unable to uninstall the <em class="placeholder">User revision</em> module because: This module cannot be uninstalled because Drupal  
   doesn't support converting an entity type from revisionable to non-revisionable.   

MR!88 worked for me.
+1 for RTBC

Thanks.
#4 Patch-11 worked for me.
+1 for RTBC

MR!9 didn't work for me. Cron is not running, publishing is still not happening at scheduled time. It still shows unpublished.
I've been waiting for this to be resolved for a long time, I was hoping it would be fixed with version 1.4 but the same problem persists. Thanks

pearls → created an issue.

Hi @anybody,
If you check the screencast, you will see that all node types are skipped by protection even if their form ID is not in the excluded list.
But it works for comment forms. Validation cannot be bypassed unless added to the exclude list.

Suggestion 1:
It can work as designed. But, the entity from id should be allowed to be entered separately according to its type. For example: node_article_form, node_page_form, node_forum_form or custom_non-node_entity_type_form etc.

Suggestion2:
It can be specified in text formats-editors as the most comprehensive option.
Thus, there is no need for a form ID. Whether the correct ID is added or not is not a problem. It can be added or excluded in different scenarios in text formats and editors in a very flexible way. Check Wordfilter → module, please.In my opinion, this is the best option.

Suggestion3:
The last option can be allowed in the node type settings, which will be the most restricted option. It will be a problem for other custom entity types.

It cares about all bundle forms. When you exclude an id, it affects the entire bundle.Instead of including the entire bundle, it should exclude the types separately.

For example;The flexibility in the forum may not be in the articles. That was the opening purpose of this issue.

İf you exclude node_forum_form (forum type) it will also excludes node_article_form. It will also bypass protection on articles.
or
For comments;
İf you exclude forum comment form id (comment_forum_comments_form) it also excludes article comment form (comment_comment_form)

Also it doesn't work other custom type entity like ECK. It bypass them.
Thanks

Tested. #5 patch worked for me.
+1 for RTBC

#4 @murz Is this accurate information? How did you measure that view mode page module eats too much CPU and memory.
I would be very happy if you could enlighten me. Thanks

pearls → created an issue.

Sorry for the insufficient information.

I am trying to use entityconnect in storage → forms.

Reference field using select2 form. I also tested with autocomplete or other select widgets
Even if I change the field form format, the following error occurs.

Warning: foreach() argument must be of type array|object, string given in Drupal\entityconnect\EntityconnectFormUtils::validateForm() (line 101 of modules/contrib/entityconnect/src/EntityconnectFormUtils.php).

Could the problem be because I'm using custom entity(storage) instead of node type?

Thanks for support.

pearls → created an issue.

pearls → created an issue.

pearls → created an issue.

pearls → created an issue.

pearls → created an issue.

#93 worked for me. Drupal version : 10.3.8

Merge request !7274 could not be applied.

This issue still exists and I experienced it with a taxonomy term field.

Here's the dbLog when I try to add limit to media entities.

Warning: foreach() argument must be of type array|object, null given in Drupal\entity_limit\Plugin\EntityLimit\RoleLimit->getLimitCount() (line 213 of /var/www/html/d10site/web/modules/contrib/entity_limit/src/Plugin/EntityLimit/RoleLimit.php)

Could you also support custom entity types other than node type? It only works with node types.

MR 11 Tested.
During configuration import, warning "Missing bundle entity, entity type flag, entity id email_node." was not received.
+1 for RTBC

I have the same issue while importing the configuration.

The rank field is created via weight module which can contain negative numbers.
I thought it was related to negative number.s Even though the problem is solved (it is fixed here - #3484686 💬 Support: Indexable negative number Active .), I still get an error while importing the config.

I don't know if the problem is related to the negative numbers or weight module, but the problem with importing the configuration still persists.

 [error]  Drupal\search_api\SearchApiException while adding Views handlers for field Content » Rank on index Default content index: Could not retrieve data definition for field 'Rank' on index 'Default content index'. in Drupal\search_api\Item\Field->getDataDefinition() (line 487 of /var/www/html/d10Site/web/modules/contrib/search_api/src/Item/Field.php).
 [error]  Drupal\search_api\SearchApiException while computing Views data for index Default content index: Could not retrieve data definition for field 'Rank' on index 'Default content index'. in Drupal\search_api\Item\Field->getDataDefinition() (line 487 of /var/www/html/d10Site/web/modules/contrib/search_api/src/Item/Field.php).

There is a loop between the issues. Each one references each other and at the end of the day, it does not provide any solution. There is no different situation for Version 2. The problem still persists.By the way, patch in #24 is not applied and does not work.

Thanks but It didn't work for me.

pearls → created an issue.

It works only node entities. I tried with other custom entities built with Storage, Flag etc. but without success.
Its name should be node limit instead of entity limit.

I don't know if it fixed the entire problem, but after the patch the warning disappeared.
+1 RTBC for MR23 for now.

pearls → created an issue.

Thanks @drunken monkey.
Please, confirm me if I need both MR(184-185).
Tested. I used both MR and it worked. It indexed without any warning/error.
+1 for RTBC

pearls → created an issue.

pearls → created an issue.

+1 for RTBC

pearls → created an issue.

+1 for RTBC.
Thanks @acbramley.

However, the same problems occur in Address, Dynamic Entity Reference, Office Hours modules. #3480456-Fatal error occurs 🐛 Fatal error occurs Active
Maybe other modules that I don't know about also have this problem.

Wouldn't it be better to approach the issue through the Diff module?
Because it may be necessary to integrate a separate solution for each different module.

Thanks for patch but it didn't work for me because I also have two similar errors from two separate modules.
I'm not sure if a separate integration is needed for each relevant module.

Dynamic Entity Reference Module

Fatal error: Declaration of Drupal\dynamic_entity_reference\Plugin\diff\Field\DynamicEntityReferenceFieldBuilder::build(Drupal\Core\Field\FieldItemListInterface $field_items) must be compatible with Drupal\diff\Plugin\diff\Field\EntityReferenceFieldBuilder::build(Drupal\Core\Field\FieldItemListInterface $field_items): array in /var/www/html/d10site/web/modules/contrib/dynamic_entity_reference/src/Plugin/diff/Field/DynamicEntityReferenceFieldBuilder.php on line 25

Smart Date Module

Fatal error: Declaration of Drupal\smart_date\Plugin\diff\Field\SmartdateFieldBuilder::buildConfigurationForm(array $form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\diff\FieldDiffBuilderBase::buildConfigurationForm(array $form, Drupal\Core\Form\FormStateInterface $form_state): array in /var/www/html/d10site/web/modules/contrib/smart_date/src/Plugin/diff/Field/SmartdateFieldBuilder.php on line 63

There's a solution for smart date here. Fix diff 2.x integration 🐛 Fix diff 2.x integration Needs review
But if there is a possibility of getting this similar error in different modules, it would be better to approach the situation on a diff basis.

#2 >> @nicrodgers I'm not sure which MR or patch is really worked.
There are 3 mergeable MRs in " #2950869 - Entity queries with large number of revisions query last revision very slowly 🐛 Entity queries querying the latest revision very slow with lots of revisions Needs work ".

Scheduler module is affecting everywhere in terms of performance.
Any advice or experienced guide would be great. Thanks

It's really annoying, especially when using Scheduler Module.
So, does anyone have any experience to share? Which MR should be considered?
Any advice , please ? Thanks

@avo I tried #4. It works fine for administrator role.
But if a non-administrator role (with "AdministerUsers byRole" permission) changes anything on the user entity, the same problem occurs again.

pearls → created an issue.

pearls → created an issue.

If anyone is experiencing this problem and only needs to import terms, try this module as a temporary alternative solution.
The way it works is similar to Taxonomy Manager. There is also a bulk delete function. Taxonomy Fast Import →

I have the same problem.

If anyone has encountered this type of problem, they can follow this. #3481711-Reference method of reference field switches to first available in list if previously set to default 🐛 Reference method of reference field switches to first available in list if previously set to default Active

It is really interesting. ECA does not affect my project structure.Even if I uninstall ECA, it does not change, the problem persists.
I still haven't figured out what the main factor is.
Let me give you another example.
For example, let's say Dependent Fields and Taxonomy manager modules are active. This time, instead of ECA option, the "Make field dependent using views" option, which comes as an option of the Dependent Fields module, is selected.
However, when I uninstall Taxonomy Manager, the problem goes away.
As you said, maybe it is a core issue. Thanks for support.

pearls → created an issue.

Thanks Sarwan.It works.

Tested.
After MR!2, "Lock field values ​​checkbox" disappeared .
You see that the Lock Values ​​Checkbox does not appear when you try to edit a member profile.

There is a boolean field in user entity that triggers role assignment when it'ss value is on.There are also text fields that should not be changed.
In some scenarios, the administrator needs to lock these field for some users. I use the module for these fields. However, even if the administrator does not touch any of these field, It keeps giving the errors mentioned in the previous comment.
@kul, Thanks for support .

pearls → created an issue.

I tried to use Role Delegation module instead of Administer Users by Role.
The Role Delegation module does not give an error with ECA when you need to assign a role, but somehow it prevents the ECA model from working.
Rules module is an alternative to ECA. It does not give an error when assigning role rules. But there too, sometimes the rule doesn't work and sometimes it does.I don't know what the problem is with Rules, I haven't looked into it deeply.

Finally I stopped using administerusersbyrole and role delegation modules. Instead of taking advantage of both modules, I removed them to make ECA work properly, which I needed more on other sides.

Thanks mohd. Tested. Now we have 2 issues. Here's the log.

Deprecated function: reset(): Calling reset() on an object is deprecated in lock_field_values_preprocess_field() (line 47 of /var/www/html/mysite/web/modules/contrib/lock_field_values/lock_field_values.module)

#0 /var/www/html/mysite/web/core/includes/bootstrap.inc(166): _drupal_error_handler_real()
#1 [internal function]: _drupal_error_handler()
#2 /var/www/html/mysite/web/modules/contrib/lock_field_values/lock_field_values.module(47): reset()
#3 [internal function]: lock_field_values_preprocess_field()
#4 /var/www/html/mysite/web/core/lib/Drupal/Core/Theme/ThemeManager.php(261): call_user_func_array()
#5 /var/www/html/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(491): Drupal\Core\Theme\ThemeManager->render()
#6 /var/www/html/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(248): Drupal\Core\Render\Renderer->doRender()
#7 /var/www/html/mysite/web/core/modules/node/node.module(550): Drupal\Core\Render\Renderer->render()
.....................

Error: Call to undefined method Drupal\Core\Field\BaseFieldDefinition::getFieldDefinition() in lock_field_values_preprocess_field() (line 50 of /var/www/html/mysite/web/modules/contrib/lock_field_values/lock_field_values.module).

Thanks @mohd. It seems ok.No warning for new policies added.

pearls → created an issue.

pearls → created an issue.

Token value can not be saved when you try to set a default value.
Versions: 8.x-1.x-dev & Drupal 10.3.6

Thanks Rajan. The patch has been applied but there is an error.

ArgumentCountError: Too few arguments to function _restrict_abusive_words_get_words_list(), 0 passed in /var/www/html/mysite/docroot/modules/contrib/restrict_abusive_words/src/Form/AddWordsForm.php on line 61 and exactly 1 expected in _restrict_abusive_words_get_words_list() (line 35 of /var/www/html/mysite/docroot/modules/contrib/restrict_abusive_words/restrict_abusive_words.module).

#92 #95 (MR !45) didn't work for me. Contextual filter (content ID from url) still does not work.

+1 for the approach to this issue compared to the other one( #2786479 ✨ Drush comand to export all items from entity with defined criteria Needs review ).
I think bundle limit is useful and necessary.

Is there any plan to support advban module?
Thanks

pearls → created an issue.

pearls → created an issue.

Wouldn't it be better to leave the issue status active? Maybe a different perspective can provide a solution.
Thanks anyway.

pearls → created an issue.

It only works if you select "Access denied" as the action..
By the way, it doesn't work with taxonomy terms with any options.

@bsuttis, issues are same. Drupal core version is same. (Upgraded to 10.3.5.)
The only difference is the php version I use is "8.3.6".
I tested the patch on different projects but unfortunately the same warnings persist. The problem may be caused by the PHP version.
My luck :)) Looks like I have nothing to do but wait until the module update arrives.Thanks for support.

pearls → created an issue.

pearls → created an issue.

Thanks @lonalore.
+1 RTBC for #5