Automated Drupal 10 compatibility fixes

I noticed this patch does not update the info.yml file so Upgrade Status still reports Transaction as Incompatible after applying the patch.

I created a merge request for #3299343-3: Automated Drupal 10 compatibility fixes → and the necessary updates to the .info.yml file.

Here's a patch which makes the module compatible with D10

RTBC +1 for #17

Would be really great to get a D10 compatible version.

Hi Folks!

I've added a few changes to the MR regarding the access checks. It might be ok to use ->accessCheck() in places where we show transactions in the UI, e.g. in the list builders. However, we can't rely on the currently logged in user having access to the transactions in places which are critical for the functionality of the module and there we should explicitly disable access checking with ->accessCheck(FALSE).

Transactions can be created in cron or via a drush command and in these scenarios there is no current_user, i.e. they run as anonymous. The anonymous user doesn't need to (and really shouldn't) have access to see the transactions, so the calls to critical methods like getLastExecutedTransaction can return wrong values.

Agree to #22

What else is needed for a D10 version?

Davituri → changed the visibility of the branch transaction-3299343-3299343-automated-drupal-10 to hidden.

Davituri → changed the visibility of the branch transaction-3299343-3299343-automated-drupal-10 to active.

Sent a contact request to manuel.adan if he can merge this and make a new release.

I think it would be better if the new release was compatible with d11.

I added support for D11 and fixed the return types for the getIterator methods.
I'll try to contact Manuel via Slack and propose a release 🤞😉

Let's review this

I reverted Drupal 11 compatibility to be addressed separately right after ensuring compatibility with Drupal 10. It will simplify having a D10 compatible version ASAP. E.g. the Transaction IEF submodule is not compatible with Inline Entity Form >= 2.x and it has no 1.x version compatible with Drupal 11. I prefer not to work on that here.

Tests passed on D9 with PHP 8.1 and in D10 with PHP 8.1, 8.2 and 8.3 and didn't find any issues testing it on those scenarios.

Unfortunately, it doesn't work on Drupal 10 with PHP 8.4. We need compatibility with PHP 8.4 since Drupal 10.4 can run on top of this PHP version.