🇩🇪Germany @slowflyer

Just had this issue today on a 10.2.6 website. The related comments have been saved in the same second and resulted in same thread value.

From my point of view, this is or was never a bug of Open Social itself.

I would take a closer look in filesystem and webserver fileupload configuration.

I can not reproduce this error. (Using original filename).

OS 12.3.3, Drupal 12.2.5, PHP 8.3.3

It's not issue of Ajax Comments.

Seems to be an issue of:

  var getCkeditor = function (){
    return window.CKEDITOR || {
      on: function(event, callback) {
        callback();
      },
      instances: {}
    };
  }

in

social_mentions:
  js:
    js/social_mentions.js: {}

slowflyer → created an issue.

This causes the error:

display:
  default:
    id: null

This works:

display:
  default:
    id: default

I cant edit the view as well. When trying to edit I receive on Drupal 10.2.4, php 8.2:

Error: Call to a member function isEnabled() on null in Drupal\views_ui\ViewEditForm->getDisplayDetails() (line 421 of core/modules/views_ui/src/ViewEditForm.php).

Drupal\views_ui\ViewEditForm->getDisplayTab(Object) (Line: 212)
Drupal\views_ui\ViewEditForm->form(Array, Object) (Line: 107)
Drupal\Core\Entity\EntityForm->buildForm(Array, Object) (Line: 41)
Drupal\views_ui\ViewFormBase->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm('view_edit_form', Object) (Line: 283)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object, 'edit', Array) (Line: 230)
Drupal\views_ui\Controller\ViewsUIController->edit(Object, NULL)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 53)
Asm89\Stack\Cors->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Kingdutch → credited slowflyer → .

Kept messages and made them more general.

@dipakmdhrm: The submodule auto_alter_translate has no alternative provider. No need to remove any hook at all.
@dipakmdhrm: The reason why you received the error message was that no URL is defiend for Alttext.ai. Fixed that in code.

@miksha: Totally agree

New version available.

Removing all requirement code can not be the solution.

No matter which provider is used, configuration is needed.

Here's the patch to solve the issue.

slowflyer → created an issue.

RTBC +1

Deprecated function: str_starts_with(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\agreement\AgreementHandler->getAgreementByUserAndPath() (Zeile 154 in /mnt/web/mafo/html/modules/contrib/agreement/src/AgreementHandler.php)

Error occurs if:
$public_file_path = $this->settings->get('file_public_path')

$public_file_path is null. Seems php8.2 does not like it.

public function getAgreementByUserAndPath(AccountInterface $account, $path) {
    $agreement_types = $this->entityTypeManager->getStorage('agreement')->loadMultiple();

    $default_exceptions = [
      '/user/password',
      '/user/register',
      '/user/reset/*',
      '/user/login',
      '/user/logout',
      '/admin/config/people/agreement',
      '/admin/config/people/agreement/*',
      '/admin/config/people/agreement/manage/*',
    ];

    if ($public_file_path = $this->settings->get('file_public_path')) {
      $public_file_path = str_starts_with($public_file_path, '/')
        ? $public_file_path . '/*'
        : '/' . $public_file_path . '/*';
      // Adds the public file path to the default exceptions.
      $default_exceptions[] = $public_file_path;
    }
...

would fix it.

RTBC +1

This is an update issue of Open Social.

Take a look at: https://www.drupal.org/docs/drupal-distributions/open-social/updating#s-... →

This is not a bug of lazy module.

slowflyer → created an issue.

slowflyer → created an issue.

slowflyer → created an issue.

slowflyer → created an issue.

Seems not to be duplicate. At least patch #75 does not change any behavior on my end.

What else is needed for a D10 version?

slowflyer → made their first commit to this issue’s fork.

If needed, please open a new issue for #6

slowflyer → made their first commit to this issue’s fork.

slowflyer → changed the visibility of the branch 3411513-media-presave-error to hidden.

slowflyer → made their first commit to this issue’s fork.

RTBC +1

slowflyer → created an issue.

Same with latest 3.0.5

Even with removing $destination from code, not able to create a preset. More errors on form submit:

Drupal\Core\Config\Schema\SchemaIncompleteException: Entity type 'Drupal\video_transcode\Entity\Preset' is missing 'config_export' definition in its annotation in Drupal\Core\Config\Entity\ConfigEntityBase->toArray() (line 253 of core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php).

Agree to #22

Same issue on 2.x branch.

Would be really great to get a D10 compatible version.

slowflyer → created an issue.

RTBC +1 for #17

Patch fixing the issue and implemnting hook_user_delete

slowflyer → created an issue.

Included in https://www.drupal.org/project/transaction/issues/3299343 📌 Automated Drupal 10 compatibility fixes Needs review .

From my point of view, this issue should be closed and move the issue mentioned above moved forward for a Drupal 10 release in near future.

Will not be fixed on 8.x branch

RTBC +1

slowflyer → created an issue.

as mentioned in #2, that solves the issue

Thank You, Given patch is worked and website is loading fine.

Added to 2.0.x-dev

slowflyer → made their first commit to this issue’s fork.

slowflyer → created an issue.

• Added language support
• Added update path for existing installations
• Fixed Drupal 10 compatibility issue

Would be great, if this could happen ...

I had Social Lazy Loading Image installed in one project and was not able to send newsletters from the simplenews module with included images. When sending a test newsletter everything was fine, but when send out the newsletter to your subscribers Social Lazy Loading Image did remove all src attributes ...

It took really a long and hard confusing time to find the reason why ...

Joachim Namyslo → credited slowflyer → .

slowflyer → created an issue.

slowflyer → made their first commit to this issue’s fork.

slowflyer → created an issue.

Hope this more easy patch is more robust.

If you try to encrypt all email-addresses in your database and you are using field_encrypt for fields outside the user scope, you are able to set it up with the simplenews module for sending newsletters. That seems to work, except for the view with exposed filter for the email field.
The suggestions from #7 📌 Views exposed filter not returning results Active will make it hard to impossible to manage these subscribtions as you are used to.

Would be really nice to have the option to search for encrypted data.

slowflyer → created an issue.

Thanks @tt12, I already learned it the hard way. You will run into some serious trouble with in unicode.php, if no translation is available.
The modified patch works fine for me in my projects.

Joachim Namyslo → credited slowflyer → .

This happens when you try to uninstall the module.

You will fail and after that tables are removed, but the module not uninstalled.

From my point of view, function simplenews_scheduler_uninstall() needs to be removed.

After that you can do a clean install / uninstall of the module.

I had the same issue somewhere after updating from 11.6.3 to 11.7.2. Probably with the switch to 11.7.x

The attached patch solved the issue.

What needs to be done to get a 2.0.0-beta1 version?

slowflyer → created an issue.