- Issue created by @mably
- Merge request !29Issue #3487569 by mably: Rollback BC breaking change for encoder constructor → (Open) created by mably
- 🇳🇿New Zealand ericgsmith
My opinion is that there is no need for a 2.x branch for this change nor the change to the protected method as the BC policy is pretty clear about service constructors and protected methods.
That said - you have already started a 2.x branch so the work is largely done.
- 🇫🇷France mably
@ericgsmith are you ok to continue your current developments on the 2.0.x branch?
If so, I will merge this and make a
8.x-1.7
release.I've asked @jhedstrom to make
2.0.x
the new default branch. - 🇫🇷France mably
Nobody seems to care about those potential BC breaking changes for now.
We might not need to merge the rollback, let's still wait a few days though.
- 🇩🇪Germany slowflyer
Don't know if, this is relevant for this issue, I had to rollback from 8.x-1.6 to 8.x-1.5.
With 8.x-1.6 all text was added with thml formatting to to the xls instead of plain text as before. - 🇫🇷France mably
I think it is more probably related to this issue: 🐛 Make the formatValue filters configurable Needs work .
There are new options for stripping html tags, but they should be enabled by default AFAIR.
- 🇫🇷France mably
@slowflyer your problem could be related to this issue: 🐛 Fix warning in Encoder setSettings method Active
Could you give a try to the above issue's MR and see if it fixes your problem ?