Order of parameters is wrong

Created on 21 December 2023, about 1 year ago

Updated 16 January 2024, 12 months ago

Problem/Motivation

validateForm in AutoAlterTranslateSettingsForm does the following request

$request = $this->azuretranslate->gettranslation('Please translate this text', $endpoint, $api_key, $region, "en", "de");

Steps to reproduce

Form submit at /admin/config/media/auto_alter/translate

Proposed resolution

But the order of parameters is wrong, it should be
public function gettranslation(string $inputStr, $region = FALSE, $endpoint = FALSE, $api_key = FALSE, $fromLanguage = "en", $toLanguage = FALSE

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇵🇰Pakistan monymirza Islamabad

Live updates comments and jobs are added and updated live.

Merge Requests

!11Order of parameters is wrong
Merged
🇵🇰Pakistan monymirza
updated 12 months ago

Comments & Activities

Issue created by @monymirza
Merge request !11Issue #3410169: Order of parameters is wrong → (Merged) created by monymirza
Status changed to Needs review about 1 year ago6:18am 21 December 2023
Comment about 1 year ago →
🇵🇰Pakistan monymirza Islamabad
Comment 12 months ago →
System Message

6191689b committed on 2.0.x
Issue #3410169: Order of parameters is wrong
Status changed to Fixed 12 months ago8:59am 2 January 2024
Comment 12 months ago →
🇩🇪Germany slowflyer
Comment 12 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024