- Issue created by @slowflyer
- First commit to issue fork.
- Merge request !13Issue #3416656: Changes from using AccountProxyInterface to AccountInterface β (Merged) created by mradcliffe
- Status changed to Needs review
10 months ago 4:09pm 31 January 2024 - πΊπΈUnited States mradcliffe USA
This is a good idea. Thank you.
I think rather than using UserInterface, we can use AccountInterface, which the User entity also implements via UserInterface.
- Status changed to RTBC
10 months ago 8:08am 6 February 2024 - Status changed to Needs work
10 months ago 8:29am 6 February 2024 - π©πͺGermany slowflyer
Deprecated function: str_starts_with(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\agreement\AgreementHandler->getAgreementByUserAndPath() (Zeile 154 in /mnt/web/mafo/html/modules/contrib/agreement/src/AgreementHandler.php)
Error occurs if:
$public_file_path = $this->settings->get('file_public_path')$public_file_path is null. Seems php8.2 does not like it.
public function getAgreementByUserAndPath(AccountInterface $account, $path) { $agreement_types = $this->entityTypeManager->getStorage('agreement')->loadMultiple(); $default_exceptions = [ '/user/password', '/user/register', '/user/reset/*', '/user/login', '/user/logout', '/admin/config/people/agreement', '/admin/config/people/agreement/*', '/admin/config/people/agreement/manage/*', ]; if ($public_file_path = $this->settings->get('file_public_path')) { $public_file_path = str_starts_with($public_file_path, '/') ? $public_file_path . '/*' : '/' . $public_file_path . '/*'; // Adds the public file path to the default exceptions. $default_exceptions[] = $public_file_path; } ...
would fix it.
- Status changed to Needs review
10 months ago 2:57pm 7 February 2024 - πΊπΈUnited States mradcliffe USA
Okay, made a couple of fixes, and I think this is ready again. Thank you for the review.
- Status changed to RTBC
10 months ago 2:11pm 9 February 2024 -
mradcliffe β
committed 76816e13 on 3.0.x
Issue #3416656 by mradcliffe, slowflyer: Replace AccountProxyInterface...
-
mradcliffe β
committed 76816e13 on 3.0.x
- Status changed to Fixed
10 months ago 3:47pm 9 February 2024 - πΊπΈUnited States mradcliffe USA
Merged. Thank you again for your review and opening up the issue.
I'll make a new alpha release shortly to help in your implementation.
Automatically closed - issue fixed for 2 weeks with no activity.