View block support on Gutenberg is limited. Changing this as a feature request.
marcofernandes → made their first commit to this issue’s fork.
marcofernandes → created an issue.
Work committed on parent issue 📌 Update Gutenberg core library (4.x) Active
marcofernandes → made their first commit to this issue’s fork.
marcofernandes → created an issue.
There's this workaround for now (not tested). Taken from #Gutenberg channel:
I believe you can override the react component responsible for the button.
So this is the "Back Button" component:
https://git.drupalcode.org/project/gutenberg/-/blob/3.0.x/js/components/...You could create your own component and override the global var:
window.DrupalGutenberg.Components.BackButton = [your-component];And then override the library settings:
https://git.drupalcode.org/project/gutenberg/-/blob/3.0.x/gutenberg.libr...
Although the work with the configuration is done and just needs some tests, we need to change the way the editor is loaded on a entity edit form. This will be addressed here: ✨ New entity form when Gutenberg is enabled Active
marcofernandes → created an issue.
thorandre → credited marcofernandes → .
Re-opening this issue because Media module is not mandatory and it should work with the media library provided by Gutenberg.
The problem is that, in order to provide the full editing experience, we have to do some alters on the node/entity edit form. But, if a theme (admin) also does alter the same form, it has priority and might override Drupal Gutenberg's changes. For example, if a theme provides a node edit form template a bit different from Claro, it is enough to break Gutenberg.
We're trying several options in
📌
Entity type agnostic
Active
to mitigate this issue.
Ah... the 3.x branch shouldn't be used. I had issues removing it but now I was able to remove it. Anyway, you should use 3.0.x. Maybe you could just close that MR and create a new branch from 3.0.x and MR?
marcofernandes → created an issue.
marcofernandes → created an issue.
marcofernandes → made their first commit to this issue’s fork.
Merged. Thank y'all 😉
marcofernandes → made their first commit to this issue’s fork.
Merged. Great work, thanks!
I've been playing a bit integrating
AI module that you mention →
with Gutenberg. But didn't progress much.
I think a good example of what Drupal Gutenberg should take inspiration is the AI Writer plugin.
It seems it needs more work. Check MR review.
marcofernandes → changed the visibility of the branch 8.x-2.x to hidden.
Finally merged to 2.x and 3.0.x. Great work y'all 😉
marcofernandes → made their first commit to this issue’s fork.
marcofernandes → made their first commit to this issue’s fork.
marcofernandes → created an issue.
marcofernandes → made their first commit to this issue’s fork.
marcofernandes → created an issue.
marcofernandes → created an issue.
Work has started on the Experience Builder initiative in order to make possible to use SDC on a UX context
📌
[SPIKE] Comprehensive plan for integrating with SDC
Active
.
In Gutenberg, we could add support for SDC similar to what we did with Drupal blocks but I think the best approach is to wait for the outcome in XB context and then see what would be possible.
We already have something similar at the hook_uninstall. The issue is that Gutenberg can't be uninstalled while its filter plugin is being used in the Gutenberg text format.
Not sure if Drupal has some kind of "force" mechanism for uninstalling modules.
Another solution would be try to add a button at the uninstall page to remove that text format.
@loze I reviewed and tested it. Great work!
Merged to 3.0.x. I'll keep this issue open if someone wants to do a MR for 8.x-2.x.
marcofernandes → created an issue.
Patch included
marcofernandes → created an issue.
We're having issues on Gitlab CI, specifically on the phpunit (max PHP version) job:
Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: The configuration key "autoconfigure" cannot be used to define a default value in "modules/custom/gutenberg-3456995/gutenberg.services.yml". Allowed keys are "public", "tags", "autowire".
But it succeeds on the other phpunit jobs 🤔
@alexpott That'll work. Thanks.
Note that also adding the tags to the gutenberg.media_library.opener service would also work.
gutenberg.media_library.opener:
class: Drupal\gutenberg\MediaLibraryGutenbergOpener
tags:
- { name: media_library.opener }
But, I guess, this way, we don't have to worry about other autoconfigurable services that may come up.
Btw @doxigo, you're observing this on the editor page (node editing), right? Because Gutenberg JS files shouldn't be loaded on frontend.
Although there's those webpack comments (only on JS files), we're using a "production" build. It can be compared to the WP Gutenberg plugin: https://wordpress.org/plugins/gutenberg/
The packages are generated by core's Gutenberg build script.
CSS files don't have any comments.
I'm not sure if it's worth the time to change/replace core Gutenberg's build script to remove those webpack comments just to make Lighthouse happy on a backend page. 😅
Gutenberg Cloud was discontinued (no longer available on 3+). On 2.x will display empty because the the API is no longer available.
If anyone interested in continuing it, just take the code from 2.x and create a new module.
Duplicate 🐛 Javascript Errors in Drupal 10.1 Fixed
@doxigo Yeah, unfortunately d.o is a bit strict with branches naming/versioning. The idea of having 3.x branch was to avoid managing minor versions. I merged 3.x into 3.0.x and have set 3.0.x back to default.
Backported to 8.x-2.x. Thank you!
If anyone could rebase this issue branch with the latest 2.x I would appreciate it.
I would be even more grateful if this went to 3.x also. 😎
@bradjones1 Yes, I understand that 😉 but my comment was meant as a heads-up for people who are still in the 9.x and comes across this issue. The solution was just remove that rejected hunk.
Hi, I'm trying to apply a patch based on MR183 to 9.5.x but it's failing at TestRunnerKernel.php
➜ drupal git:(9.5.x) ✗ patch -p1 < ./patches/183.patch
patching file 'core/lib/Drupal/Core/Routing/RouteProvider.php'
patching file 'core/modules/system/tests/modules/router_test_directory/router_test.module'
patching file 'core/modules/system/tests/modules/router_test_directory/router_test.routing.yml'
patching file 'core/modules/system/tests/modules/router_test_directory/src/RouterTestEarlyExceptionSubscriber.php'
patching file 'core/modules/system/tests/modules/router_test_directory/src/RouterTestServiceProvider.php'
patching file 'core/modules/system/tests/modules/router_test_directory/src/TestControllers.php'
patching file 'core/tests/Drupal/FunctionalTests/Routing/RouteCachingQueryAlteredTest.php'
patching file 'core/tests/Drupal/KernelTests/Core/Routing/RouteProviderTest.php'
patching file 'core/tests/Drupal/KernelTests/Core/Routing/RouteProviderTest.php'
patching file 'core/modules/system/tests/modules/router_test_directory/src/RouterTestEarlyExceptionSubscriber.php'
patching file 'core/lib/Drupal/Core/Routing/RouteProvider.php'
patching file 'core/lib/Drupal/Core/Routing/RouteProvider.php'
patching file 'core/modules/system/tests/modules/router_test_directory/src/RouterTestEarlyExceptionSubscriber.php'
patching file 'core/modules/system/tests/modules/router_test_directory/src/TestControllers.php'
patching file 'core/tests/Drupal/FunctionalTests/Routing/RouteCachingQueryAlteredTest.php'
patching file 'core/tests/Drupal/KernelTests/Core/Routing/RouteProviderTest.php'
patching file 'core/lib/Drupal/Core/Routing/RouteProvider.php'
patching file 'core/modules/system/tests/modules/router_test_directory/src/RouterTestEarlyExceptionSubscriber.php'
patching file 'core/tests/Drupal/FunctionalTests/Routing/RouteCachingQueryAlteredTest.php'
patching file 'core/lib/Drupal/Core/Routing/RouteProvider.php'
patching file 'core/lib/Drupal/Core/Routing/RouteProvider.php'
patching file 'core/lib/Drupal/Core/Test/TestRunnerKernel.php'
1 out of 1 hunks failed--saving rejects to 'core/lib/Drupal/Core/Test/TestRunnerKernel.php.rej'
patching file 'core/modules/system/tests/modules/router_test_directory/src/RouterTestEarlyExceptionSubscriber.php'
patching file 'core/lib/Drupal/Core/Routing/RouteProvider.php'
patching file 'core/modules/system/tests/modules/router_test_directory/src/TestControllers.php'
patching file 'core/lib/Drupal/Core/Routing/RouteProvider.php'
patching file 'core/tests/Drupal/KernelTests/Core/Routing/RouteProviderTest.php'
➜ drupal git:(9.5.x) ✗
Maybe related to the failed test on this commit?: https://git.drupalcode.org/project/drupal/-/merge_requests/183/diffs?com...
I read all you monologue here, @loze 😅 It was great to follow your thinking.
The table for block usage seems the best approach.
IIRC, Layout Builder when saving the layout of a node with revisions will create new content blocks even if the content block type has revisions disabled. Maybe we should follow the same approach? Because IMO since the content blocks are tied to nodes, there's no need to handle block revisions. But we could check how LB handles the insert/update/delete operations regarding content blocks.