Contrib.social

Duplicate CkEditor5 editor widgets are created if the metabox element doesn't exist

Open on Drupal.org →
Created on 12 June 2024, 6 months ago
Updated 26 August 2024, 4 months ago

Problem/Motivation

There's potential for Gutenberg to unintentionally detach all the editors when the metabox element doesn't exist.

The particular logic is available here:

var $metabox = $('#' + id);
var metabox = $metabox.get(0);
Drupal.behaviors.editor.detach(metabox, drupalSettings);

The metabox element might potentially be null at this point, so it'll attempt to detach all editors within the current document (including Gutenberg, but it's not as apparent because we don't currently implement the Drupal.editors.gutenberg.detach() method), rather than just the editors within the specified metabox.

This causes the CKEditor 5 widget to be attached multiple times since it doesn't currently check if it's already been previously attached before attaching a new one.

Steps to reproduce

Install the search_api_exclude_entity module, and add a "Search API Exclude Entity" field to your Gutenberg content type.

Switch to a user without the administer search api exclude entity permission, then attempt to edit a node.

Because the underlying field is hidden through the hook_entity_field_access API, the Details form element won't be rendered if it has no children, but Gutenberg still picks it up and registers it as a valid metabox.

This causes the ID lookup to fail, and causes it to attempt to detach all editorsWhen the including Gutenberg, but Gutenberg doesn't implement.

You may also trigger it by adding a non-existent metabox to the Drupal settings:

$form['#attached']['drupalSettings']['gutenberg']['metaboxes'][] = 'non-existent-metabox-id';

Proposed resolution

Add null-checks on the metabox logic.

Remaining tasks

Provide issue fork/patches.

User interface changes

N/A

API changes

N/A

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

codebymikey

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Pipeline finished with Failed
    6 months ago
    #195678
  • Issue created by @codebymikey
  • Merge request !156Issue #3454161: Duplicate CkEditor5 editor widgets are created if the metabox element doesn't exist → (Merged) created by codebymikey
  • Merge request !157Issue #3454161: Duplicate CkEditor5 editor widgets are created if the metabox element doesn't exist → (Merged) created by codebymikey
  • Pipeline finished with Success
    6 months ago
    Total: 277s
    #197293
  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    codebymikey
  • Pipeline finished with Success
    6 months ago
    Total: 253s
    #197296
  • Pipeline finished with Success
    6 months ago
    Total: 167s
    #198239
  • Pipeline finished with Success
    6 months ago
    #214130
  • Pipeline finished with Running
    5 months ago
    #229737
  • Pipeline finished with Success
    5 months ago
    #232859
  • Pipeline finished with Success
    5 months ago
    Total: 629s
    #232884
  • Pipeline finished with Failed
    5 months ago
    #233282
  • Pipeline finished with Failed
    5 months ago
    #237581
  • Pipeline finished with Success
    5 months ago
    Total: 160s
    #237613
  • Pipeline finished with Success
    5 months ago
    #237636
  • Pipeline finished with Success
    5 months ago
    Total: 520s
    #237666
  • Pipeline finished with Failed
    5 months ago
    Total: 403s
    #239557
  • Pipeline finished with Success
    5 months ago
    Total: 139s
    #241594
  • Pipeline finished with Success
    5 months ago
    Total: 140s
    #241720
  • Pipeline finished with Success
    5 months ago
    #241860
  • Pipeline finished with Success
    5 months ago
    Total: 313s
    #242939
  • Pipeline finished with Success
    5 months ago
    #242944
  • Pipeline finished with Success
    4 months ago
    Total: 488s
    #247485
  • Pipeline finished with Failed
    4 months ago
    Total: 352s
    #248080
  • Pipeline finished with Failed
    4 months ago
    Total: 321s
    #248097
  • Pipeline finished with Success
    4 months ago
    Total: 347s
    #248310
  • Pipeline finished with Failed
    4 months ago
    #248865
  • Pipeline finished with Success
    4 months ago
    #248871
  • Pipeline finished with Success
    4 months ago
    Total: 318s
    #249033
  • Pipeline finished with Success
    4 months ago
    Total: 217s
    #251400
  • Comment 4 months ago →
    System Message
  • Pipeline finished with Success
    4 months ago
    #251401
  • Comment 4 months ago →
    System Message
  • Status changed to Fixed 4 months ago
  • Comment 4 months ago →
    🇵🇹Portugal marcofernandes
  • Pipeline finished with Success
    4 months ago
    Total: 136s
    #262395
  • Comment 4 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    4 months ago
    #266203
  • Pipeline finished with Failed
    3 months ago
    Total: 4901s
    #287432
  • Pipeline finished with Success
    3 months ago
    Total: 3703s
    #287527
  • Pipeline finished with Success
    3 months ago
    Total: 217s
    #287560
  • Pipeline finished with Success
    3 months ago
    Total: 160s
    #290593
  • Pipeline finished with Success
    3 months ago
    Total: 522s
    #290607
  • Pipeline finished with Success
    3 months ago
    Total: 148s
    #300613
  • Pipeline finished with Success
    2 months ago
    Total: 153s
    #301066
  • Pipeline finished with Success
    2 months ago
    Total: 376s
    #304835
  • Pipeline finished with Failed
    2 months ago
    Total: 398s
    #304916
  • Pipeline finished with Success
    2 months ago
    Total: 289s
    #304929
  • Pipeline finished with Success
    2 months ago
    Total: 239s
    #304962
  • Pipeline finished with Success
    2 months ago
    Total: 147s
    #311947
  • Pipeline finished with Failed
    2 months ago
    Total: 340s
    #314660
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 90s
    #315002
  • Pipeline finished with Success
    about 2 months ago
    Total: 135s
    #315003
  • Pipeline finished with Failed
    about 2 months ago
    Total: 603s
    #317975
  • Pipeline finished with Failed
    about 2 months ago
    Total: 522s
    #324146
  • Pipeline finished with Success
    about 2 months ago
    Total: 557s
    #324160
  • Pipeline finished with Success
    about 2 months ago
    Total: 11308s
    #324234
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 119s
    #328929
  • Pipeline finished with Success
    about 1 month ago
    Total: 136s
    #328930
  • Pipeline finished with Success
    about 1 month ago
    Total: 143s
    #330053
  • Pipeline finished with Success
    about 1 month ago
    Total: 142s
    #330153
  • Pipeline finished with Success
    about 1 month ago
    Total: 173s
    #330160
  • Pipeline finished with Success
    about 1 month ago
    Total: 157s
    #330186
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 75s
    #330228
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 124s
    #330229
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 178s
    #330231
  • Pipeline finished with Success
    about 1 month ago
    Total: 177s
    #330233
  • Pipeline finished with Success
    about 1 month ago
    #331111
  • Pipeline finished with Success
    about 1 month ago
    #331116
  • Pipeline finished with Success
    about 1 month ago
    #331127
  • Pipeline finished with Failed
    about 1 month ago
    Total: 300s
    #333604
  • Pipeline finished with Success
    about 1 month ago
    Total: 415s
    #333608
  • Pipeline finished with Failed
    about 1 month ago
    Total: 470s
    #333834
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 321s
    #333838
  • Pipeline finished with Success
    about 1 month ago
    Total: 296s
    #333845
  • Pipeline finished with Success
    about 1 month ago
    Total: 397s
    #333847
  • Pipeline finished with Failed
    about 1 month ago
    Total: 329s
    #333910
  • Pipeline finished with Failed
    about 1 month ago
    Total: 588s
    #334158
  • Pipeline finished with Failed
    about 1 month ago
    Total: 287s
    #334458
  • Pipeline finished with Success
    about 1 month ago
    Total: 38094s
    #334501
  • Pipeline finished with Canceled
    20 days ago
    Total: 149s
    #353259
  • Pipeline finished with Success
    20 days ago
    Total: 315s
    #353261
  • Pipeline finished with Skipped
    7 days ago
    #366101
  • Pipeline finished with Skipped
    7 days ago
    #366108
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024