-
marcofernandes →
committed dd8efb2b on 3.0.x
Issue #3334499 fix: Temporary fix for missing node form action buttons
-
marcofernandes →
committed dd8efb2b on 3.0.x
-
marcofernandes →
committed 3391e2a4 on 3.0.x
Issue #3334499 fix: Add missing properties when loading synced patterns...
-
marcofernandes →
committed 3391e2a4 on 3.0.x
-
marcofernandes →
committed 98b61076 on 3.0.x
Issue #3334499: Remove Bartik and Seven related styles; Update compiled...
-
marcofernandes →
committed 98b61076 on 3.0.x
-
marcofernandes →
committed 95b35201 on 3.0.x
Issue #3334499 by marcofernandes: Fix duotone processor
-
marcofernandes →
committed 95b35201 on 3.0.x
-
marcofernandes →
committed 33bb7a2d on 3.0.x
Issue #3334499 by marcofernandes: Move vendor directory
-
marcofernandes →
committed 33bb7a2d on 3.0.x
-
marcofernandes →
committed fe9bf4d2 on 3.0.x
Issue #3334499 by marcofernandes: Fix Claro lib loading
-
marcofernandes →
committed fe9bf4d2 on 3.0.x
-
marcofernandes →
committed 1c7228d6 on 3.0.x
Issue #3334499 by marcofernandes: Fix flickering when transitioning from...
-
marcofernandes →
committed 1c7228d6 on 3.0.x
-
marcofernandes →
committed 0e24bb95 on 3.0.x
Issue #3334499 by marcofernandes: Enable view mode
-
marcofernandes →
committed 0e24bb95 on 3.0.x
-
marcofernandes →
committed 94e5099c on 3.0.x
Issue #3334499 by marcofernandes: Improve behaviour when clicking More...
-
marcofernandes →
committed 94e5099c on 3.0.x
- Status changed to Needs review
12 months ago 5:41pm 22 November 2023 - 🇵🇹Portugal marcofernandes
Enough done for a beta or RC release for initial tests.
Next step is to review all issues on 2.x that are ready to commit, review and fix critical issues (and some major) and merge into 3.0.x. -
marcofernandes →
committed 96a5a641 on 3.0.x
Issue #3334499 by marcofernandes: fetch API changed a bit for media...
-
marcofernandes →
committed 96a5a641 on 3.0.x
-
marcofernandes →
committed 8ff147fb on 3.0.x
Issue #3334499 by marcofernandes: Misc fixes
-
marcofernandes →
committed 8ff147fb on 3.0.x
-
marcofernandes →
committed fad44679 on 3.0.x
Issue #3334499 by marcofernandes: Code cleanup
-
marcofernandes →
committed fad44679 on 3.0.x
-
marcofernandes →
committed 571f797a on 3.0.x
Issue #3334499 by marcofernandes: Olivero support improvements
-
marcofernandes →
committed 571f797a on 3.0.x
-
marcofernandes →
committed f537c189 on 3.0.x
Issue #3334499 by marcofernandes: Hide format select
-
marcofernandes →
committed f537c189 on 3.0.x
- Status changed to Needs work
12 months ago 5:33pm 25 November 2023 -
marcofernandes →
committed f65a5da7 on 3.0.x
Issue #3334499 by marcofernandes: Update Gutenberg library - update...
-
marcofernandes →
committed f65a5da7 on 3.0.x
-
marcofernandes →
committed c604f0c7 on 3.0.x
Issue #3334499 by marcofernandes: Update Gutenberg library
-
marcofernandes →
committed c604f0c7 on 3.0.x
- Status changed to Needs review
12 months ago 9:18pm 26 November 2023 -
marcofernandes →
committed 7d5d89be on 3.0.x
Issue #3334499 by marcofernandes: Update Gutenberg library
-
marcofernandes →
committed 7d5d89be on 3.0.x
The https://git.drupalcode.org/project/gutenberg/-/commit/94e5099c905c2797ce... commit currently affects integrations with long grouped fields within the More Settings such as Details and Select boxes, attempting to click one of them automatically scrolls the user back to the top of the Additional Fields section, which isn't expected behaviour.
Also, is there a reason we opted to handle this in PHP via:
'onclick' => 'moreSettingsClick(this);',
rather than a dynamic
toggle
event listener targetting the more settings class?I would opt to remove the event listener to reduce code complexity unless the existing behaviour expand/collapase behaviour is unmanageable under certain themes. If so, I believe the following should achieve the same work without breaking things:
$('details.more-settings', context).on('toggle', function () { if (this.open) { this.scrollIntoView({ behavior: 'smooth', block: 'start', inline: 'nearest', }); } });
- Merge request !94Issue #3334499: Update more settings onclick/toggle listener → (Merged) created by codebymikey
I've pushed an update removing the onClick event listener from the element, we may attach the
onClick
listener referenced above in a further commit if it's still useful/necessary.- 🇵🇹Portugal marcofernandes
I think we should maintain the scroll behavior because we observe many users miss that the more settings pane is open when clicking on it. Eventually they found out about it by scrolling but I believe that by scrolling improves the user experience.
Also, is there a reason we opted to handle this in PHP
No reason at all 😁 and since it's causing that bad behavior, it should be moved to the client script has you suggested.
-
marcofernandes →
committed 47abcacd on 3.0.x authored by
codebymikey →
Issue #3334499: Update more settings onclick/toggle listener
-
marcofernandes →
committed 47abcacd on 3.0.x authored by
codebymikey →
-
marcofernandes →
committed d57f0b9f on 3.0.x
Issue #3334499: Adjust media dialog z-index.
-
marcofernandes →
committed d57f0b9f on 3.0.x
-
marcofernandes →
committed d3acbb2b on 3.0.x
Issue #3334499: Add CSS for border colors
-
marcofernandes →
committed d3acbb2b on 3.0.x
- Status changed to Fixed
5 months ago 10:20pm 22 June 2024 -
marcofernandes →
committed d3acbb2b on 4.0.x
Issue #3334499: Add CSS for border colors
-
marcofernandes →
committed d3acbb2b on 4.0.x
Automatically closed - issue fixed for 2 weeks with no activity.