Patterns and synced patterns (reusable blocks)

Automatically closed - issue fixed for 2 weeks with no activity.

There's no update hook for the new reusable block field_pattern_category and field_pattern_sync_status fields introduced here. This breaks on a site upgrading from 2.x whenever you attempt to add a new pattern:

The website encountered an unexpected error. Please try again later.<br><br><em class="placeholder">InvalidArgumentException</em>: Field field_pattern_category is unknown. in <em class="placeholder">Drupal\Core\Entity\ContentEntityBase->getTranslatedField()</em> (line <em class="placeholder">587</em> of <em class="placeholder">core/lib/Drupal/Core/Entity/ContentEntityBase.php</em>). <pre class="backtrace">Drupal\Core\Entity\ContentEntityBase->get('field_pattern_category') (Line: 323)
Drupal\gutenberg\Controller\ReusableBlocksController->getBlockAttributes(Object) (Line: 229)
Drupal\gutenberg\Controller\ReusableBlocksController->save(Object, NULL)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 692)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
</pre>

An upgrade path should be created or documented. Ideally something in an update hook.

Sorry it took a while to get back to this. I like the approach, but it seems like \Drupal::service('config.installer')->installDefaultConfig('module', 'gutenberg') will override any local configuration overrides the sites might have, so we need special handling for it.

I've pushed an update to the branch with the updated logic, feel free to test and review, and let me know if it all makes sense.

I tested from a clean Drupal instance, installed Gutenberg 2.x, enabled Gutenberg for Basic Page changed Gutenberg text format a bit just to check if configuration wouldn't be override. Then I updated Gutenberg to this branch and did an update db but it threw this error:

  Unable to decode output into JSON: Syntax error                                          

  TypeError: Drupal\Core\Field\WidgetBase::__construct(): Argument #5 ($third_party_setti  
  ngs) must be of type array, null given, called in /var/www/html/web/core/lib/Drupal/Cor  
  e/Field/WidgetBase.php on line 64 in Drupal\Core\Field\WidgetBase->__construct() (line   
  53 of /var/www/html/web/core/lib/Drupal/Core/Field/WidgetBase.php).                      

Ran update db again but at this time no error occurred and configuration seemed to be ok. At least no override on the text format settings and fields were created.

Automatically closed - issue fixed for 2 weeks with no activity.