- Issue created by @doxigo
- Merge request !153Issue #3452390: Check for className key existence in DrupalBlockProcessor → (Merged) created by doxigo
- Status changed to Needs review
8 months ago 8:21am 4 June 2024 - 🇳🇴Norway vegardjo
This is sadly a regression from 🐛 Render custom classes for dynamic blocks Fixed , also present in 2.9, Doxigos (👋) fix should do it.
- Status changed to RTBC
8 months ago 10:06am 4 June 2024 - 🇳🇴Norway vegardjo
Tested on 2.9 using this as a patch file: https://git.drupalcode.org/issue/gutenberg-3452390/-/commit/6f173ec402ea... and it solves the problem.
-
marcofernandes →
committed 526376e8 on 8.x-2.x
Issue #3452390: Undefined array key “className” in processBlock()
-
marcofernandes →
committed 526376e8 on 8.x-2.x
- Status changed to Fixed
7 months ago 11:48am 12 June 2024 - Status changed to RTBC
7 months ago 9:58am 18 June 2024 Hey Marco, this seems to be merged into
3.x
and we apparently also have a3.0.x
which is not the default branch but is the tagged branch in the releases. so I assume we need to re-apply the patch to3.0.x
and also change the default branch from3.x
to3.0.x
Opened the issue again
- Status changed to Fixed
7 months ago 7:49am 20 June 2024 - 🇵🇹Portugal marcofernandes
@doxigo Yeah, unfortunately d.o is a bit strict with branches naming/versioning. The idea of having 3.x branch was to avoid managing minor versions. I merged 3.x into 3.0.x and have set 3.0.x back to default.
- 🇳🇴Norway eiriksm Norway
Seems like something we should create a new release for? Not pretty to have these notices on a stable release I think.
Also, the fact that we have it shows we are missing test coverage. Can we create a follow up issue for adding test coverage here?
- 🇩🇪Germany szeidler Berlin
Ideally we would bundle the three issues in a new release, which all could break Gutenberg or parts of it, because of warnings or errors.
Automatically closed - issue fixed for 2 weeks with no activity.