- Issue created by @chambers
- Status changed to Needs review
over 1 year ago 6:55pm 26 July 2023 It works for new ECK types created after patching.
-----------------------
Test for types created before the patching.Drupal\Core\Entity\Query\QueryException: No revision table for eck_2_type, invalid query. in Drupal\Core\Entity\Query\Sql\Query->prepare() (line 99 of /var/www/html/local6site/web/core/lib/Drupal/Core/Entity/Query/Sql/Query.php).Testing with workflow
If your existing eck type has content moderation workflow;
Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'mydatabase.dr_' doesn't exist: SELECT "base"."id" AS "id", "base"."type" AS "type", "base"."uuid" AS "uuid", "base"."langcode" AS "langcode" FROM "dr_eck_1_type" "base" INNER JOIN "dr_" "revision" ON "revision"."id" = "base"."id" AND "revision"."" IN (:revisionIds__0); Array ( [:revisionIds__0] => ) in Drupal\Core\Entity\Sql\SqlContentEntityStorage->doLoadMultipleRevisionsFieldItems() (line 624 of /var/www/html/local6site/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).Tested with drupal 10.1.2 & PHP 8.1
- Status changed to Closed: duplicate
about 1 year ago 4:33pm 20 October 2023 - 🇨🇦Canada RobLoach Earth
There's been a lot of work on this over at https://www.drupal.org/project/eck/issues/2788507 ✨ Add revision support Needs review . Mind if we combine them?
- 🇺🇸United States chambers
This one shouldn't have been closed as duplicate for 2 reasons.
1. The other issue is for version 8.x-1.x-dev. This one is for version 2.0.0
2. The other issue patches didn't work for this version because of Drupal 10 changes and this is for version 2.0.0.So this is unrelated to the other issue.
Sorry, I never got an email there were responses.
- Status changed to Needs review
about 1 year ago 6:34pm 25 October 2023 - First commit to issue fork.
- 🇧🇪Belgium dieterholvoet Brussels
Created a MR based on the patch, will review there.
- Status changed to Needs work
11 months ago 1:57pm 26 December 2023 - 🇧🇪Belgium dieterholvoet Brussels
I left some comments in the MR. Additionally, a generic revision UI was added in Drupal 10.1 ( ✨ Implement a generic revision UI Fixed ), so we should probably rewrite some stuff to make use of that.
- 🇧🇪Belgium dieterholvoet Brussels
The changes from #2788507-116 ✨ Add revision support Needs review should still be added here as well.
- 🇺🇸United States hungdo
Attaching a patch file that works for eck 2.0.0 on my local.
- Status changed to Needs review
about 1 month ago 12:55pm 11 October 2024 Hello,
I have created a patch based on changes available on #2788507-116 ✨ Add revision support Needs review for the 2.0.0.
Also the changes from #2788507-116 ✨ Add revision support Needs review do not work for existing eck entities. so I have modified the update_hook which will make the existing entities revisionable.
Note - This patch will make all the existing eck entities revisionable.