Fixed the pipeline errors and added support for ESI comments. Have a look and let me know if it works.
slydevil → made their first commit to this issue’s fork.
dieterholvoet → credited slydevil → .
Works! Thanks @xrobp.
slydevil → created an issue.
I think this may be a duplicate of https://www.drupal.org/project/gcontent_moderation/issues/3471105 🐛 Moderated Content view does not show the correct data for roles other than the group creator Active . Give the patch there a shot to see if it fixes your issue.
Fixed the tag name on the Route Subscriber service to be route_subscriber rather than event_subscriber (which throws an exception).
Done - 3.0.2
slydevil → created an issue. See original summary → .
slydevil → created an issue.
Duplicate of #3451260
Patch for 2.0-beta attached.
slydevil → made their first commit to this issue’s fork.
Posted on that issue - thanks @cilefen.
Added to the 2.2.2 MR, so the GroupRouteContext takes into account situations where the 'group' Route parameter is an ID rather than a fully loaded Group entity. This happens when you use permissions rather than group permissions (as far as I can tell).
Patch attached as well.
slydevil → made their first commit to this issue’s fork.
slydevil → created an issue.
Applied the patch for the 2.x branch and it works well. Not moving to RTBC since I did not try the 3x branch.
Sounds like it's timing out when it is trying to gather the files to process. Have you tried the drush command?
drush scan-js
drush minify-js
drush minify-js-skip
Confirm that you're using the latest version of https://github.com/matthiasmullie/minify (it's 1.3.73 at this moment in time). If you're not using that version, use composer to update it.
If that doesn't fix it, I would say create an issue at https://github.com/matthiasmullie/minify
There is an option to disable all functionality on admin pages. Would that solve your issue?
It's going to be tough to debug this error without knowing more about the error from your server logs, the webserver type and config, etc.
Based on your description this is the path to exclude - /fullpath/mysite-d10.2.4/html/sites/mysite/.redisOff
Is the base director for Drupal /fullpath/mysite-d10.2.4/? If so the exclusion should be html/sites/mysite/* and not sites/mysite/*. Have you tried that?
slydevil → created an issue. See original summary → .
slydevil → created an issue.
slydevil → created an issue.
Tried to reproduce this with 10.2.3 and 10.2.4 and it works for both. There must be something specific to your site that is causing the issue.
Ping me on the #minifyhtml slack channel if you want to look into it more.
slydevil → created an issue.
slydevil → created an issue.
slydevil → created an issue.
slydevil → created an issue.
Updated the project page.
Yeah, I'll update the project page with some additional details.
The scanner starts at the DRUPAL_ROOT and finds all JS files from the DRUPAL_ROOT and above. Any files below that (other non-Drupal files) would not be included. I believe the scanner will follow symlinks.
Added a patch - let me know if this works for you.
Essentially, I've added a "File Sync" action to the configuration page that allows you to create managed file entries in the file_managed table for every object in the bucket. You'll need to run "Refresh Metadata" before you run "File Sync".
Once you have the files in the file_managed table, you can use in file field or media, but you'll need a file/entity browser.
slydevil → changed the visibility of the branch 3408985-move-existing-google to hidden.
Amazing, so the underlying issue was with Drupal core!
I didn't build anything into the module, but I can look into as a new feature.
@sense-design, I created a minifyhtml channel on the Drupal slack, you can find me there are we can work through this.
@zcht, that looks related to minifyjs and not this module. Please open an issue on that module for that issue.
@sense-design I will try your config and see what happens.
@sd123 not saying that your issue is unrelated, but going to focus on the QUIC error first.
@danthorne are you using http3?
I spun up a test site - https://master-7tjf71h6euc42njvewo8pyv5jvdx0712.tugboatqa.com/ - and I don't see any issues. The latest minifyhtml version (2.0.3) is installed on this test site.
The username/password is 'admin'.
Please visit the test site and let me know if you are still having the issue.
There must be something specific about your site that is incompatible with the module. After searching (I had never heard of this protocol before) this is the top result: https://kinsta.com/knowledgebase/err_quic_protocol_error/. I'm not suggesting that disabling the protocol is the answer as it's default browser functionality, but it could be related to an incompatible browser extension or proxy settings.
If you can provide a copy of the unminified HTML, I can use the module to minify it and see what happens.
I re-installed the module and everything is working now.
I'm also seeing this error when I click on Manage Instances. I have the Smart Date formatter set. Same error, different place in the code:
Error: Call to a member function getOptions() on null in Drupal\smart_date_recur\Controller\Instances->buildRow() (line 235 of /var/www/web/modules/contrib/smart_date/modules/smart_date_recur/src/Controller/Instances.php).
There were no smart date formats. I created one and assigned it in the display settings and everything is working now. Is the module supposed to create a default smart date format?
Really, there should be a message displayed to the user that the smart date format is not set rather than an exception being thrown.
Anyway, thanks for your help.