Provide a human-readable error message when minify callback has an error

Open on Drupal.org →

Created on 13 February 2024, 10 months ago

Updated 6 March 2024, 10 months ago

Problem/Motivation

Minifyhtml uses several regular expressions to minify the generated html. When one of these regular expressions generates an error, an error is logged to the watchdog. However, it only contains an error code and no error message.

Steps to reproduce

Generate an error using the existing regular expressions. Notice the following error message in the watchdog:
Preg error. The error code is 2. You can view what this error code is by viewing http://php.net/manual/en/function.preg-last-error.php

Proposed resolution

Provide a human-readable error message when minify callback has an error

Remaining tasks

Write a patch
Review
Commit

User interface changes

None.

API changes

None.

Data model changes

None.

📌 Task

Status

Fixed

Version

2.0

Component

Code

Created by

🇳🇱Netherlands idebr

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!11Provide a human-readable error message when minify callback has an error
Merged
🇨🇦Canada slydevil
updated 10 months ago

Comments & Activities

Issue created by @idebr
Status changed to Needs review 10 months ago3:04pm 13 February 2024
Comment 10 months ago →
🇳🇱Netherlands idebr
The merge requests implements the following error message:
Backtrack limit exhausted in regular expression "/\s*<textarea(\b[^>]*?>[\s\S]*?<\/textarea>)\s*/i" (code: 2).
Comment 10 months ago →
🇪🇸Spain tunic Madrid
Nice addition, works patch applies with no issues. The module still works. Not moving to RBTC because I was not able to find a way to trigger an error message. I tried editing a node and adding HTML garbage but no error was triggered.

How can I trigger the error?
Merge request !11Issue #3421156: Provide a human-readable error message when minify callback has an error → (Merged) created by slydevil
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
7 pass

Comment 10 months ago →

264ac247 committed on 2.x

Issue #3421156: Provide a human-readable error message when minify...

Status changed to Fixed 10 months ago9:47pm 6 March 2024
Comment 10 months ago →
🇨🇦Canada slydevil Halifax
Status changed to Fixed 10 months ago9:51pm 6 March 2024
Comment 10 months ago →
🇨🇦Canada slydevil Halifax

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024