Created on 16 January 2024, 5 months ago
Updated 6 May 2024, about 2 months ago

MinifyJS breaks ckeditor5. I managed to fix this by excluding all of the following files (this might be too much though):

core/assets/vendor/ckeditor5/*/*
modules/contrib/insert/js/*
modules/contrib/insert/js/editors/*
modules/contrib/token/js/*
themes/contrib/gin/dist/js/*
core/scripts/js/assets/ckeditor5Files.js
core/scripts/js/ckeditor5-check-plugins.js
core/scripts/js/ckeditor5-types-documentation.js
core/misc/*
core/modules/ckeditor5/*
core/modules/ckeditor5/js/*
core/modules/ckeditor5/js/*/*
πŸ› Bug report
Status

Postponed: needs info

Version

3.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @sd123
  • πŸ‡¨πŸ‡¦Canada slydevil Halifax

    There is an option to disable all functionality on admin pages. Would that solve your issue?

  • No, as soon as it starts to minify the ckeditor stuff, it breaks. Disabling on admin pages does not help.

  • πŸ‡¨πŸ‡¦Canada adamcadot St. Catharines, Ontario

    Excluding the files listed did not fix the issue for me.

  • At this moment I have all the following excluded and that works for me:

    core/assets/vendor/ckeditor/ckeditor.js
    core/assets/vendor/ckeditor/lang/*
    core/assets/vendor/ckeditor5/*/*
    modules/contrib/insert/js/*
    modules/contrib/insert/js/editors/*
    modules/contrib/token/js/*
    themes/contrib/gin/dist/js/*
    core/scripts/js/assets/ckeditor5Files.js
    core/scripts/js/ckeditor5-check-plugins.js
    core/scripts/js/ckeditor5-types-documentation.js
    core/misc/*
    core/modules/ckeditor5/*
    core/modules/ckeditor5/js/*
    core/modules/ckeditor5/js/*/*
    core/modules/ckeditor/tests/*
    core/modules/color/tests/*
    core/modules/locale/tests/*
    core/modules/quickedit/js/views/EntityToolbarView.js
    core/modules/system/tests/*
    core/modules/views/tests/*
    core/tests/*
    libraries/d3/test/*
    libraries/jquery.inputmask/qunit/tests*
    libraries/jquery.intl-tel-input/src/spec/tests/*
    libraries/jquery.select2/tests/*
    sites/default/files/*
    vendor/jcalderonzumba/gastonjs/examples/*
    vendor/jcalderonzumba/gastonjs/tests/*
    *-min.js
    *.min.js
  • πŸ‡¨πŸ‡¦Canada adamcadot St. Catharines, Ontario

    Here's a screenshot of the console errors I receive on a CKEditor node edit form.

    β†’

  • πŸ‡¨πŸ‡¦Canada slydevil Halifax

    Confirm that you're using the latest version of https://github.com/matthiasmullie/minify (it's 1.3.73 at this moment in time). If you're not using that version, use composer to update it.

    If that doesn't fix it, I would say create an issue at https://github.com/matthiasmullie/minify

  • Status changed to Postponed: needs info about 2 months ago
  • πŸ‡¨πŸ‡¦Canada slydevil Halifax
  • I just removed all excluded files and I can confirm it seems to be working now. It might have been a bug in minify.

Production build 0.69.0 2024