Add revision support

Created on 23 August 2016, over 8 years ago
Updated 7 March 2023, almost 2 years ago

Problem/Motivation

For a lot of usecases you use ECK in a way which is similar to paragraphs module. Once you have also any kind of workflow on those sites, you need revision support for the referenced entities, using entity_reference_revisions.

Given that it would be quite helpful to have revision support as part of ECK

Proposed resolution

  1. Make it possible to switch of revision support when creating an entity type
  2. Default to TRUE
  3. Backport the changes in #2721313: Upgrade path between revisionable / non-revisionable entities in some temporary subclasses inside ECK
  4. Provide an update path for all entity types
  5. Write tests for it

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Needs review

Version

1.0

Component

Code

Created by

🇩🇪Germany dawehner

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India sumit_saini

    As Implement a generic revision UI Fixed is merged in D10.1 and patch for D9.5 is available, I have updated patch in #109 to use core's generic revision UI by following this change record .

    Below modifications are done in this patch(Refer interdiff) :
    1. The patch no longer needs entity module and so the related update hook to install entity module is removed.
    2. Modified Drupal\eck\EckEntityAccessControlHandler::checkAccess() for revision permission handling [need to improve permission checking logic].
    3. Removed 'Revisions' local task added by earlier patch which is now added by core.
    4. Revision routes related implementation removed from Drupal\eck\Entity\EckEntityRouteProvider which is now supplied by Drupal\Core\Entity\Routing\RevisionHtmlRouteProvider (promoted revision routes as _admin_route in Drupal\eck\EventSubscriber\EckEntityAdminRouteSubscriber )
    5. Added 'revision-delete-form' link to eck entity definition.

    Note: This patch is generated against eck v8.x-1.0-beta2 and tested with D9.5.3

  • 🇺🇸United States chambers

    I created a patch from 109 for eck 2.0 and created an issue at https://www.drupal.org/project/eck/issues/3376678 Add revision support Closed: duplicate . After I am finished upgrading to Drupal 10, I will look at taking the 116 D10 patch to make it work for eck 2.0.

  • 🇨🇦Canada RobLoach Earth

    @chambers had a changeset for revision support over at https://www.drupal.org/project/eck/issues/3376678#comment-15167141 Add revision support Closed: duplicate too. Closed the other one as dup.

  • 🇺🇸United States chambers

    Adding a note here responded to the above comment. The other issue was for version 2.0.0 and should not have been closed since this is for version 8.x-1.x-dev. The patches here do not work with version 2.0.0.

  • Status changed to Closed: won't fix 3 days ago
  • 🇧🇪Belgium dieterholvoet Brussels

    Closing this one since 8.x-1.* versions aren't supported anymore. Continuing the work in Add revision support Closed: duplicate . I credited the people who worked on this issue there.

Production build 0.71.5 2024