- 🇮🇳India sumit_saini
As ✨ Implement a generic revision UI Fixed is merged in D10.1 and patch for D9.5 is available, I have updated patch in #109 to use core's generic revision UI by following this change record → .
Below modifications are done in this patch(Refer interdiff) :
1. The patch no longer needs entity module → and so the related update hook to install entity module is removed.
2. Modified Drupal\eck\EckEntityAccessControlHandler::checkAccess() for revision permission handling [need to improve permission checking logic].
3. Removed 'Revisions' local task added by earlier patch which is now added by core.
4. Revision routes related implementation removed from Drupal\eck\Entity\EckEntityRouteProvider which is now supplied by Drupal\Core\Entity\Routing\RevisionHtmlRouteProvider (promoted revision routes as _admin_route in Drupal\eck\EventSubscriber\EckEntityAdminRouteSubscriber )
5. Added 'revision-delete-form' link to eck entity definition.Note: This patch is generated against eck v8.x-1.0-beta2 and tested with D9.5.3
- 🇺🇸United States chambers
I created a patch from 109 for eck 2.0 and created an issue at https://www.drupal.org/project/eck/issues/3376678 ✨ Add revision support Closed: duplicate . After I am finished upgrading to Drupal 10, I will look at taking the 116 D10 patch to make it work for eck 2.0.
- 🇨🇦Canada RobLoach Earth
@chambers had a changeset for revision support over at https://www.drupal.org/project/eck/issues/3376678#comment-15167141 ✨ Add revision support Closed: duplicate too. Closed the other one as dup.
- 🇺🇸United States chambers
Adding a note here responded to the above comment. The other issue was for version 2.0.0 and should not have been closed since this is for version 8.x-1.x-dev. The patches here do not work with version 2.0.0.