sorabh.v6 → created an issue.
sorabh.v6 → made their first commit to this issue’s fork.
@Dmitriy.trt Since D10 is already released, I think we can close this issue now.
@Wim Leers I am not sure now how to properly provide the steps that would help to reproduce the issue. Can you tell me what more details is needed and how I can provide those details. I mean, how do I check this -
It's possible that the server side did create/start a session and infrastructure between client and origin prevented that session cookie from reaching the client.
Or is it drupal commerce related issue?
Hi Wim Leers,
We are experiencing the same problem on a Drupal 10 site. This site is using the commerce module.
Visit this demo site.
https://commerce.demo.centarro.io/products
Check your developer console, no session is created yet. Then you add a product to the cart and a session is created. Then you go to the catalog page or any other page then check the response in network tab then you will see that there is no X-Drupal-Cache and X-Platform-Cache is a miss too.
Then if you delete the session cookie and reload the page then you will see that the X-Drupal-Cache and X-Platform-Cache is HIT.
This is a major performance issue, because of this if an anonymous user is casually browsing through the site after adding product to cart then every request will reach the drupal server and won't be served from adding overhead to server.
I was initially thinking it to be a commerce issue but then I saw this ticket and thought maybe its a Core issue.
I hope my steps instruction willl make it easy to reprocude the issue.
Thanks
Uploading patch with the code that filters out the current cart from carts variable. Please review.
Thanks
This still needs work.
The file path in the patch was not right. I have corrected it.
We need to discuss about the solution because this patch takes care of single cart. It takes the carts and then filter and reset the carts array to get the single cart. And then work on it.
I am proposing a way to get the cart only from the cart id.
Will be uploading the patch with updated code.
Thanks
Hi,
Patch in #7 was not applying in composer for me. Attaching the rerolled patch.
Thanks
Rerolled patch for D10.
Hi, is there any progress or update on this task?
Looking forward to use this module on a D10 site.
I think unsubscribing is not enough and we it delete/archive old entry as well.