Autoloading hooks in address.views.inc is deprecated

Working on it.

Thanks for working on this. I will try to see if I can use this MR issue branch in Scheduler's pipeline, so test the changes. It might be tricky to do. So I may apply a patch from here within the job.

Thanks and please post your reviews here. Help us close this issue. :)

I found a simple way to test this MR within the Scheduler pipeline, getting the file directly from here. I add the following custom before_script

phpunit:
  before_script:
    # Test address module MR69 from https://www.drupal.org/project/address/issues/3512975
    - cd $CI_PROJECT_DIR/$_WEB_ROOT/modules/contrib/address
    - curl https://git.drupalcode.org/project/address/-/merge_requests/69.diff | patch -p1 --verbose
    - ls -l address.*
    - head -15 < address.module

This is the bit where the file is patched

The test at Drupal 11.1 (current) passed, and the test at 11.2 (next minor) now has no deprecation warnings for Address. It does have plenty of warnings for other modules, so I have raised Scheduler issue 📌 Autoloading hooks in the file tokens.inc is deprecated D11.2 Active to track all of them.

So from my point of view (only considering Scheduler testing) you have fixed the problem. Thank you for woking on this. Depending on when you merge, I may continue to use that patch, or try to get Address 2.x-dev when you commit it.

Thanks for your reply. Maintainers of the module will be able to merge it.

Thanks. This looks RTBC to me, but it is not good form to RTBC one's own MR, so if someone else could do that it would be great.

We don't tend to "chase HEAD" like this. This is a brand new deprecation in 11.2 (not yet released) to prepare for D12 porting. It's going to be quite a while before we care about this deprecation. 😅

OK, I understand that. It was a simple change, that's why I opened the issue.

The reason was that Scheduler tests at 'next minor' have so many deprecations from Address (and other modules) that the log length exceeds the Gitlab limit, and is terminated short of the end. I guess I need to find a way to silence these deprecations, otherwise the log obscures any real test failures and other deprecations.