Contrib.social

Coding standard

Open on Drupal.org →
Created on 15 August 2019, almost 5 years ago
Updated 22 March 2023, over 1 year ago

Problem/Motivation

There's a long list of errors and warnings when running the phpcs check on the module (208 errors and 92 warnings). You can see the file attached bellow (I didn't copied the text here since it's too long).

Steps to reproduce

Open the Libraries API module directory on your terminal and run the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml . > phpcs_errors_libraries_api.txt

Proposed resolution

Fix either automatically or manually all errors and create patches accordingly.

Remaining tasks

As the list of errors is too long I'll divide in sub-tasks, one for each folder on the root. It will make creating patches and reviewing code easier.

  • config/
  • src/
  • tests/
  • root files
🐛 Bug report
Status

Needs review

Version

3.0

Component

Code

Created by

🇮🇳India Shivalik Noida

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇨🇦Canada joseph.olstad

    This is nice and good, however the only issue with phpcs changes is, they'll most likely break every single other patch that is waiting in the issue queue.

    So if we commit this, a big effort for the rest of the pending patches, and if we do a release, anyone using patches will have to re-roll their patches.

    usually phpcs has no bearing on functionality so at the mature stage of this project it's a bit of a disruption that should be planned.

    I haven't looked recently to see what kind of patches are waiting and how many would be affected.

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    Actually, one of the child issue still needs work and another needs to be reviewed.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024