- 🇨🇦Canada joseph.olstad
This is nice and good, however the only issue with phpcs changes is, they'll most likely break every single other patch that is waiting in the issue queue.
So if we commit this, a big effort for the rest of the pending patches, and if we do a release, anyone using patches will have to re-roll their patches.
usually phpcs has no bearing on functionality so at the mature stage of this project it's a bit of a disruption that should be planned.
I haven't looked recently to see what kind of patches are waiting and how many would be affected.
- Status changed to Needs review
over 1 year ago 4:18pm 22 March 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Actually, one of the child issue still needs work and another needs to be reviewed.
- Status changed to Needs work
4 months ago 6:55am 5 August 2024 - 🇮🇳India riddhi.addweb
I tried to apply the #13 patch, and it applied cleanly, but seems like it still does not resolve the error.
FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/src/Kernel/ExternalLibrary/GlobalLocatorTest.php ----------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/src/Kernel/ExternalLibrary/Asset/AssetLibraryTest.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES ---------------------------------------------------------------------------------------------------------------------------- 60 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 66 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 72 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 96 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 103 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 109 | WARNING | [x] A comma should follow the last multiline array item. Found: ] ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/src/Kernel/ExternalLibrary/Asset/MultipleAssetLibraryTest.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 8 ERRORS AND 4 WARNINGS AFFECTING 12 LINES ------------------------------------------------------------------------------------------------------------------------------------ 66 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 72 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 78 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 91 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 97 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 103 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 128 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 135 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 141 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 154 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 161 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 167 | WARNING | [x] A comma should follow the last multiline array item. Found: ] ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/src/Kernel/LibraryTypeKernelTestBase.php --------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------- 46 | ERROR | Description for the @return value is missing 140 | ERROR | Description for the @return value is missing --------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/src/Kernel/LibrariesApi/LibrariesUnitTest.php -------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------- 22 | ERROR | [x] Visibility must be declared on method "testLibrariesGetPath" 34 | ERROR | [x] Visibility must be declared on method "testLibrariesPrepareFiles" -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/src/Unit/Plugin/libraries/VersionDetector/LinePatternDetectorTest.php ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 15 ERRORS AND 2 WARNINGS AFFECTING 13 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Exception\UnknownLibraryVersionException. 21 | ERROR | [ ] Missing member variable doc comment 65 | ERROR | [ ] Missing short description in doc comment 66 | ERROR | [ ] Description for the @return value is missing 73 | WARNING | [x] A comma should follow the last multiline array item. Found: '/@version (\d+\.\d+\.\d+)/' 125 | ERROR | [ ] Missing short description in doc comment 126 | ERROR | [ ] Description for the @return value is missing 133 | WARNING | [x] A comma should follow the last multiline array item. Found: '/@version (\d+\.\d+\.\d+)/' 142 | ERROR | [x] Array indentation error, expected 6 spaces but found 4 142 | ERROR | [x] Expected 0 spaces before comma; 4 found 142 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 150 | ERROR | [ ] Description for the @return value is missing 182 | ERROR | [ ] Missing short description in doc comment 183 | ERROR | [ ] Missing parameter comment 183 | ERROR | [ ] Missing parameter type 184 | ERROR | [ ] Missing parameter comment 184 | ERROR | [ ] Missing parameter type ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/src/Functional/ExternalLibrary/Definition/DefinitionDiscoveryFactoryTest.php --------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------------- 71 | WARNING | [x] A comma should follow the last multiline array item. Found: '1.0.0' --------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/src/Functional/LibrariesWebTest.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 6 WARNINGS AFFECTING 13 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 68 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 125 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 199 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 208 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 217 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 262 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 279 | ERROR | [ ] Public method name "LibrariesWebTest::_testLibrariesLoad" is not in lowerCamel format 410 | ERROR | [ ] Public method name "LibrariesWebTest::_testLibrariesOutput" is not in lowerCamel format 461 | ERROR | [ ] Missing parameter type 468 | ERROR | [ ] Missing parameter type 471 | ERROR | [ ] Missing parameter type 514 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 516 | ERROR | [x] list(...) is forbidden, use [...] instead. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/modules/libraries_test/libraries_test.css ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Additional whitespace found at start of file ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/modules/libraries_test/src/Controller/ExampleController.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 5 WARNINGS AFFECTING 12 LINES ---------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Missing class doc comment 21 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 26 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 27 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 31 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 44 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 70 | ERROR | [x] Missing function doc comment 74 | ERROR | [x] Missing function doc comment 78 | ERROR | [x] Missing function doc comment 82 | ERROR | [x] Missing function doc comment 86 | ERROR | [x] Missing function doc comment 90 | ERROR | [x] Missing function doc comment ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/modules/libraries_test/libraries_test.routing.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------ 6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 12 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 18 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 24 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 30 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 36 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction ------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/modules/libraries_test/libraries_test.module ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 11 ERRORS AND 2 WARNINGS AFFECTING 13 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 9 | WARNING | [x] Unused use statement 52 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 62 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 292 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements | | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates." 320 | ERROR | [ ] Missing parameter type 322 | ERROR | [ ] Missing parameter type 325 | ERROR | [ ] Missing parameter name 328 | ERROR | [ ] Missing parameter name 331 | ERROR | [ ] Missing parameter name 336 | ERROR | [ ] Return type missing for @return tag in function comment 435 | ERROR | [ ] Missing parameter type 438 | ERROR | [ ] Missing parameter type 441 | ERROR | [ ] Missing parameter type ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/example/example_4.css -------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------- 1 | ERROR | [x] Additional whitespace found at start of file -------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/example/example_1.css -------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------- 1 | ERROR | [x] Additional whitespace found at start of file -------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/example/example_3.css -------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------- 1 | ERROR | [x] Additional whitespace found at start of file -------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/example/example_2.css -------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------- 1 | ERROR | [x] Additional whitespace found at start of file -------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/assets/vendor/test_asset_library/example.css ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/assets/vendor/test_asset_multiple_library/example.first.css ---------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/tests/assets/vendor/test_asset_multiple_library/example.second.css ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Exception/LibraryDefinitionNotFoundException.php -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Utility\LibraryIdAccessorInterface. 31 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter -------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Exception/LibraryNotInstalledException.php ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Utility\LibraryAccessorInterface. 32 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter ------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Exception/LibraryTypeNotFoundException.php -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Utility\LibraryIdAccessorInterface. 31 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter -------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Exception/UnknownLibraryVersionException.php ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Utility\LibraryAccessorInterface. 32 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter ------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Exception/InvalidLibraryDependencyException.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\LibraryInterface. 39 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Remote/RemoteLibraryTrait.php ------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------ 38 | ERROR | [x] Return comment indentation must be 3 spaces, found 1 spaces ------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Local/LocalLibraryTrait.php ---------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] There must be one blank line after the namespace declaration 12 | ERROR | [x] Doc comment long description must end with a full stop ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Local/LocalLibraryInterface.php -------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------- 74 | ERROR | Missing parameter comment 76 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/LibraryManager.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 12 ERRORS AND 1 WARNING AFFECTING 11 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\Definition\DefinitionDiscoveryInterface. 44 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter 65 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 87 | ERROR | [ ] Missing short description in doc comment 88 | ERROR | [ ] Missing parameter comment 88 | ERROR | [ ] Missing parameter type 89 | ERROR | [ ] Missing parameter comment 89 | ERROR | [ ] Missing parameter type 90 | ERROR | [ ] Description for the @return value is missing 108 | ERROR | [ ] Missing short description in doc comment 109 | ERROR | [ ] Missing parameter comment 110 | ERROR | [ ] Missing parameter comment 112 | ERROR | [ ] Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Dependency/DependentLibraryTrait.php ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 14 | ERROR | Missing @var tag in member variable comment ------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/LibraryBase.php ------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------- 19 | ERROR | [x] Opening brace should be on the same line as the declaration 25 | ERROR | [x] Space found before semicolon; expected "VersionedLibraryTrait;" but found "VersionedLibraryTrait\n ;" ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Type/LibraryTypeBase.php ------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 20 | ERROR | [x] Opening brace should be on the same line as the declaration ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Version/VersionedLibraryInterface.php -------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------- 57 | ERROR | Missing parameter comment 59 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Version/VersionedLibraryTrait.php ---------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------- 75 | ERROR | Missing parameter comment 77 | ERROR | Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Asset/MultipleAssetLibraryInterface.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 53 | ERROR | Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Asset/AssetLibraryInterface.php -------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------- 46 | ERROR | [x] Opening brace should be on the same line as the declaration 54 | ERROR | [ ] Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Asset/MultipleAssetLibrary.php -------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES -------------------------------------------------------------------------------------------------------------------------- 26 | ERROR | [x] Opening brace should be on the same line as the declaration 32 | ERROR | [x] Space found before semicolon; expected "LocalRemoteAssetTrait;" but found "LocalRemoteAssetTrait\n ;" 36 | ERROR | [ ] Missing @var tag in member variable comment 79 | ERROR | [ ] Description for the @return value is missing 109 | ERROR | [ ] Missing parameter comment 111 | ERROR | [ ] Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Asset/AttachableAssetLibraryRegistrationInterface.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 18 | ERROR | Missing parameter comment ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Asset/LocalRemoteAssetTrait.php -------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------- 47 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead 63 | ERROR | Missing parameter comment 91 | ERROR | Missing parameter comment -------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Asset/AssetLibrary.php -------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES -------------------------------------------------------------------------------------------------------------------------- 22 | ERROR | [x] Opening brace should be on the same line as the declaration 28 | ERROR | [x] Space found before semicolon; expected "LocalRemoteAssetTrait;" but found "LocalRemoteAssetTrait\n ;" 48 | ERROR | [ ] Missing @var tag in member variable comment 88 | ERROR | [ ] Description for the @return value is missing 114 | ERROR | [ ] Missing parameter comment 116 | ERROR | [ ] Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Definition/FileDefinitionDiscoveryBase.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------- 58 | ERROR | Missing parameter type 71 | ERROR | Missing parameter type ------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Definition/FileDefinitionDiscovery.php --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 6 | WARNING | [x] Unused use statement --------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/ExternalLibrary/Definition/DefinitionDiscoveryFactory.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 58 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/Plugin/libraries/Locator/UriLocator.php ------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------ 76 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 80 | ERROR | [x] list(...) is forbidden, use [...] instead. 80 | WARNING | [ ] Unused variable $scheme. ------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/Plugin/libraries/Locator/GlobalLocator.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/Plugin/libraries/VersionDetector/LinePatternDetector.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------------------------------- 35 | ERROR | Missing parameter comment 36 | ERROR | Missing parameter comment 37 | ERROR | Missing parameter comment 38 | ERROR | Missing parameter comment ----------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/Plugin/libraries/VersionDetector/StaticDetector.php ------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------ 25 | ERROR | Missing parameter comment 26 | ERROR | Missing parameter comment 27 | ERROR | Missing parameter comment ------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/Plugin/libraries/Type/PhpFileLibraryType.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\libraries\ExternalLibrary\PhpFile\PhpFileLibrary. 13 | ERROR | [ ] Missing short description in doc comment -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/Plugin/libraries/Type/MultipleAssetLibraryType.php ----------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES ----------------------------------------------------------------------------------------------------------------------- 12 | ERROR | [ ] Missing short description in doc comment 28 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 38 | ERROR | [ ] Missing short description in doc comment 39 | ERROR | [ ] Missing parameter comment 40 | ERROR | [ ] Missing parameter comment 42 | ERROR | [ ] Description for the @return value is missing ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/Plugin/libraries/Type/AssetLibraryType.php --------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------- 11 | ERROR | [ ] Missing short description in doc comment 27 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements --------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/Plugin/MissingPluginConfigurationException.php ------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------- 24 | ERROR | [ ] Missing parameter type 28 | ERROR | [ ] Missing parameter type 44 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/StreamWrapper/PrivateStreamTrait.php --------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------- 20 | ERROR | [ ] Function return type is not void, but function has no return statement 25 | ERROR | [x] Visibility must be declared on method "getExternalUrl" --------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/StreamWrapper/PhpFileLibrariesStream.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 22 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 29 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/StreamWrapper/LocalHiddenStreamTrait.php ------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 15 | ERROR | Description for the @return value is missing ------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/StreamWrapper/LibraryDefinitionsStream.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. 67 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 74 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 86 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 86 | ERROR | [ ] Missing parameter type --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/src/StreamWrapper/AssetLibrariesStream.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 22 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 29 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/config/schema/libraries.schema.yml --------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------- 53 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/config/install/libraries.settings.yml ------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------ 10 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/libraries.module ---------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------- 13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Extension\Dependency. 274 | ERROR | [ ] Long array syntax must not be used in doc comment code annotations 278 | ERROR | [ ] Long array syntax must not be used in doc comment code annotations 279 | ERROR | [ ] Long array syntax must not be used in doc comment code annotations 280 | ERROR | [ ] Long array syntax must not be used in doc comment code annotations ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/libraries.drush.inc ------------------------------------------------------------------------------------ FOUND 8 ERRORS AND 29 WARNINGS AFFECTING 36 LINES ------------------------------------------------------------------------------------ 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 22 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 2 121 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 122 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 126 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 127 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 128 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 130 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 131 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 135 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 136 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 137 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 141 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 142 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 144 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 145 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 148 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 149 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 152 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 153 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 157 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 158 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 161 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 163 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 165 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 169 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 171 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 172 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 174 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed 175 | WARNING | [ ] Code after the RETURN statement on line 118 cannot be executed ------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/README.txt --------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES --------------------------------------------------------------------------- 17 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 39 | ERROR | [x] Expected 1 newline at end of file; 2 found --------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/contrib/libraries/libraries.api.php ---------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------- 233 | ERROR | Long array syntax must not be used in doc comment code annotations ----------------------------------------------------------------------------------