Contrib.social

Add PayPal support to Payment Element Gateway

Open on Drupal.org →
Created on 14 February 2024, 9 months ago

Problem/Motivation

The PaymentElementGateway has been refactored to support additional payment method types in 📌 Refactor Stripe payment element for additional payment method types Fixed . At the same time, this change forces us to implement specific plugins for every supported payment method. For example, previously working PayPal payments now are no longer possible, as the gateway throws an exception on non-existing payment method plugins (see https://git.drupalcode.org/project/commerce_stripe/-/commit/bf118321d3fb...).

We'll need ✨ Add the option to not setup payment methods for future usage Fixed in order to actually being able to select PayPal, but we can nevertheless implement the plugin independently from that.

Proposed resolution

Implement the plugin.

Remaining tasks

Before we start:

  • Do we need any extra fields?
  • Any special treatment necessary?
  • Link to relevant parts of the Stripe API doc
📌 Task
Status

Active

Version

1.0

Component

Payment Element

Created by

🇦🇹Austria agoradesign

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @agoradesign
  • Comment 9 months ago →
    🇦🇹Austria agoradesign
  • Comment 9 months ago →
    🇦🇹Austria agoradesign
  • Comment 9 months ago →
    🇦🇹Austria agoradesign
  • First commit to issue fork.
  • Comment 6 months ago →
    🇬🇪Georgia maximkashuba Batumi

    Added base PayPal support for Stripe Payment Element with on-session Payment method usage.
    Not tested with real payment, but only with test mode for Stripe.

  • Merge request !125Issue #3421392: Add PayPal support to Payment Element Gateway → (Open) created by sergiur
  • First commit to issue fork.
  • Pipeline finished with Success
    3 months ago
    Total: 717s
    #253811
  • Pipeline finished with Failed
    3 months ago
    Total: 278s
    #253831
  • Pipeline finished with Success
    3 months ago
    Total: 652s
    #253842
  • Status changed to Needs review 3 months ago
  • Comment 3 months ago →
    🇬🇧United Kingdom sergiur London, UK

    Merged in the latest changes from dev and fixed conflicts, switched to extend StripePaymentMethodTypeBase instead of PaymentMethodTypeBase and opened a merge request so we can patch via composer. Please review!

  • Status changed to Needs work 3 months ago
  • Comment 3 months ago →
    🇺🇸United States TomTech

    Thanks for the MR!

    There are a couple of items that need some work. I've left comments on the MR.

  • Assigned to sergiur
  • Comment 3 months ago →
    🇬🇧United Kingdom sergiur London, UK

    Thank you for the review! I'll be honest I mostly rerolled what was there, I should've checked the code in more detail to see what it's actually doing, my bad. Will have a look now.

  • Pipeline finished with Success
    3 months ago
    Total: 589s
    #254954
  • Issue was unassigned.
  • Status changed to Needs review 3 months ago
  • Comment 3 months ago →
    🇬🇧United Kingdom sergiur London, UK

    Implemented the changes, please let me know if I missed anything!

  • Pipeline finished with Success
    3 months ago
    Total: 900s
    #254998
  • Pipeline finished with Success
    3 months ago
    Total: 736s
    #255031
  • Comment 16 days ago →
    🇮🇳India sorabh.v6 Indore

    sorabh.v6 → made their first commit to this issue’s fork.

  • Pipeline finished with Success
    16 days ago
    Total: 253s
    #330901
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024