🇬🇪Georgia @maximkashuba

hi anisha,
could you tell me more the details about the bug, how to reproduce it.
Is it after update to 2.0.0-beta5 ?
what is the current version of the module you use?

Yes, it's ok. Thank you @mably.

malby,
i don't want to make constructor final,
plz just use static instead of self.

hi @mably,
yep better to use static. Could you reopen the issue and add the patch ?

The Drupal 11 compatibility fixes have been applied in the new 2.0.0-beta4 release.

Thank you mably for the patch! Great job!

maximkashuba → made their first commit to this issue’s fork.

tests failed

yes, you are right. The form is extended changed the create method. Works as expected.
Thank you.

For 2.40 version some services are missing during building AddToCartForm. So i added a constructor to get them.

maximkashuba → made their first commit to this issue’s fork.

maximkashuba → created an issue.

maximkashuba → created an issue.

Added base PayPal support for Stripe Payment Element with on-session Payment method usage.
Not tested with real payment, but only with test mode for Stripe.

maximkashuba → made their first commit to this issue’s fork.

maximkashuba → created an issue.

maximkashuba → created an issue.

rebased 2858890-views-ajax-fix-init-in-nested-views-patch-79 branch from 10.1.x to make the changes applicable.

maximkashuba → made their first commit to this issue’s fork.

robbm,

Can't reproduce the bug with Menu Entity Index module (sorting with the module views relations to menu items).

The results for the entity entityreference filter in a view are the same as for origin/source entity reference view and sorted in the same order.

maximkashuba → made their first commit to this issue’s fork.

Duplicate of https://www.drupal.org/project/ctools/issues/3332913 🐛 Fix PHP 8.2 deprecation notices and D10.1 compatibility Fixed issue.

maximkashuba → created an issue.

Labels for inputs are always present, but can be visually hidden (accessible to screen readers) if the field has multiple cardinality.

There are 2 scenarios: single and multiple cardinality field. For multiple fields the labels are visually hidden by the WidgetBase class, but for fields with a single element, the label is displayed as required by the task.

The Datetime field is flexible and can have 2 variants: date (1 input) or date and time (2 inputs), additionally it has own custom form render element that results in a slightly different rendering order, adds #title_display => 'invisible' property and misses logic of WidgetBase class hiding labels for multiple fields.

So there are states:

1. Single date field/show label
2. Multiple date fields/hide labels
3. Single date and time field/hide label
4. Multiple date and time field/hide labels

An additional example of a multiple simple text field is attached.

Labels for inputs are always present, but can be visually hidden (accessible to screen readers) if the field has multiple cardinality.

There are 2 scenarios: single and multiple cardinality field. For multiple fields the labels are visually hidden by the WidgetBase class, but for fields with a single element, the label is displayed as required by the task.

The Datetime field is flexible and can have 2 variants: date (1 input) or date and time (2 inputs), additionally it has own custom form render element that results in a slightly different rendering order, adds #title_display => 'invisible' property and misses logic of WidgetBase class hiding labels for multiple fields.

So there are options:

1. Single date field/show label
2. Multiple date fields/hide label
3. Single date and time field/hide labels
4. Multiple date and time field/hide labels

An additional example of a multiple simple text field is attached.

The tests will be added with beta3

Thanks for the patch @silverham

Thanks for the patch Dylan Donkersgoed.

Updated the patch and tests.

The issue will be checked in 2.0.x branch.

The issue will be checked in 2.0.x branch.

The issue will be checked in 2.0.x-dev branch.

The issue will be checked in 2.0.x branch.

Yep, need to update to the latest 2.x version.

maximkashuba → made their first commit to this issue’s fork.

maximkashuba → created an issue.

maximkashuba → created an issue.

maximkashuba → made their first commit to this issue’s fork.

Reapplied patch #3 (comment 4).

maximkashuba → made their first commit to this issue’s fork.

Hi Kunal Gautam,
thank you for the patch.

I think the library dependency needs updating -> [once] library + send it in IIFE directly as `once`.

Hi Noorul Shameera,
thank you for the patch, but the issue duplicates https://www.drupal.org/project/entityreference_filter/issues/3287340 📌 Automated Drupal 10 compatibility fixes Fixed

Would you please to update/merge your patch changes with already automatically proposed changes in the original issue?

hi phoang, thank you for the patch.

maximkashuba → made their first commit to this issue’s fork.

Hi Charchil Khandelwal, thank you for the patch.

maximkashuba → made their first commit to this issue’s fork.