πŸ‡¬πŸ‡ͺGeorgia @maximkashuba

Batumi
Account created on 25 January 2013, over 11 years ago
  • Drupal developer at SkilldΒ  …
#

Merge Requests

Recent comments

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

Added base PayPal support for Stripe Payment Element with on-session Payment method usage.
Not tested with real payment, but only with test mode for Stripe.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

maximkashuba β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

rebased 2858890-views-ajax-fix-init-in-nested-views-patch-79 branch from 10.1.x to make the changes applicable.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

maximkashuba β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

robbm,

Can't reproduce the bug with Menu Entity Index module (sorting with the module views relations to menu items).

The results for the entity entityreference filter in a view are the same as for origin/source entity reference view and sorted in the same order.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

Duplicate of https://www.drupal.org/project/ctools/issues/3332913 πŸ› Fix PHP 8.2 deprecation notices and D10.1 compatibility Fixed issue.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

Labels for inputs are always present, but can be visually hidden (accessible to screen readers) if the field has multiple cardinality.

There are 2 scenarios: single and multiple cardinality field. For multiple fields the labels are visually hidden by the WidgetBase class, but for fields with a single element, the label is displayed as required by the task.

The Datetime field is flexible and can have 2 variants: date (1 input) or date and time (2 inputs), additionally it has own custom form render element that results in a slightly different rendering order, adds #title_display => 'invisible' property and misses logic of WidgetBase class hiding labels for multiple fields.

So there are states:

  1. Single date field/show label
  2. Multiple date fields/hide labels
  3. Single date and time field/hide label
  4. Multiple date and time field/hide labels

An additional example of a multiple simple text field is attached.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

Labels for inputs are always present, but can be visually hidden (accessible to screen readers) if the field has multiple cardinality.

There are 2 scenarios: single and multiple cardinality field. For multiple fields the labels are visually hidden by the WidgetBase class, but for fields with a single element, the label is displayed as required by the task.

The Datetime field is flexible and can have 2 variants: date (1 input) or date and time (2 inputs), additionally it has own custom form render element that results in a slightly different rendering order, adds #title_display => 'invisible' property and misses logic of WidgetBase class hiding labels for multiple fields.

So there are options:

  1. Single date field/show label
  2. Multiple date fields/hide label
  3. Single date and time field/hide labels
  4. Multiple date and time field/hide labels

An additional example of a multiple simple text field is attached.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

The tests will be added with beta3

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

Thanks for the patch @silverham

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

Thanks for the patch Dylan Donkersgoed.

Updated the patch and tests.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

The issue will be checked in 2.0.x branch.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

The issue will be checked in 2.0.x-dev branch.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

The issue will be checked in 2.0.x branch.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

maximkashuba β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

Hi Kunal Gautam,
thank you for the patch.

I think the library dependency needs updating -> [once] library + send it in IIFE directly as `once`.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

Hi Noorul Shameera,
thank you for the patch, but the issue duplicates https://www.drupal.org/project/entityreference_filter/issues/3287340 πŸ“Œ Automated Drupal 10 compatibility fixes Fixed

Would you please to update/merge your patch changes with already automatically proposed changes in the original issue?

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

hi phoang, thank you for the patch.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

maximkashuba β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

Hi Charchil Khandelwal, thank you for the patch.

πŸ‡¬πŸ‡ͺGeorgia maximkashuba Batumi

maximkashuba β†’ made their first commit to this issue’s fork.

Production build 0.69.0 2024