Filter options ignoring sort criteria of entity reference display

robbm,

Can't reproduce the bug with Menu Entity Index module (sorting with the module views relations to menu items).

The results for the entity entityreference filter in a view are the same as for origin/source entity reference view and sorted in the same order.

Thanks for investigating. I thought I'd found that it was any relationship, but perhaps it was the inclusion of views_tree…

I'll try to put together the simplest set of steps to reproduce the issue repeatedly.

Steps to reproduce:

1. mkdir EntityReferenceFilterTestProject
2. composer create-project "drupal/recommended-project:~9" EntityReferenceFilterTestProject/repo
3. cd EntityReferenceFilterTestProject/repo
4. sed -i 's/"stable"/"dev"/' composer.json # Or for macOS: sed -i '' 's/"stable"/"dev"/' composer.json
5. composer require drupal/entityreference_filter drupal/menu_entity_index drupal/views_tree
6. Install Drupal…
7. Enable modules: Menu Entity Index, Views Reference Filter, Views Tree.
8. Create Basic pages with titles as follows – adding each to the Main navigation menu:
   
   1. Cats (probably nid 1)
   2. Dogs (probably nid 2)
   3. Snails (probably nid 3)
   4. Sphinx (probably nid 4)
   5. Persian (probably nid 5)
   6. Moggy (probably nid 6)
   7. Husky (probably nid 7)
   8. Chow Chow (probably nid 8)
   9. Akita (probably nid 9)
   10. Mutt (probably nid 10)
9. Arrange in Main navigation menu as follows:
   1. Home
   2. Cats
      1. Persian
      2. Sphinx
      3. Moggy
   3. Dogs
      1. Akita
      2. Chow Chow
         
      3. Husky
      4. Mutt
   4. Snails
10. Configure Menu Entity Index to track Main navigation and Content.
11. Create view of Content, e.g. "Classification":
    
    1. Change Pager to Display all items.
    2. Add Relationship to Menu link ID, with an Administrative title of "Menu link". Require this relationship.
    3. Add Relationship to Parent menu link ID, with an Administrative title of "Parent link". Do not require this relationship.
    4. Add Relationship to Content (Menu Entity Index), with an Administrative title of "Parent node". Use relationship "Parent link". Do not require this relationship.
    5. Add field for ID (Content) with no relationship. Move this to the top of the fields list.
    6. Add field for Weight (Custom menu link) with a relationship to Menu link.
    7. Add fields for ID (Content) and Title (Content) – each with a relationship to Parent node.
    8. Add field for Weight (Custom menu link) with a relationship to Parent link.
    9. Add Entity Reference display.
    10. Change Format to TreeHelper (Adjacency model), setting:
        1. Search fields to Content: Title.
        2. Main field to (first) Content: ID.
        3. Parent field to (second) Content: ID.
    11. Remove sort criteria.
    12. Add sort criteria:
        1.  Weight with a relationship to Menu link.
        2.  Weight with a relationship to Parent link.

        
        Note that the sort order in the preview now echoes the menu order.
        
        

    13. Exclude all fields apart from Content: Title.
12. Add Reference, Content field to Basic pages, e.g. "Compatible":
    
    1. Limit to a single value.
    2. Select the view created above for the Reference method.
    3. Change the field from Autocomplete to Select list for the Form display.
13. Create or edit a Basic page.
    
    Note that sort order in the drop-down for the field created above is not the same as previously seen in the preview, i.e. it no longer echoes the menu order. (Not exactly the original issue, but closely related.)
    
    
14. Create view of Content, e.g. "Animals":
    
    1. Change Pager to Display all items.
    2. Add Page display with a path, e.g. "animals".
    3. Add entity reference filter for the field created above, e.g. "Content: Compatible (field_compatible) (entityreference filter)", and expose it.

    
    Note that sort order in the drop-down for the filter is not the same as previously seen in the preview, i.e. it no longer echoes the menu order.
    
    

In hindsight, the drop-down might be respecting the sort criteria, just not the Views Tree "grouping". Will double check and come back…