Drupal.views.ajaxView is not initializing pagers in nested views

Rebased against the most recent 10.1.x codebase.

With patch #103, works after cleared cache. However, issue reappears after some time. Caching issue?

@Anybody can you cherry-pick https://git.drupalcode.org/project/drupal/-/merge_requests/3125/diffs?co... to the 9.5.x branch? I think only the issue branch creator can cherry-pick for some reason.

Unsure about patches #101 and #103. There is a 9.5.x branch in https://git.drupalcode.org/issue/drupal-2858890/-/tree/2858890-9.5.x-vie.... Are your patches based on the diff of this branch? Let's not spread further confusion and finally resolve this year-old issue. Please work on the provided issue branches, thanks! 🙂

@ckng can you confirm this issue still exists with the diff of 9.5.x applied as a patch, once @Anybody cherry picks @nsciacca "once" change?

https://git.drupalcode.org/project/drupal/-/merge_requests/3126.diff

@Grevil: No, sadly no such option. Can only be done manually or by patch, sorry.

Ok something went wrong here...

Alright! Everything should be cleared up now! I manually applied the relevant changes of https://git.drupalcode.org/project/drupal/-/merge_requests/3125/diffs?co... by @nsciacca and fixed the 11.x branch again! The main problem, was that 11.x ditches the old "ajax_view.js" in favour of "ajax_view.es6.js".
Please review!

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

How annoying... "MR !3126" can not be applied to 11.x as it is the 9.5.x feature branch... Going to close the MR for now in hopes the bot won't set it to "Needs work" again.

Anybody → closed merge request !3126

Can the issue summary be updated with steps to reproduce. Also the link is pointing to 8.4 so definitely outdated.

Also as a bug will need a test case.

OK, it seems that all patches after "drupal-2858890-79.patch" by @prudloff explicitly check for the ".views-infinite-scroll-content-wrapper". This definitely be avoided inside a core issue.

It also seems that patch 86 was originally created without a reason? From the conversation, the original problem with the broken media library got fixed with patch 79 and there were only tests left to fix. Then suddenly patch 86 got introduced with the same goal to fix the media library, which introduced the check for ".views-infinite-scroll-content-wrapper".

I'll create a second branch with the changes from patch 79 and see how that goes.

Let's see if tests succeed on that branch as well (1 failing test is expected, which needs to be refactored).

Anybody → closed merge request !3125

Alright! This works great in conjunction with the latest issue fork changes from 🐛 After update to Drupal 8.4 VIC replace results instead of appending Closed: cannot reproduce for 11.x! :)

Now let's see, what the tests say, and then we can create a fork, to backport the changes for 10.1.x as well!

(Also tests need to be created).

I don't know, how to properly test this, so I am leaving this issue on "Needs work" for people to create tests.

(For all infinite scroll users, coming from 🐛 After update to Drupal 8.4 VIC replace results instead of appending Closed: cannot reproduce , this core patch seems to not be needed any more for Drupal 10.x)

I am removing the "major" priority, as it wasn't major to begin with.

Update to my comment in #127. The issue in 🐛 After update to Drupal 8.4 VIC replace results instead of appending Closed: cannot reproduce isn't a thing anymore, it works just fine in current 2.0.x.

Meaning that the manual testing I did for this issue was incorrect... 🫠

So if anyone runs into this issue, please test the current issue branches, and see, if it fixes the problem for you:

• "2858890-2858890-views-ajax-fix-init-in-nested-views-patch-79-10.1.x" => for 10.1.x
• "2858890-views-ajax-fix-init-in-nested-views-patch-79" for 11.x

If so, it would be really nice, to add the steps you took inside the issue summary's "Steps to reproduce" section. And if you can also write tests, please verify the fixed behavior through tests!

Thanks.

rebased 2858890-views-ajax-fix-init-in-nested-views-patch-79 branch from 10.1.x to make the changes applicable.

I opened another MR for the 10.2.x branch as neither existing MR/patch was applying cleanly. Includes my modification with the extra selectors that were breaking Entity Browser.

Merge request !5867 doesn't apply to Drupal 10.2.2.