- ๐บ๐ธUnited States smustgrave
Feedback on the MR appears to be addressed.
Re-ran the test-only job after the pattern change and it still fails as expected, so coverage is still good.
- ๐บ๐ธUnited States FatherShawn New York
I've had an inquiry about the appropriate markup to use and have moved that to a child issue: ๐ฑ [policy, no patch] Choose a markup strategy for HTMX POC Active Please add your guidance there!
- ๐ซ๐ทFrance jmaxant
Ok, so, after much contemplation and reading the docs, it seems the Test-only changes job is supposed to fail ? I feel a little silly tbh, but hey, I learnt something new !
Changing the status to need review.
- ๐ฏ๐ดJordan Rajab Natshah Jordan
Attached a static patch file from the Drupal Core 2024-06-20 MR 8105
witch applies to both Drupal 10.3.x and 11.0.x branches
To be used with composer patches - ๐ฎ๐นItaly kopeboy Mainland
Actually, the headingsOffset doesn't brake the scrolling, but it doesn't look like it's doing anything either..
I tried from 20 to 120 and I saw no change.Assuming the library itself works correctly, there might be work to do in this module.
- ๐ฎ๐นItaly kopeboy Mainland
I just tested it.
Two new fields are added to the config page.
headingsOffset seems to work properly, while scrollSmoothOffset seems broken (or I don't understand how it should work). For example I tried adding
20
and it broke the smooth scrolling. - ๐บ๐ธUnited States smustgrave
Hiding patches for clarity
Previously was tagged for tests so moving to NW for that.
Thanks.
Automatically closed - issue fixed for 2 weeks with no activity.
- ๐ฏ๐ตJapan Tom Konda
Reran the pipeline and all tests are passed.
Please review. - ๐ฎ๐ณIndia Mithun S Bangalore
Added a rebase of the latest changes from the branch.
The MR looks mergable now. Thank you! - ๐ฎ๐ณIndia Mithun S Bangalore
Mithun S โ made their first commit to this issueโs fork.
After rebased MR, fixed test failures of pipeline(II stage)
However, there are still some test failures of pipeline(III stage) that's needs to be addressed.
pooja_sharma โ changed the visibility of the branch 2293803-Replace-confirm-pass to active.
pooja_sharma โ changed the visibility of the branch 2293803-Replace-confirm-pass to hidden.
- First commit to issue fork.
- ๐ฎ๐ณIndia yash.rode pune
Hi I tried the steps above but the issue only occurs when we try to change the URL and not when we visit the URL for the first time?
If that is the expected behaviour how can we write a test for that scenario? #28 seems to be a better approach, so I have reverted the class changes and added tabIndex to the button thus making it non tabbable.Also the mousedown trigger event is working so marking it as needs review again.Thanks!
- ๐ฆ๐บAustralia pameeela
In light of the the latest comments, I'm marking this as Closed (won't fix) since the consensus is not to progress this any further.