- ๐ณ๐ฑNetherlands wilfred waltman
I was to quick with my comment that this was already
- ๐ณ๐ฑNetherlands wilfred waltman
It seems that this patch has already found its way to version 2.x
- ๐บ๐ฆUkraine Taran2L Lviv
the conversion to OOP hooks broke this MR, corresponding code should be moved to the class files, I can take a look later this week
- ๐บ๐ธUnited States smustgrave
Re-solved the threads but appears to need a manual rebase (200 commits back), surprised the bot never picked it up.
The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ฌ๐งUnited Kingdom scott_euser
Thank you all for all the hard work on this. Challenging problem and sounds like we need some sort of round table or vote or something perhaps from a slightly wider group. Is #admin-ui slack channel maybe appropriate to have it discussed as part of the next meeting to agree on a direction?
I have been working on โจ Improve the Search API admin UI for adding/editing fields Active which is nearly there (just coordinating final steps via slack with solr and search api maintainers). As a next step I would love to be able to leverage this as I am sure you have probably all tried search API add fields and know how unweildy that list can become. With search api getting into Drupal Cms (and AI Search leveraging that as a submodule of AI) it'll be a great improvement for both.
So I would love to help test this out within the context of core and test extensibility of it over there (if it's not @internal), but sounds like a bit of a huddle is needed first to know which direction to test.
In any case this is a really great chunk of work that could benefit a lot of areas I'm sure! Thank you!
- ๐ฌ๐งUnited Kingdom nicrodgers Monmouthshire, UK
Setting back to needs work due to the failing coding standards issues picked up in the pipeline.
- ๐ฌ๐งUnited Kingdom nicrodgers Monmouthshire, UK
I've updated the issue summary, and created a merge request based on the patch from #71 as the patches have been deprecated.
- @nicrodgers opened merge request.
- ๐บ๐ธUnited States cboyden
I've created an issue fork from 11.x and ported the changes from patch #20. Still needs updated tests.
- ๐ฎ๐ณIndia gauravjeet
It's been a while this issue is opened and the patches (re-rolls) apply and work succesfully, can this be merged into core now or, are there any other pressing issues stopping this patch merge?
Patch #71 works fine for me btw!