- ๐ฎ๐ณIndia vinmayiswamy
Hi everyone,
Iโve tried to reproduce this issue described in the issue description by following the steps mentioned. Hereโs a summary of my findings:
Commit Analysis:
- The recent commit d251a98 includes a relevant fix in theviews/js/base.js
file that addresses a similar issue.
- The updated code now includes logic to handle cases where query parameters might be empty, which aligns with the changes proposed in the patch for this issue.Code Comparison:
Original Patch Diff:- if (pair[0] !== 'q' && pair[1]) { + if (pair[0] && pair[0] !== 'q') {
Recent Commit Diff:
- if (pair[0] !== 'q' && pair[1]) { - args[decodeURIComponent(pair[0].replace(/\+/g, ' '))] = - decodeURIComponent(pair[1].replace(/\+/g, ' ')); + if (pair[0] !== 'q') { + if (pair[1]) { + args[decodeURIComponent(pair[0].replace(/\+/g, ' '))] = + decodeURIComponent(pair[1].replace(/\+/g, ' ')); + } else { + args[decodeURIComponent(pair[0].replace(/\+/g, ' '))] = ''; + }
Findings:
- The recent commit ensures that query parameters are handled correctly even if their values are empty, resolving the issue of incorrect pagination and filtering behavior.
- I have tested the functionality in Drupal 11.x, and the filtering and pagination work as expected.Given that the recent commit appears to resolve the issue and the functionality works correctly in Drupal 11.x, the patch proposed in this issue may no longer be necessary.
Request for Feedback:
- If there are any additional steps or scenarios that I may have overlooked while reproducing the issue, I would be grateful if you could share them with me.
- I would greatly appreciate any guidance on whether further action is required or if there are any other aspects I should consider.Thanks!
- Status changed to Postponed: needs info
5 days ago 1:22am 28 June 2025 - ๐บ๐ธUnited States tim.plunkett Philadelphia
xjm โ credited tim.plunkett โ .
- ๐บ๐ธUnited States xjm
Crediting as per triage in #3.
Nice research @vinmayiswamy! Sorry for the very long delay in response. It does indeed look like ๐ AJAX pager doesn't work with exposed filter which has a default value Fixed may have been a duplicate of this issue.
The final step I would take would be to manually test this on Drupal 10.0 and confirm that the bug can be reproduced, and then again Drupal 10.1 (or even a more supported version like 10.5) and confirm the bug is no longer there.
Once that is done, if it shows this issue fixed, we can close this issue as a duplicate.