🇷🇴Romania @cslevy

Accidentally I left some debugging in the first patch. Here is a new one

I created a patch which fixes this issue.

I created a mechanism to check if any strategy was added/removed, and only then the index is flagged for re-indexing.

Also changed the hook_cron to hook_rebuild. When a new strategy is created and added to the service, a cache rebuild is required. So it's enough to run the Sync service only then, not on cron.

cslevy → created an issue.

This still doesn't fix the issue. I attached an extra patch, which also should be included.

I have the same issue.

What I had to do to get rid of the error is the following

I uninstalled the module
I removed the module entirely
I truncated all cache_ tables.

Re-rolled patch for the latest module.

Wrong ticket. Sorry

Re-rolled patch for 10.3.x

This will happen for all Blocks, that has a hierarchical structure in the form.

$block_state = (new FormState())->setValues($configuration);
$block->submitConfigurationForm($form, $block_state);

Here the FormState is initialised with the $configuration values which is a simple array, but if you check the SystemBrandingBlock or LocalTasksBlock blockSubmits, you can see that the values from the fieldset are moved to the top level values.

So this is a general issue, and will show up for every block which has hierarchical form structure.

Sorry previously updated the wrong patch.

For some reason the patch from #7 it's not applying for me when installing with composer. I recreated the patch, which applies

I couldn't apply the patch from #8 so I recreated the patch to work with the latest version of the module

After the last update (2.8 -> 2.9) this patch isn't working properly. (The shipping is increased every time the order is saved)

I created a new patch, which works, I'm not sure, if it's the correct way to handle this, or if works in all cases.

Feel free to adjust/reroll.

I had the same issue, i did some digging, and I discovered that the filter key was conflicting with some other functionality.

In my case: I had a multi-language website, and the Language Negotiation was based on the language query parameter, but my exposed filter also had the "language" filter key. I changed that to "lang", and it's working properly.

I recreated the patch, to apply the taxes to shipping promotions before calculating shipping taxes.

I couldn't apply the patch from #22. Recreated it to work with the latest 10.2

Patch need to be applied together with: https://www.drupal.org/project/commerce/issues/2982355 🐛 Incorrect percentage discounts when prices are entered with tax, but displayed without (or vice-versa) Needs work

cslevy → created an issue.

I recreated this patch to work with the latest commerce.

But I also encounter rounding issues, and I think that the discount amounts should be always rounded half down, not up. I'm not sure if it's correct or not, but I created the patch in 2 versions. one as it was in the previous comment with round up, and one with round down.

Please advise on this

cslevy → created an issue.

I recreated the patch for Drupal 10.2.x

The patch from #5 is not working for me. I adjusted the patch to work with the latest IMCE and Drupal 10.

cslevy → created an issue.

Something is not ok with this patch.

When this was introduced

$container->get('entity_type.manager')->getStorage('media'),

if the Media module is not enabled, this breaks the whole search api functionality.

I encountered the same issue. The In between buttons are not showing. I was able to track down the issue.

Core: Drupal 10.1.5
Paragraphs: 1.16.0
Paragraphs EE: 10.0.2
Paragraphs Feature: 2.0.0-beta3

With clean install everything working for me as expected, but there is a ticket in core ( https://www.drupal.org/project/drupal/issues/2118743 🐛 Twig debug output does not display all suggestions when an array of theme hooks is passed to #theme Needs work ) which resolves some suggestion issues (I need it to be able to use suggestions for views), breaks this functionality.

I'm not sure, if the patch from the ticket is wrong, or if something in this module is wrong, but the wrong template is used, if the patch is applied (paragraphs-add-dialog.html.twig is used instead of paragraphs-add-dialog--categorized.html.twig, because they ore in a wrong order.)

I managed to fix the issue locally with:

function hook_theme_suggestions_alter(array &$suggestions, array $variables, $hook) {
  if ($hook == 'paragraphs_add_dialog__categorized') {
    $suggestions[] = 'paragraphs_add_dialog__categorized';
  }
}

I re-rolled the patch to fix some warnings for PHP 8.2. And also fixed some coding standards.

cslevy → created an issue.

Hello,

This merge generates a fatal error.

Fatal error: Uncaught TypeError: Drupal\domain_language\DomainLanguageOverrider::__construct(): Argument #1 ($current_user) must be of type Drupal\Core\Session\AccountProxyInterface, Drupal\Core\Config\CachedStorage given, called in .../web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and defined in .../web/modules/contrib/domain_language/src/DomainLanguageOverrider.php:81

This class is defined in the services in the following way:

  domain_language.overrider:
    class: Drupal\domain_language\DomainLanguageOverrider
    tags:
      - { name: config.factory.override, priority: -140 }
    arguments: ['@config.storage']

And also the create method was introduced.

/**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container) {
    return new static(
      $container->get('current_user'),
      $container->get('domain.negotiator'),
      $container->get('config.factory'),
      $container->get('domain_config.overrider')
    );
  }

We don't need both. I think the dependencies should be defined in the services.yml, and this create method removed.

In your main composer.json file in the extra section

"extra": {
"composer-exit-on-patch-failure": false
}

I created a patch which handles this issue. I'm not sure if this is the proper way to handle this, but it seems to be working.

Please review

cslevy → created an issue.

This patch was already included in the section_library module that's why is not applying anymore. This should be removed from the commerce_kickstart's composer.json

As a workaround:

In the main composer.json you can change this to false:

"composer-exit-on-patch-failure": true,

That will allow you to finish install (Run composer update after the changes).

Thank you for the patch, but I think that in the viewCart event listener is missing some kind of conditions. At the moment the event is triggered on every page.

Re-rolled patch with to be able to apply on the latest release.

Here is a patch which fixes the issue

This merge breaks the functionality. If FullcalendarViewPreprocess is a service then the dependencies should be added directly into the services.yml file, not with create method.

Something like this:

# View preprocess service.
fullcalendar_view.view_preprocess:
class: Drupal\fullcalendar_view\FullcalendarViewPreprocess
arguments: ['@language_manager', '@csrf_token', '@entity_type.manager', '@fullcalendar_view.timezone_conversion_service']

and the create method is not needed.