\Drupal calls should be avoided in classes, use dependency injection instead

Unassigning, as its been 2 weeks and no work is done.

As per Issue Etiquette #8 of Dont's ( https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... → ), do not assign yourself to an issue unless you intend to work on it in a fairly short timeframe.

Also, as per issue summary, it is not clear, which command has been executed to reproduce this issue.

I have updated the issue summary.

I will provide a solution shortly.

Please review.

Thanks

Hello @urvashi_vora
I have tested MR10, and it appears that the changes made have resolved all the errors and warnings.
Thank you for the support

Merged to 8.x-1.x. Thanks!

Hello,

This merge generates a fatal error.

Fatal error: Uncaught TypeError: Drupal\domain_language\DomainLanguageOverrider::__construct(): Argument #1 ($current_user) must be of type Drupal\Core\Session\AccountProxyInterface, Drupal\Core\Config\CachedStorage given, called in .../web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and defined in .../web/modules/contrib/domain_language/src/DomainLanguageOverrider.php:81

This class is defined in the services in the following way:

  domain_language.overrider:
    class: Drupal\domain_language\DomainLanguageOverrider
    tags:
      - { name: config.factory.override, priority: -140 }
    arguments: ['@config.storage']

And also the create method was introduced.

/**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container) {
    return new static(
      $container->get('current_user'),
      $container->get('domain.negotiator'),
      $container->get('config.factory'),
      $container->get('domain_config.overrider')
    );
  }

We don't need both. I think the dependencies should be defined in the services.yml, and this create method removed.

Automatically closed - issue fixed for 2 weeks with no activity.

This issue is closed, so I created 🐛 DomainLanguageOverrider::__construct(): Argument #1 ($current_user) must be of type AccountProxyInterface Active to address the error cslevy mentions.