- last update
over 1 year ago 89 pass, 1 fail - π§π¬Bulgaria vflirt
Adding new patch for D10 against the 2.x dev branch as some things are removed in the DomainStorage and needed changes:
1. Have to use$this->getEntityClass();
2. Have to use 'invokeAllWIth' for the modulehandles as 'getImplementations' is removed. The last submitted patch, 13: 3195219-domain_middleware-13.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
over 1 year ago 9:59am 25 August 2023 - πΊπΈUnited States SocialNicheGuru
@vflirt are the changes specific to D10? Is this patch in #13 backward compatible to Drupal 9?
- π§π¬Bulgaria vflirt
@SocialNicheGuru as far as I am aware they are. getEntityClass exists as method and the use of `invokeAllWIth` is wrapped in method_exists check.
- last update
over 1 year ago 89 pass, 1 fail - π·π΄Romania cslevy
I re-rolled the patch to fix some warnings for PHP 8.2. And also fixed some coding standards.
- π§π¬Bulgaria vflirt
It seems I have made big mistake of how I added the invokeAllWIth. Here is proper updated patch that would call the parent::postLoad so that way it is compatible with D9 or D10 as the parent will know which one to invoke.
- π¦πΉAustria kevin.pfeifer
We run into a similar issue with the Domain 2.0.0-beta1 when upgrading from Drupal 10.1 to 10.2 but haven't found a solution yet.
Circular reference detected for service "domain.route_provider", path: "options_request_listener -> domain.route_provider -> cache_tags.invalidator -> plugin.manager.block -> logger.channel.default -> logger.factory -> logger.raven -> router -> router.no_access_checks"
- πΊπΈUnited States SocialNicheGuru
π Remove dependency of "file_system" service on "logger" Needs work
@kevin.pfeifer Got the same issue for Domain module while migrating to Drupal 10. Were you able to find a solution?
- π¦πΉAustria kevin.pfeifer
@jomsy sorry, we haven't yet since we just stayed on Drupal 10.1 for now.
- π¦πΉAustria kevin.pfeifer
So.... no one else encountered this issue yet?
- π¦πΉAustria kevin.pfeifer
The problem is related to https://www.drupal.org/project/drupal/issues/3103620 π Dependency on config storage causes circular reference in service container Needs review
We applied the patch #62 from that core issue and now its working again. Seems like its related to the fact, that we have raven (sentry plugin) installed as well in combination with the domain module.