The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 10:17am 14 February 2023 - 🇮🇳India gauravvvv Delhi, India
Patch #62 contains changes to
tableheader.es6.jsfile. which is no longer part of 10.1.x
Re-rolled patch for 10.1.x. Please review - Status changed to Needs work
almost 2 years ago 3:23pm 3 March 2023 - 🇺🇸United States smustgrave
This seems like something that can have a test case to show the issue.
- last update
11 months ago 25,810 pass, 1,817 fail - last update
11 months ago 25,806 pass, 1,820 fail - last update
10 months ago Patch Failed to Apply - last update
10 months ago Patch Failed to Apply - 🇮🇳India dipakmdhrm
tableheader.js creates a second table which holds the sticky headers
I noticed that for a normal table, there's no duplicate sticky header. Header is made sticky using css.
But for a
tableselecttable, we have duplicate header.
In this case too, ideally we should be able to make the header sticky using css.Why do we have duplicate header? Is this remnant from some old issue or do we still need this?
- 🇮🇳India dipakmdhrm
Why do we have duplicate header? Is this remnant from some old issue or do we still need this?
To answer my own question, this was because IE11 didn't support `position: sticky`.
Now that Drupal >= 10 doesn't support IE11, we can use `position:sticky`.It's already been done in https://www.drupal.org/project/drupal/issues/3362276 📌 Use position: sticky for views sticky table header Fixed for some tables.
Let's do this for tableheader too.
- 🇮🇳India dipakmdhrm
Issue to deprecate drupal.tableheader: https://www.drupal.org/project/drupal/issues/3439580 📌 Make drupal.tableheader only use CSS for sticky table headers Needs review
- Status changed to Closed: duplicate
8 months ago 5:03am 13 April 2024 - 🇮🇳India dipakmdhrm
Closing in favor of https://www.drupal.org/project/drupal/issues/3439580 📌 Make drupal.tableheader only use CSS for sticky table headers Needs review