dipakmdhrm → created an issue.
dipakmdhrm → made their first commit to this issue’s fork.
dipakmdhrm → made their first commit to this issue’s fork.
dipakmdhrm → created an issue. See original summary → .
All 3 patches from #3, #4 & #5 need to be applied after one another to fix this. The MR combines the patches.
dipakmdhrm → made their first commit to this issue’s fork.
Patch for D10
dipakmdhrm → created an issue.
This should be reopened for compatibility with `openid_connect:^3.0`
dipakmdhrm → made their first commit to this issue’s fork.
dipakmdhrm → created an issue.
dipakmdhrm → created an issue.
Wooo wooo yay!!!
Any chance to do a d11-beta2 to avoid all this? :P
@nod_ @catch: We're now at beta for D11. Does that mean we now need to adjust the change record & deprecation to target 11.1 & 12 instead of 10.3 & 11?
The patch in #31 is retroactively made for a specific version of D10.
The MR's still work for the issue.
dipakmdhrm → created an issue.
dipakmdhrm → created an issue.
Tests for this should now hopefully pass for 11.x branch after the changes from this issue 📌 Set budgets rather than exact numbers of asset size assertions Downport were merged in the MR branch.
dipakmdhrm → changed the visibility of the branch 3439580-remove-drupal.tableheader-library to active.
Reopening MR for 10.3.x for budgeting in more places. This is needed to avoid failures for changes such as the ones in this issue: https://www.drupal.org/project/drupal/issues/3439580 📌 Make drupal.tableheader only use CSS for sticky table headers Needs review
These changes where there for the MR for 11.x, but not for the one for 10.3.x.
dipakmdhrm → made their first commit to this issue’s fork.
dipakmdhrm → changed the visibility of the branch 3439580-remove-drupal.tableheader-library to hidden.
Latest MR fixes this. RTBC
@sourojeetpaul Nice work finding out that this was a webform issue!
Also added a comment to MR.
From your comment and my original findings, I believe this issue is a webform issue, but at the moment limited to claro.
Olivero doesn't seem to be affected by this, but like you mentioned it has it's own issue with icons.
I'll update the issue to keep the scope limited to claro & webform. Feel free to update if you disagree or/and if you find more.
Again, nice work! My bad that I missed that this was a webform issue.
dipakmdhrm → changed the visibility of the branch 3441015-title-of-a to hidden.
Patch with proper whitespaces
I had some trouble with issue forks so here's a patch and before and after shots:
dipakmdhrm → changed the visibility of the branch 3441015-title-of-a to active.
dipakmdhrm → changed the visibility of the branch 3441015-title-of-a to hidden.
dipakmdhrm → changed the visibility of the branch 3441015-title-of-a to hidden.
dipakmdhrm → changed the visibility of the branch 3441015-title-of-a to hidden.
dipakmdhrm → created an issue.
Closing in favor of https://www.drupal.org/project/drupal/issues/3439580 📌 Make drupal.tableheader only use CSS for sticky table headers Needs review
Patch re-rolled for Drupal 10.2.5
A new patch for 10.2.x:
Ready for review for 10.3.x
Don't think this is good to go. You can't remove and deprecate at the same time.
I've created an MR which should be better implemented than the patch.
The MR keeps the `drupal.tableheader` library while deprecating, but removes the associated JS files, PHP code & text, and adds the css for sticky position.
Eum, you already removed it? Also D11 is not yet released, so I believe it's possible to remove this in 11.0.0 and add the deprecations to D10.
That's not a bad idea.
Thanks mr. needs-review-queue-bot. MR created.
It's fascinating that `position:sticky` replaces ~450 lines of code.
Issue to deprecate drupal.tableheader: https://www.drupal.org/project/drupal/issues/3439580 📌 Make drupal.tableheader only use CSS for sticky table headers Needs review
Follow up issue to deprecate drupal.tableheader
https://www.drupal.org/project/drupal/issues/3439580
📌
Make drupal.tableheader only use CSS for sticky table headers
Needs review
dipakmdhrm → created an issue.
Why do we have duplicate header? Is this remnant from some old issue or do we still need this?
To answer my own question, this was because IE11 didn't support `position: sticky`.
Now that Drupal >= 10 doesn't support IE11, we can use `position:sticky`.
It's already been done in https://www.drupal.org/project/drupal/issues/3362276 📌 Use position: sticky for views sticky table header Fixed for some tables.
Let's do this for tableheader too.
tableheader.js creates a second table which holds the sticky headers
I noticed that for a normal table, there's no duplicate sticky header. Header is made sticky using css.
But for a tableselect table, we have duplicate header.
In this case too, ideally we should be able to make the header sticky using css.
Why do we have duplicate header? Is this remnant from some old issue or do we still need this?
dipakmdhrm → created an issue.
dipakmdhrm → made their first commit to this issue’s fork.
dipakmdhrm → created an issue.
This patch removes all requirement error code.
I had some trouble with MR workflow, so here's the patch removing all requirement error code.
@joseph.olstad You should be able to reproduce this error after Drupal 10.1.0 with Claro theme and lates vbo module.
dipakmdhrm → created an issue.
dipakmdhrm → made their first commit to this issue’s fork.
Patch for the MR.
dipakmdhrm → created an issue.
Patch to apply after https://www.drupal.org/project/ckeditor5_font/issues/3368736 🐛 Error after update to Drupal 10.1.0 Active
dipakmdhrm → made their first commit to this issue’s fork.
dipakmdhrm → created an issue.
dipakmdhrm → created an issue.
dipakmdhrm → created an issue.
hchonov → credited dipakmdhrm → .
Shriaas → credited dipakmdhrm → .
dipakmdhrm → created an issue.
The following regex helped me replace a lot of old once() implementations with new one for D10 upgrade:
\$\((.*)\)\.once\(('.*')\) => $(once($2, $1)) (edited)
dipakmdhrm → made their first commit to this issue’s fork.
dipakmdhrm → made their first commit to this issue’s fork.
dipakmdhrm → created an issue.
dipakmdhrm → made their first commit to this issue’s fork.
We have a UI for delete users in this module. We don't want to skip access check in UI.
To resolve this I've added a new option --bypass-access-check for the drush dade command.
This will allow someone with drush access to delete all entities without access checks.
Also, this is not critical. Downgrading to normal.
dipakmdhrm → made their first commit to this issue’s fork.
Duplicate of https://www.drupal.org/project/media_thumbnail_url_formatter/issues/3329356 📌 Drupal 10 compatibility Fixed
Duplicate of https://www.drupal.org/project/media_thumbnail_url_formatter/issues/3329356 📌 Drupal 10 compatibility Fixed