Contrib.social

Warning: Undefined array key "end_session_endpoint" since 3322786

Open on Drupal.org →
Created on 10 November 2023, 8 months ago
Updated 22 December 2023, 6 months ago

Problem/Motivation

Spun from:
✨ Implement end_session endpoint option Fixed

We're seeing a warning message when using the latest release of openid_connect_windows_aad 2.0.0-beta6 with openid_connect 3.0.0-alpha2

For some reason we do not have end_session_endpoint configured or set yet, and the module is throwing an unhandled/unexpected warning message straight from php.

Warning: Undefined array key "end_session_endpoint" in Drupal\openid_connect_windows_aad\Plugin\OpenIDConnectClient\WindowsAad->getEndpoints() (line 290 of modules/contrib/openid_connect_windows_aad/src/Plugin/OpenIDConnectClient/WindowsAad.php).
Drupal\openid_connect_windows_aad\Plugin\OpenIDConnectClient\WindowsAad->getEndpoints() (Line: 68)
Drupal\openid_connect_windows_aad\Plugin\OpenIDConnectClient\WindowsAad->__construct(Array, 'windows_aad', Array, Object, Object, Object, Object, Object, Object, Object, Object, Object) (Line: 88)
Drupal\openid_connect_windows_aad\Plugin\OpenIDConnectClient\WindowsAad::create(Object, Array, 'windows_aad', Array) (Line: 21)
Drupal\Core\Plugin\Factory\ContainerFactory->createInstance('windows_aad', Array) (Line: 83)
Drupal\Component\Plugin\PluginManagerBase->createInstance('windows_aad', Array) (Line: 62)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->initializePlugin('windows_aad') (Line: 49)
Drupal\openid_connect\Plugin\OpenIDConnectClientCollection->initializePlugin('windows_aad') (Line: 80)
Drupal\Component\Plugin\LazyPluginCollection->get('windows_aad') (Line: 83)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->setConfiguration(Array) (Line: 99)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->addInstanceId('windows_aad', Array) (Line: 55)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->__construct(Object, 'windows_aad', Array) (Line: 37)
Drupal\openid_connect\Plugin\OpenIDConnectClientCollection->__construct(Object, 'windows_aad', Array, 'windows_aad') (Line: 142)
...

Steps to reproduce

using the latest release of openid_connect_windows_aad 2.0.0-beta6 with openid_connect 3.0.0-alpha2
For some reason we do not have end_session_endpoint configured or set yet, and the module is throwing an unhandled/unexpected warning message straight from php.

Proposed resolution

workaround would be to set a value for end_session_endpoint

Remaining tasks

Create a patch

User interface changes

TBD

API changes

TBD

Data model changes

N/A

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇨🇦Canada joseph.olstad

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @joseph.olstad
  • Comment 8 months ago →
    🇨🇦Canada joseph.olstad
  • Comment 8 months ago →
    🇨🇦Canada joseph.olstad
  • Status changed to Needs review 8 months ago
  • Comment 8 months ago →
    🇨🇦Canada joseph.olstad
  • Comment 7 months ago →
    🇺🇸United States srees

    This is actually the last item preventing us from completing a migration to D10, so I think the priority needs to be increased.

  • Comment 7 months ago →
    🇨🇦Canada joseph.olstad

    @srees, can you please elaborate a bit on your feedback?

    Have you tested patch #3?

    Have you tried setting the value of this field and exporting the config with the end_session_endpoint value?

  • Comment 7 months ago →
    🇺🇸United States srees

    First, I'll apologize for failing to see patch 3.

    That said, I applied it, and the error changes now to:
    Warning
    : Undefined array key "upn" in
    Drupal\openid_connect_windows_aad\Plugin\OpenIDConnectClient\WindowsAad->buildUserinfo()
    (line
    475
    of
    modules/contrib/openid_connect_windows_aad/src/Plugin/OpenIDConnectClient/WindowsAad.php
    )

    Not sure if that belongs in a new ticket since it's a different error now.

  • Comment 7 months ago →
    🇨🇦Canada joseph.olstad

    @srees, maybe add the fix for line 475, take inspiration from patch #3, generate a new patch.

    Here's how to create a patch: → https://www.drupal.org/patch/create →

  • Comment 7 months ago →
    🇨🇦Canada joseph.olstad

    With that said, you may be able to adjust your configuration through the ui.

    I would suggest visiting this page:

    /admin/config/people/openid-connect/windows_aad/edit

    and this page

    /admin/config/people/openid-connect/settings

    On both of these pages, click the save button.

    This should fix the glitch.

    You may want to do that a few times.

    What version of openid_connect_windows_aad are you using?

    What version of drupal core are you using? D10.0.11 ? D10.1.6? D9.5.11 ?

    What version of openid_connect are you using?

  • Comment 7 months ago →
    🇩🇪Germany webflo

    I think we should update the configuration again and fix there bug there. I think its not required to add ?? '' in a few places to fix this bug.

  • Comment 7 months ago →
    🇮🇳India chetan 11

    chetan 11 → made their first commit to this issue’s fork.

  • Merge request !25fixed → (Open) created by chetan 11
  • Comment 7 months ago →
    🇮🇳India chetan 11

    Hi,
    I have fixed the above error on the "OpenID Connect Windows Azure Active Directory" module, please check the raised MR.
    Thanks.

  • Comment 6 months ago →
    🇫🇮Finland HeikkiY Oulu

    I reviewed the change and tested changing the settings in our environment where we got the error.

    We did get a lot of new settings both for the openid_connect.settings.yml and openid_connect.client.windows_aad.yml.

    The code change looks good for me to take into account the missing configuration but I was also wondering if we should add the need configurations to the schema file:
    https://git.drupalcode.org/project/openid_connect_windows_aad/-/blob/2.0...

    To me it seems like the following configurations are missing from the schema:

    redirect_url
enable_single_sign_out
iss_allowed_domains
end_session_endpoint
front_channel_logout_url
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024