Add border to color tiles

Created on 21 November 2023, over 1 year ago

Problem/Motivation

Steps to reproduce

White color tile is not visible without a border:

Let's add a border to all tiles to make it visible like this:

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

โœจ Feature request
Status

Active

Version

1.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia dipakmdhrm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dipakmdhrm
  • Merge request !3Add border to color tiles. โ†’ (Open) created by dipakmdhrm
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia dipakmdhrm

    Patch to apply after https://www.drupal.org/project/ckeditor5_font/issues/3368736 ๐Ÿ› Error after update to Drupal 10.1.0 Active

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia vinayakmk47

    Hi, How you are able to even reproduce the issue I tried to install that module in drupal 9 and also tried in drupal 10 getting error after installing and going to the path admin/config/content/formats/manage/full_html?destination=/admin/config/content/formats.

    The website encountered an unexpected error. Try again later.

    Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "ckeditor5_codeBlock" CKEditor 5 plugin definition is configurable, has non-empty default configuration but has no config schema. Config schema is required for validation. in Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition->validateDrupalAspects() (line 186 of core/modules/ckeditor5/src/Plugin/CKEditor5PluginDefinition.php).

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia vinayakmk47

    Hi,

    Iโ€™m trying to reproduce the issue you mentioned, but I'm encountering errors when attempting to install the module. Here's what I did:

    I tried installing the module in both Drupal 9 and Drupal 10.
    After installation, I navigated to the path:
    admin/config/content/formats/manage/full_html?destination=/admin/config/content/formats.
    At this point, the following error occurs:
    The website encountered an unexpected error. Try again later.

    The detailed error message is:

    Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "ckeditor5_codeBlock" CKEditor 5 plugin definition is configurable, has non-empty default configuration but has no config schema. Config schema is required for validation. in Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition->validateDrupalAspects() (line 186 of core/modules/ckeditor5/src/Plugin/CKEditor5PluginDefinition.php).

    Could you confirm how you were able to reproduce the issue or provide guidance on resolving this error? Am I missing any prerequisites or specific configurations required for this module?

    also the CKEditor module is installed already

    Thank you!

  • haritha c โ†’ made their first commit to this issueโ€™s fork.

  • Merge request !11Resolve #3403014 "Bordertiles" โ†’ (Open) created by Unnamed author
  • The issue has been fixed, and I have updated the patch in Git (21df20b0) with the border color adjustments for the tiles.

    Please review and update the status accordingly.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia vinayakmk47

    Hi,

    Previously, the white tiles were not visible without a border, which made it difficult to distinguish them.

    I have reviewed the issue and tested the patch. The proposed fix works as expected. The white color tiles now have a visible border, improving the overall usability and clarity.

Production build 0.71.5 2024