- Issue created by @dipakmdhrm
- 🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- Status changed to Needs review
4 months ago 11:00am 3 September 2024 - Status changed to Needs work
4 months ago 2:07pm 3 September 2024 - 🇺🇸United States smustgrave
Thank you for reporting.
One of the next steps will be to get a test case added that shows the problem.
Also can the steps to reproduce section be filled out please
- First commit to issue fork.
- 🇮🇳India vinmayiswamy
Hi, I have added test cases to
EditorFileReferenceFilterTest.phpto validate the recent fix. These tests ensure that when only one dimension (width or height) is provided, the other dimension is correctly calculated to maintain the aspect ratio.Kindly review the changes and please let me know if any further adjustments are needed. Any feedback or suggestions for improvements are appreciated.
Thanks!
- Status changed to Needs review
3 months ago 8:27am 19 September 2024 - 🇮🇳India vinmayiswamy
Hi, I have updated the "Steps to Reproduce" section based on my understanding of the issue. Please review the changes and let me know if any further adjustments are needed. Thanks!
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- 🇮🇳India mrinalini9 New Delhi
Fixed phpstan and phpcs pipeline issues and updated the MR, please review it.
Thanks!
- 🇮🇳India vinmayiswamy
Hi, I've addressed the feedback. Kindly please review. Thanks!
- Status changed to RTBC
about 1 month ago 6:45pm 18 November 2024 - 🇺🇸United States smustgrave
Believe feedback has been addressed for this one.
- 🇳🇿New Zealand quietone
I tested this today on a fresh install of Drupal 11.x, using the steps in the issue summary. I was not able to reproduce the problem. Is there a step missing? Without it failing it difficult to evaluate this change. Is this problem version specific? Would this change prevent deliberate change of the aspect ratio?
I ran the test locally without the fix and it does fail. Is this only a problem when images are added programmatically?
I left some comments in the MR for a bit of cleanup.