undefined - Contrib.social

🇮🇳India vinmayiswamy

I've addressed #18 in this patch. Please review.

🐛 | Drupal core | Claro: role=button on status report items

🇮🇳India vinmayiswamy

Hi everyone,

I've attempted to rebase the MR !3731 to the 11.x branch, but unfortunately, a large number of unrelated commits also showed up in the MR. I tried to revert my changes a few times, but I couldn't fully restore it to the original state. As a result, multiple comments and commits are added here as I tried to clean things up.

I apologize for the mess. Could someone please help me restore the MR to its previous state? Any assistance to get this back on track would be greatly appreciated.

Thanks!

🐛 | Drupal core | Claro: role=button on status report items

🇮🇳India vinmayiswamy

vinmayiswamy → made their first commit to this issue’s fork.

📌 | Drupal core | move user.admin.css into seven where it belongs

🇮🇳India vinmayiswamy

Hi,
I have added deprecation to the user.admin.css library following this guide: How to Deprecate → .
I also created a Change Record → for the same.

Kindly review the changes and please let me know if any further adjustments are needed. I appreciate any feedback or suggestions for improvements.

Thanks!

📌 | Drupal core | move user.admin.css into seven where it belongs

🇮🇳India vinmayiswamy

vinmayiswamy → made their first commit to this issue’s fork.

📌 | Drupal CMS | Create community survey and collect feedback

🇮🇳India vinmayiswamy

breidert → credited vinmayiswamy → .

📌 | Drupal core | Use interface language on the add URL alias form

🇮🇳India vinmayiswamy

Hi, I have added test case to validate the path alias functionality across language switches. This test verify that the correct language is selected in the UI when creating aliases for nodes in different languages, ensuring users can easily access the aliases based on their current language.

Please review the changes, and let me know if any further adjustments are needed. I appreciate any feedback or suggestions for improvements.

Thanks!

📌 | Drupal core | Use interface language on the add URL alias form

🐛 | Drupal core | .ck-balloon-panel (link balloon, media balloon …) not visible for CKE5 instances in a Drupal dialog

🇮🇳India vinmayiswamy

vinmayiswamy → made their first commit to this issue’s fork.

🐛 | Drupal core | .ck-balloon-panel (link balloon, media balloon …) not visible for CKE5 instances in a Drupal dialog

🇮🇳India vinmayiswamy

Hi, I updated the CKEditor5DialogTest to ensure the CKEditor 5 balloon panel is properly positioned above the modal. Kindly please review the changes and let me know your suggestions.
Thanks!

🇮🇳India vinmayiswamy

vinmayiswamy → made their first commit to this issue’s fork.

🐛 | Drupal core | LibraryDiscoveryParser overwrites theme CSS group ordering

🇮🇳India vinmayiswamy

vinmayiswamy → made their first commit to this issue’s fork.

🐛 | Drupal core | Pagination not working correctly in AJAX view with exposed filters

🇮🇳India vinmayiswamy

Hi, I updated the test to cover scenarios with multiple query parameters in the request, specifically adding extra parameters like foo and q alongside the page parameter. This change ensures that pagination resets correctly when there are additional parameters in the URL, which is common in real-world cases.

Hi, I updated the test to simulate scenarios where multiple query parameters are involved in the request. Specifically, I added test cases that include extra parameters like foo and q alongside the page parameter. This was necessary because, in real-world scenarios, URLs often contain additional parameters, and I wanted to ensure that the pagination reset behaves correctly even with these variations.

I started by filtering content by title and confirming the correct result. Then, I tested the page with both foo and page parameters, applying the filter again to check that the additional parameters didn’t affect the pagination. Lastly, I included a case where both q and page parameters appear in different positions, ensuring the pagination resets as expected.

These updates help cover edge cases with query parameters, preventing issues with pagination and ensuring that the filtered content is returned correctly.

Additionally, I verified the fix in Drupal 11.x fresh install and attached before and after screenshots for reference.

Kindly review the changes and please let me know if any further adjustments are needed. Your feedback and suggestions for improvements are greatly appreciated.

Thanks!

🐛 | Drupal core | Pagination not working correctly in AJAX view with exposed filters

🇮🇳India vinmayiswamy

vinmayiswamy → made their first commit to this issue’s fork.

📌 | Drupal CMS | Create a questionnaire and gather insights for media management

🇮🇳India vinmayiswamy

tonypaulbarker → credited vinmayiswamy → .

🐛 | Drupal core | EditorFileReference should maintain the aspect ratio of image if only one of the width or height is defined in embedded code

🇮🇳India vinmayiswamy

Thank you, @antonnavi, for highlighting the incorrect usage of $target_entity_ids_list = array_keys($target_entity_ids);.

I’ve updated the code to use $target_entity_ids_list = array_values($target_entity_ids);, which correctly retrieves the entity IDs instead of revision IDs. Additionally, I've added test coverage to verify this change, ensuring that workspace associations are properly cleaned up when publishing the workspace.

Kindly review the changes and please let me know if any further adjustments are needed. Your feedback and suggestions for improvements are greatly appreciated.

Thanks!

🐛 | Drupal core | EditorFileReference should maintain the aspect ratio of image if only one of the width or height is defined in embedded code

🇮🇳India vinmayiswamy

Hi, I have updated the "Steps to Reproduce" section based on my understanding of the issue. Please review the changes and let me know if any further adjustments are needed. Thanks!

🐛 | Drupal core | EditorFileReference should maintain the aspect ratio of image if only one of the width or height is defined in embedded code

🇮🇳India vinmayiswamy

Hi, I have added test cases to EditorFileReferenceFilterTest.php to validate the recent fix. These tests ensure that when only one dimension (width or height) is provided, the other dimension is correctly calculated to maintain the aspect ratio.

Kindly review the changes and please let me know if any further adjustments are needed. Any feedback or suggestions for improvements are appreciated.

Thanks!

🇮🇳India vinmayiswamy

vinmayiswamy → made their first commit to this issue’s fork.

🐛 | Drupal core | Adding node into the Groups throwing exception - Group Nodes

🇮🇳India vinmayiswamy

Hi, I have tested the fix provided in MR !177. I followed the steps outlined in the issue summary to reproduce the issue before applying the fix and to verify the solution afterward.

Before the fix, I encountered the White Screen of Death (WSOD) with the following error message:

Drupal\Core\Entity\EntityStorageException: This entity can only be saved in the default workspace. in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 817 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

Although the node was created, it wasn’t added to the group, and the WSOD appeared with the above error logged.

After applying the fix, the issue was resolved. The WSOD no longer occurred, and the node was successfully created and added to the group within the non-default workspace.

Attaching before and after screenshots for reference.

I believe this is now good to go for RTBC!

Thanks!

📌 | Drupal core | Rename Views method render_item() to renderItem() in MultiItemsFieldHandlerInterface

🇮🇳India vinmayiswamy

📌 | Drupal core | Rename Views method render_item() to renderItem() in MultiItemsFieldHandlerInterface

🇮🇳India vinmayiswamy

🇮🇳India vinmayiswamy

Hi, I have updated the test cases to ensure that deprecation warnings are triggered by calling the deprecated methods directly, as per the feedback.

Please review the changes and let me know if any further adjustments are needed. Your feedback is appreciated.

Thanks!

🇮🇳India vinmayiswamy

Hi, I have created an MR incorporating the patch changes from comment #9 and added a test case to validate these changes as outlined in comment #11. The issue summary has been updated accordingly.

I am removing the "Needs issue summary update" and "Needs tests" tags. If anyone believes these tags should still be applied, please feel free to re-add them.

Kindly review the changes and let me know if any further adjustments or updates are needed. Your feedback and suggestions for further improvements are greatly appreciated.

Thanks!

🇮🇳India vinmayiswamy

🇮🇳India vinmayiswamy

vinmayiswamy → made their first commit to this issue’s fork.

🌱 | Melbourne Drupal Meetup | Melbourne Drupal Meetup August 2024 - Attendees

📌 | Drupal core | Rename Views method render_item() to renderItem() in MultiItemsFieldHandlerInterface

🇮🇳India vinmayiswamy

gargsuchi → credited vinmayiswamy → .

🇮🇳India vinmayiswamy

Hi, I’ve added tests to address the deprecation of the render_item() method.

Kindly review the changes and please let me know if any further modifications are required.

Thanks!

🐛 | Drupal core | Flood control on reset password form blocks IP address but not the account

🇮🇳India vinmayiswamy

Hi @avpaderno,

Thank you for your feedback.

I understand that when no error is shown for the name form element, it might imply that either the account does not exist or it has been blocked, which could potentially reveal hints about the account status.

Given this context, should we consider adjustments to the "if()" condition mentioned in comment #9 🐛 Flood control on reset password form blocks IP address but not the account Needs work , or do you recommend another approach? I’m seeking confirmation as the "if()" condition (if ($account && $account->id() && $account->isActive()) { /* */ }) was part of the existing code and not introduced by my recent changes.

Kindly please let me know how you’d like to proceed.

Thanks!

🐛 | Drupal core | Flood control on reset password form blocks IP address but not the account

🇮🇳India vinmayiswamy

🐛 | Drupal core | Flood control on reset password form blocks IP address but not the account

🇮🇳India vinmayiswamy

Hi, I’ve reproduced this issue on both Drupal 10.3.x and 11.x with PHP 8.3 and have made the proposed changes to address the issue. Here’s a summary of the updates:

Flood Control Improvement: Updated the password reset functionality to ensure that both the IP address and the user account are simultaneously blocked after exceeding the allowed number of attempts. This ensures that the account is secured regardless of the IP address used.
Error Message: As proposed, updated the error message to be more generic, enhancing security by not revealing whether the account exists.

Attaching before & after screenshots of the "Error Message" update for reference.

Due to my local environment setup, I was unable to change my IP address dynamically. Instead, I manually updated the IP address in the database to verify the behavior. The changes appear to resolve the issue as intended. However, it would be greatly appreciated if further testing could be conducted in an environment where IP changes can be performed to confirm the fix.

Kindly review the changes and let me know if any further adjustments or updates are needed.

Thanks!

🐛 | Drupal core | Flood control on reset password form blocks IP address but not the account

🐛 | Drupal core | InvalidArgumentException: The allowed types parameter is required and must be an array of strings. in Drupal\media_library\MediaLibraryState->validateRequiredParameters() (line 150 of core/modules/media_library/src/MediaLibraryState.php).

🇮🇳India vinmayiswamy

vinmayiswamy → made their first commit to this issue’s fork.

🐛 | Drupal core | strtr(): Passing null to parameter #1 ($string) of type string is deprecated in locale_translation_build_server_pattern()

🇮🇳India vinmayiswamy

Hi, I followed the steps outlined in the issue summary to reproduce this issue in Drupal 10.2.8-dev (cloned from 10.2.x), using MySQL 5.7 (as MySQL 5.8 is unsupported in DDEV for arm64 architecture. Please see the error below for reference) and PHP 8.3.

$ ddev config --database=mysql:5.8
You are reconfiguring the project at /Users/vinmayi.nidubrolu/projects/drupal102x/drupal.
The existing configuration will be updated and replaced.
Configuring a 'drupal' project named 'drupal102x' with docroot '' at '/Users/vinmayi.nidubrolu/projects/drupal102x/drupal'.
For full details use 'ddev describe'.
failed to validate config: the drupal102x project has an unsupported database type/version: 'mysql:5.8', DDEV arm64 only supports the following database types and versions: mariadb: [10.1 10.2 10.3 10.4 10.5 10.6 10.7 10.8 10.11], mysql: [5.7 8.0], postgres: [9 10 11 12 13 14 15 16]

However, I am not able to reproduce the issue.

After deleting all media types as described, I revisited the nodes created with the content type that included the media field. The nodes rendered without any issues, and there were no relevant entries in the "Recent log messages."

Additionally, I checked the same scenario in Drupal 11.x with PHP 8.3 and MariaDB 10.11, and I still couldn't reproduce the issue.

It seems that this issue may not be reproducible in my current environment. Kindly please let me know if there are any additional steps or configurations that I might have missed that could help in replicating the problem.

Thanks!

🐛 | Drupal core | Same value is shown for two different view fields when using the entity field rendering

🇮🇳India vinmayiswamy

Hi, I attempted to reproduce this issue by following the steps below:

Installed Drupal version 10.2.8-dev (cloned from 10.2.x).
PHP version 8.1.29.
Enabled the "locale" module.
Noticed that the locale.settings.yml file is not created automatically after enabling the module.
Was able to visit the /admin/config/regional/translate/settings page and save the settings form without encountering any issues.
As mentioned in previous comments (#10, #12, #13 and #14), I copied the locale.settings.yml file with the command cp core/modules/locale/config/install/locale.settings.yml sites/default/files/sync/locale.settings.yml and executed drush cim.
Revisited the /admin/config/regional/translate/settings page and saved the settings form without any issues.

I also tested the same steps in Drupal versions 10.3.2 and 11.x with PHP 8.3 and did not replicate the issue.

If there are any specific steps or additional details I might have missed, please let me know. I would greatly appreciate any guidance.

Thanks!

🐛 | Drupal core | Same value is shown for two different view fields when using the entity field rendering

🇮🇳India vinmayiswamy

Attaching screenshots for reference.

🇮🇳India vinmayiswamy

Hi, I followed the steps outlined in the issue summary but couldn't reproduce the issue. The view correctly displays the proper images for both fields.

My local setup specifications:

Drupal 11.x
PHP 8.3
Search API 8.x-1.35
Default database server for indexing
Forma

tter: Render Entity

Everything worked as expected, with no issues in image rendering. If there are any additional steps or scenarios that I may have overlooked, or if there are other aspects I should consider, I would greatly appreciate any guidance.

Thanks!

📌 | Drupal CMS | Drupal Starshot Accessibility Tools Track Survey

🐛 | Drupal core | Field options "Rewrite results" and "Link to the Content" applied together is not working as expected

🇮🇳India vinmayiswamy

the_g_bomb → credited vinmayiswamy → .