๐Ÿ‡ฎ๐Ÿ‡ณIndia @VinmayiSwamy

Account created on 4 August 2021, almost 3 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi,

Thanks for the MR. Iโ€™ve tested MR !541 on Drupal 10.3.x.
The MR applied cleanly.

Testing steps:
1. Install and enable "Project Browser" module version 2.0.x-dev.
2. Navigate to Admin > Extend > Browse.
3. Verify the appearance of the Filter Categories title in the left sidebar.

Test Result:
After applying the MR, I observed that padding-top was correctly applied to the left sidebar.

I've attached before and after screenshots for reference.

RTBC +1

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi @chaitanyadessai,
Indeed, the changes have been released in version 1.0.x. But still, the warning wasn't resolved.

I verified this in Drupal version 10.2.x. I'm still getting this Unused variable $i. warning along with other phpcs issues.

Below are the phpcs issues from the same file.

$ ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/ckeditor 

FILE: /Users/vinmayi.nidubrolu/projects/drupal102x/drupal/modules/contrib/ckeditor/tests/src/FunctionalJavascript/BigPipeRegressionTest.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
  55 | ERROR   | Public method name "BigPipeRegressionTest::testCommentForm_2698811" is not in lowerCamel format
 100 | WARNING | Unused variable $i.
-------------------------------------------------------------------------------------------------------------------------------------------

Moving back to NW.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

I see there is another issue created for phpcs for the same version here - Fix the issues reported by phpcs ๐Ÿ“Œ Fix the issues reported by phpcs Needs review .

Hence, +1 to RTBC.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi,
I applied patch entity_browser-3366693-3.patch โ†’ to the entity_browser โ†’ module against version 8.x-2.x-dev โ†’ in Drupal version 10.3.x.

The patch was applied cleanly..

$ git apply -v entity_browser-3366693-3.patch 
Checking patch entity_browser.views.inc...
Checking patch modules/entity_form/entity_browser_entity_form.module...
Checking patch src/Form/EntityBrowserEditForm.php...
Checking patch src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php...
Checking patch tests/src/FunctionalJavascript/ConfigurationTest.php...
Hunk #1 succeeded at 198 (offset -1 lines).
Checking patch tests/src/FunctionalJavascript/EntityBrowserTest.php...
Applied patch entity_browser.views.inc cleanly.
Applied patch modules/entity_form/entity_browser_entity_form.module cleanly.
Applied patch src/Form/EntityBrowserEditForm.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php cleanly.
Applied patch tests/src/FunctionalJavascript/ConfigurationTest.php cleanly.
Applied patch tests/src/FunctionalJavascript/EntityBrowserTest.php cleanly.

Test Result:
Few phpcs issues were fixed, but several errors and warnings were still present.

 ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/entity_browser

FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/modules/entity_browser_test/entity_browser_test.routing.yml
----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------
 7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
----------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/modules/entity_browser_test/src/Form/FormElementTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
 33 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/EntityBrowserWebDriverTestBase.php
----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------
   8 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\field\Entity\FieldConfig.
 254 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 288 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 313 | ERROR   | [x] Scope keyword "protected" must be followed by a single space; found 2
----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/EntityBrowserViewsWidgetTest.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldStorageDefinitionInterface.
--------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/InlineEntityFormTest.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
 418 | ERROR | [x] list(...) is forbidden, use [...] instead.
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/PluginsTest.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
 232 | WARNING | [x] 'TODO test if entities were selected. Will most likely need a custom event' should match the format '@todo Fix problem X here.'
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/EntityBrowserTest.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
  44 | WARNING | [x] '@TODO Test the edit button.' should match the format '@todo Fix problem X here.'
 183 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/EntityReferenceWidgetTest.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
 607 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/FieldWidgetConfigTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 157 | WARNING | Line exceeds 80 characters; contains 104 characters
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/CardinalityTest.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
 244 | WARNING | Line exceeds 80 characters; contains 82 characters
 322 | WARNING | Line exceeds 80 characters; contains 82 characters
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/Functional/EntityBrowserUITest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 37 | ERROR | Public method name "EntityBrowserUITest::testEntityBrowserUI" is not in lowerCamel format
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/Functional/FormElementTest.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 73 | ERROR | The array declaration extends to column 151 (the limit is 120). The array content should be split up over multiple lines
 73 | ERROR | The array declaration extends to column 150 (the limit is 120). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/entity_browser.api.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------------
 14 | WARNING | Line exceeds 80 characters; contains 92 characters
 24 | WARNING | Line exceeds 80 characters; contains 91 characters
 34 | WARNING | Line exceeds 80 characters; contains 88 characters
 44 | WARNING | Line exceeds 80 characters; contains 99 characters
 54 | WARNING | Line exceeds 80 characters; contains 103 characters
 65 | WARNING | Line exceeds 80 characters; contains 101 characters
---------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/modules/entity_form/entity_browser_entity_form.module
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
  11 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldDefinitionInterface.
  32 | WARNING | [x] 'TODO - 'default' might become configurable or something else in the future.' should match the format '@todo Fix problem X here.'
  83 | WARNING | [x] 'TODO see if we can get away without overriding entire IEF function.' should match the format '@todo Fix problem X here.'
 121 | WARNING | [x] 'TODO see if we can get away without overriding entire IEF function.' should match the format '@todo Fix problem X here.'
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/modules/entity_form/src/Plugin/EntityBrowser/Widget/EntityForm.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------
  16 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityDisplayRepositoryInterface.
 155 | ERROR | [ ] The array declaration extends to column 147 (the limit is 120). The array content should be split up over multiple lines
 156 | ERROR | [ ] The array declaration extends to column 166 (the limit is 120). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/entity_browser.module
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
  15 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
  81 | ERROR | [ ] The array declaration extends to column 198 (the limit is 120). The array content should be split up over multiple lines
 148 | ERROR | [x] list(...) is forbidden, use [...] instead.
 166 | ERROR | [x] list(...) is forbidden, use [...] instead.
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Form/EntityBrowserEditForm.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------
 12 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\SubformState.
 17 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Form/EntityBrowserForm.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 16 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Render\RendererInterface.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/WidgetBase.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------
   9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
 332 | ERROR | [ ] Parameter $form_state is not described in comment
 359 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Entity/EntityBrowser.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------
 323 | WARNING | [x] 'TODO - this doesn't make much sense. Refactor.' should match the format '@todo Fix problem X here.'
 332 | WARNING | [x] 'TODO - this doesn't make much sense. Refactor.' should match the format '@todo Fix problem X here.'
 386 | WARNING | [x] 'TODO: Allow displays to define more than just path.' should match the format '@todo Fix problem X here.'
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/WidgetInterface.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 78 | WARNING | Line exceeds 80 characters; contains 83 characters
----------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/DisplayInterface.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
 880 | WARNING | [x] 'TODO Figure out how to avoid using raw user input.' should match the format '@todo Fix problem X here.'
------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/FileBrowserWidget.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
 304 | ERROR | [ ] The array declaration extends to column 133 (the limit is 120). The array content should be split up over multiple lines
 439 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 445 | ERROR | [ ] The array declaration extends to column 129 (the limit is 120). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/Widget/Upload.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  65 | ERROR   | The array declaration extends to column 177 (the limit is 120). The array content should be split up over multiple lines
 120 | WARNING | Line exceeds 80 characters; contains 81 characters
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/Widget/View.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------
  67 | WARNING | [x] 'TODO - do we need better error handling for view and view_display (in' should match the format '@todo Fix problem X here.'
  82 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 108 | ERROR   | [ ] The array declaration extends to column 149 (the limit is 120). The array content should be split up over multiple lines
 109 | ERROR   | [ ] The array declaration extends to column 130 (the limit is 120). The array content should be split up over multiple lines
 110 | ERROR   | [ ] The array declaration extends to column 127 (the limit is 120). The array content should be split up over multiple lines
 236 | ERROR   | [ ] The array declaration extends to column 170 (the limit is 120). The array content should be split up over multiple lines
 271 | WARNING | [ ] ViewEntity::load calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/FieldWidgetDisplay/RenderedEntity.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
 58 | ERROR | [x] Expected 1 space after "?"; 2 found
 59 | ERROR | [x] Expected 1 space after ":"; 2 found
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/FieldWidgetDisplay/ImageThumbnail.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
 53 | ERROR | [x] Expected 1 space after "?"; 2 found
 54 | ERROR | [x] Expected 1 space after ":"; 2 found
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/WidgetSelector/Tabs.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/WidgetSelector/DropDown.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/WidgetSelector/Single.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/SelectionDisplay/View.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
   9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views\Entity\View.
  41 | WARNING | [x] 'TODO - do we need better error handling for view and view_display' should match the format '@todo Fix problem X here.'
  52 | WARNING | [x] 'TODO - if there are entities that are selected multiple times this' should match the format '@todo Fix problem X here.'
  93 | ERROR   | [ ] The array declaration extends to column 146 (the limit is 120). The array content should be split up over multiple lines
 116 | ERROR   | [x] list(...) is forbidden, use [...] instead.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/Display/Modal.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Ajax\AjaxResponse.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/Display/Standalone.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------
  7 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
 48 | WARNING | [ ] Possible useless method overriding detected
 50 | WARNING | [x] '@TODO Implement it.' should match the format '@todo Fix problem X here.'
 57 | WARNING | [x] '@TODO Implement it.' should match the format '@todo Fix problem X here.'
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/views/display/EntityBrowser.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 133 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Element/EntityBrowserElement.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
   9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
 257 | ERROR | [x] list(...) is forbidden, use [...] instead.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/SelectionDisplayBase.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
 133 | ERROR | [ ] The trigger_error message 'checkPreselectionSupport method is deprecated. Use supportsPreselection instead.' does not match the relaxed standard format: %thing% is deprecated in
     |       |     %deprecation-version% any free text %removal-version%. %extra-info%. See %cr-link%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/SelectionDisplayInterface.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 69 | ERROR | The text '@deprecated Use ::supportsPreselection instead.' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%.
 69 | ERROR | Each @deprecated tag must have a @see tag immediately following it
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/EntityBrowserInterface.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------
 53 | ERROR | Parameter $widget_selector is not described in comment
 56 | ERROR | Doc comment for parameter $display does not match actual variable name $widget_selector
 64 | ERROR | Parameter $selection_display is not described in comment
 67 | ERROR | Doc comment for parameter $display does not match actual variable name $selection_display
-----------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/WidgetSelectorBase.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------
  7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
 28 | ERROR | [ ] Class property $widget_ids should use lowerCamel naming without underscores
 43 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Events/Events.php
--------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------------------------------------------
 12 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 19 | WARNING | Line exceeds 80 characters; contains 82 characters
 20 | WARNING | Line exceeds 80 characters; contains 85 characters
 20 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 27 | WARNING | Line exceeds 80 characters; contains 82 characters
 29 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 36 | WARNING | Line exceeds 80 characters; contains 81 characters
 37 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
--------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Events/EventBase.php
-----------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------
 45 | ERROR | Public method name "EventBase::getBrowserID" is not in lowerCamel format
 55 | ERROR | Public method name "EventBase::getBrowserInstanceUUID" is not in lowerCamel format
-----------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Events/EntitySelectionEvent.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 35 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Controllers/EntityBrowserFormController.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------
 107 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 109 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Controllers/EntityBrowserListBuilder.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 33 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Controllers/EntityBrowserController.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 77 | ERROR | The array declaration extends to column 237 (the limit is 120). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/RouteSubscriber.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------
 50 | WARNING | [x] The variable name should be defined after the type
 66 | ERROR   | [ ] Protected method name "RouteSubscriber::getBrowserIDsWithRoute" is not in lowerCamel format
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Ajax/SelectEntitiesCommand.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
---------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Ajax/ValueUpdatedCommand.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | Class property $details_id should use lowerCamel naming without underscores
-------------------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/DisplayBase.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContainerFactoryPluginInterface.
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

Time: 1.96 secs; Memory: 20MB

Moving to NW.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Thank you @nishtha.pradhan, for your MR and for addressing the documentation for TablesInterface::addField() in Drupal core.

I've reviewed the changes provided in Drupal version 11.x. To enhance clarity, I suggest explicitly stating in the documentation that dot notation (.) can be used to specify fields involving relationships. This is consistent with practices observed in tests such as EntityQueryRelationshipTest.

For example:

/**
 * Adds a field to a database query.
 *
 * @param string $field
 *   The field to add to the query. Use dot notation to specify fields from
 *   related entities, e.g., "entity.field" or "entity:referenced_entity.field".
 *   Delta can be a numeric value or a "%delta" for any value.
 *   
 *   See {@link https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Entity!Query!QueryInterface.php/function/QueryInterface%3A%3Acondition/8.9.x QueryInterface::condition()} for more details.
 * @param string $type
 *   Join type, can either be INNER or LEFT.
 * @param string $langcode
 *   The language code to use for multilingual queries.
 *
 * @return string
 *   The return value is a string containing the alias of the table, a dot
 *   and the appropriate SQL column as passed in. This allows the direct use
 *   of this in a query for a condition or sort.
 *
 * @throws \Drupal\Core\Entity\Query\QueryException
 *   If $field specifies an invalid relationship.
 */
public function addField($field, $type = 'INNER', $langcode = NULL);

I would appreciate feedback from others on this proposed change. Does this approach align with the understanding of how fields should be specified in Drupal queries? Are there any additional considerations we should take into account?

Your thoughts and suggestions would be valuable.

Thank you!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

VinmayiSwamy โ†’ changed the visibility of the branch 1.0.x to active.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

VinmayiSwamy โ†’ changed the visibility of the branch 1.0.x to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi,

I applied MR!4 to the ui_styles_paragraphs module against version ui_styles_paragraphs 1.1.x-dev in Drupal 10.2.x and confirmed that the errors and warnings reported by phpcs are resolved. Please see the screenshots attached.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

I have tested MR !53 in Drupal version 10.2.x, and confirmed it fixes all the errors reported by phpcs. But we still have a few warnings in the /src/Controller/MigrationController.php file.

FILE: /Users/vins/projects/drupal102x/drupal/modules/contrib/migrate_tools/src/Controller/MigrationController.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------
 12 | WARNING | [x] Unused use statement
 13 | WARNING | [x] Unused use statement
 17 | WARNING | [x] Unused use statement
 19 | WARNING | [x] Unused use statement
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

Time: 727ms; Memory: 20MB

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi,
I'm also unable to reproduce this issue in the local environment, but I'm able to check it out on GitPod.
I tested patch 3456978.patch โ†’ in Drupal version 10.3.1-dev on GitPod. Furthermore, I can confirm that the cursor has changed to a pointer when I hover my cursor over the results tab.

Attaching screenshots for reference.

RTBC +1

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi @nilesh.addweb,
Thanks for the guidance. Moving to RTBC.
Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi @nilesh.addweb,
I reviewed MR!33 in Drupal 10.2.x and 11.x and confirmed it fixes all the errors and warnings reported by phpcs.
Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi Silvi Sanghavi โ†’ , thanks for the patch.

I've tested coffee-3322818-5.patch โ†’ on Drupal 10.2.x
The patch is applied Cleanly...

Test Result:
The phpcs issues were fixed after the updated changes.

RTBC+1

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi, I've verified MR 8539 in Drupal 11.x.
The change aligns with the requirement outlined in the issue and works as expected.
Since the code quality hasn't changed, +1 to RTBC.
Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi @narendraR,

Thanks for the MR. Iโ€™ve tested MR 8477 on Drupal 11.x.
The MR applied cleanly.

Testing steps:
1. Get a local git clone of Drupal core 11.x.
2. composer require drupal/config_inspector 
3. composer require drush/drush
4. Run drush config:inspect --filter-keys=search.page.user_search --detail --list-constraints

Test Result:
Search page config entity is fully validated after the changes.

The below are before and after inspections of the search page configuration:

Before:

---------------------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------------------- 
  Key                                                  Status    Validatable   Data   Validation constraints                                                                       
 ---------------------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------------------- 
  search.page.user_search                              Correct   80%           โœ…โ“   ValidKeys: '<infer>'                                                                         
   search.page.user_search:                            Correct   Validatable   โœ…โœ…   ValidKeys: '<infer>'                                                                         
   search.page.user_search:_core                       Correct   Validatable   โœ…โœ…   ValidKeys:                                                                                   
                                                                                        - default_config_hash                                                                      
   search.page.user_search:_core.default_config_hash   Correct   Validatable   โœ…โœ…   NotNull: {  }                                                                                
                                                                                      Regex: '/^[a-zA-Z0-9\-_]+$/'                                                                 
                                                                                      Length: 43                                                                                   
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
   search.page.user_search:configuration               Correct   NOT           โœ…โ“   โŒ @todo Add validation constraints to ancestor type: search.plugin.user_search              
   search.page.user_search:dependencies                Correct   Validatable   โœ…โœ…   ValidKeys: '<infer>'                                                                         
   search.page.user_search:dependencies.module         Correct   NOT           โœ…โ“   โŒ @todo Add validation constraints to ancestor type: config_dependencies                    
   search.page.user_search:dependencies.module.0       Correct   Validatable   โœ…โœ…   NotBlank: {  }                                                                               
                                                                                      ExtensionName: {  }                                                                          
                                                                                      ExtensionExists: module                                                                      
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
   search.page.user_search:id                          Correct   Validatable   โœ…โœ…   Regex:                                                                                       
                                                                                        pattern: '/^[a-z0-9_]+$/'                                                                  
                                                                                        message: 'The %value machine name is not valid.'                                           
                                                                                      Length:                                                                                      
                                                                                        max: 166                                                                                   
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
   search.page.user_search:label                       Correct   Validatable   โœ…โœ…   Regex:                                                                                       
                                                                                        pattern: '/([^\PC])/u'                                                                     
                                                                                        match: false                                                                               
                                                                                        message: 'Labels are not allowed to span multiple lines or contain control characters.'    
                                                                                      NotBlank: {  }                                                                               
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
   search.page.user_search:langcode                    Correct   Validatable   โœ…โœ…   NotNull: {  }                                                                                
                                                                                      Choice:                                                                                      
                                                                                        callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllValidLangcodes'  
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
   search.page.user_search:path                        Correct   NOT           โœ…โ“   โš ๏ธ  @todo Add validation constraints to config entity type: search.page.*                    
   search.page.user_search:plugin                      Correct   Validatable   โœ…โœ…   PluginExists:                                                                                
                                                                                        manager: plugin.manager.search                                                             
                                                                                        interface: Drupal\search\Plugin\SearchInterface                                            
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
   search.page.user_search:status                      Correct   Validatable   โœ…โœ…   โ†ฃ PrimitiveType: {  }                                                                        
   search.page.user_search:uuid                        Correct   Validatable   โœ…โœ…   Uuid: {  }                                                                                   
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
   search.page.user_search:weight                      Correct   Validatable   โœ…โœ…   Range:                                                                                       
                                                                                        min: -2147483648                                                                           
                                                                                        max: 2147483647                                                                            
                                                                                      FullyValidatable: null                                                                       
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
 ---------------------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------------------- 

After:

---------------------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------------------- 
  Key                                                  Status    Validatable   Data   Validation constraints                                                                       
 ---------------------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------------------- 
  search.page.user_search                              Correct   100%          โœ…โœ…   ValidKeys: '<infer>'                                                                         
                                                                                      FullyValidatable: null                                                                       
   search.page.user_search:                            Correct   Validatable   โœ…โœ…   ValidKeys: '<infer>'                                                                         
                                                                                      FullyValidatable: null                                                                       
   search.page.user_search:_core                       Correct   Validatable   โœ…โœ…   ValidKeys:                                                                                   
                                                                                        - default_config_hash                                                                      
                                                                                      โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:_core.default_config_hash   Correct   Validatable   โœ…โœ…   NotNull: {  }                                                                                
                                                                                      Regex: '/^[a-zA-Z0-9\-_]+$/'                                                                 
                                                                                      Length: 43                                                                                   
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
   search.page.user_search:configuration               Correct   Validatable   โœ…โœ…   โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:dependencies                Correct   Validatable   โœ…โœ…   ValidKeys: '<infer>'                                                                         
                                                                                      โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:dependencies.module         Correct   Validatable   โœ…โœ…   โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:dependencies.module.0       Correct   Validatable   โœ…โœ…   NotBlank: {  }                                                                               
                                                                                      ExtensionName: {  }                                                                          
                                                                                      ExtensionExists: module                                                                      
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
                                                                                      โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:id                          Correct   Validatable   โœ…โœ…   Regex:                                                                                       
                                                                                        pattern: '/^[a-z0-9_]+$/'                                                                  
                                                                                        message: 'The %value machine name is not valid.'                                           
                                                                                      Length:                                                                                      
                                                                                        max: 166                                                                                   
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
                                                                                      โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:label                       Correct   Validatable   โœ…โœ…   Regex:                                                                                       
                                                                                        pattern: '/([^\PC])/u'                                                                     
                                                                                        match: false                                                                               
                                                                                        message: 'Labels are not allowed to span multiple lines or contain control characters.'    
                                                                                      NotBlank: {  }                                                                               
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
                                                                                      โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:langcode                    Correct   Validatable   โœ…โœ…   NotNull: {  }                                                                                
                                                                                      Choice:                                                                                      
                                                                                        callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllValidLangcodes'  
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
   search.page.user_search:path                        Correct   Validatable   โœ…โœ…   NotBlank: {  }                                                                               
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
                                                                                      โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:plugin                      Correct   Validatable   โœ…โœ…   PluginExists:                                                                                
                                                                                        manager: plugin.manager.search                                                             
                                                                                        interface: Drupal\search\Plugin\SearchInterface                                            
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
                                                                                      โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:status                      Correct   Validatable   โœ…โœ…   โ†ฃ PrimitiveType: {  }                                                                        
                                                                                      โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:uuid                        Correct   Validatable   โœ…โœ…   Uuid: {  }                                                                                   
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
                                                                                      โ†ฃ NotNull: {  }                                                                              
   search.page.user_search:weight                      Correct   Validatable   โœ…โœ…   Range:                                                                                       
                                                                                        min: -2147483648                                                                           
                                                                                        max: 2147483647                                                                            
                                                                                      FullyValidatable: null                                                                       
                                                                                      โ†ฃ PrimitiveType: {  }                                                                        
                                                                                      โ†ฃ NotNull: {  }                                                                              
 ---------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hey @anoopjohn,
It's a fantastic idea! Simplifying the user interface will make navigation more intuitive and enhance the user experience significantly. Count me inโ€”I'm excited to contribute and help bring this to completion. I'm eager to lend a hand, but I could use some guidance on how to get started. Looking forward to collaborating with you all to make this happen!
Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi, Iโ€™ve tested MR 7897 on Drupal 11.x.
The MR applied cleanly.

Testing steps:
1. Enable the Navigation module.
2. Goto the moduleโ€™s settings page.
3. Choose a custom logo from the logo options.
4. Upload a small logo.
5. Check the horizontal alignment of the logo in the collapsed toolbar state.

Test Result:
The logo position has been centered after the MR changes.

Attaching screenshots for reference.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Leaving this issue unassigned, as mentioned in the Issue etiquette โ†’
It says we should avoid assigning tickets to ourselves unless you're a maintainer.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi @silvi.addweb, thanks for the MR.

I've tested MR !4 on Drupal 10.2.x
The MR is applied Cleanly...

Test Result:
The phpcs issues were fixed after the updated changes.

RTBC+1

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi,
I've reviewed the MR !17 on Drupal 10.2.
MR applied cleanly but there's a trailing whitespace warning.

17.diff:227: trailing whitespace.
              
Checking patch .gitlab-ci.yml...
Checking patch assets/css/style.css...
Checking patch templates/layout/page.html.twig...
Checking patch templates/node--teaser.html.twig...
Applied patch .gitlab-ci.yml cleanly.
Applied patch assets/css/style.css cleanly.
Applied patch templates/layout/page.html.twig cleanly.
Applied patch templates/node--teaser.html.twig cleanly.
warning: 1 line adds whitespace errors.

Testing steps:

  • Installed & enabled "Dark Responsive" theme.
  • Cleared cache.
  • Verified "Breadcrumb" block placed in block layout.
  • Checked breadcrumb in the node.

Testing Result: The breadcrumb visibility issue is fixed and it looks good. The bullet point issue before the breadcrumb is also resolved.

Attached the screenshots for reference.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi @ silvi.addweb โ†’ ,

I reviewed your changes and the changes are updated as suggested in #15 ๐Ÿ“Œ Change README.txt to README.md and update contents Needs review .

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi @wisemike
Could you please add more details steps/ SS for the issue

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

@quietone, as previously discussed, I have created a MR (merge request !8313) to address the instances of โ€˜folderโ€™ and โ€˜foldersโ€™ that are only in comments with no associated code. Kindly please review this MR.

For the next steps, I have identified 149 mentions in 22 files of โ€œfolderโ€ or โ€œfoldersโ€ in the core that are associated with code. I will be investigating these instances further to understand the context and determine the best course of action.

One area that requires special attention is the InstallStorage class, which uses both โ€˜directoryโ€™ and โ€˜folderโ€™, as well as the presence of the class property $folders, $directory, and the method getAllFolders(). I will conduct a thorough investigation to understand why both terms are used and plan the changes accordingly, keeping in mind the need for deprecation for changing method names and class properties.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

@quietone, thank you for your detailed response and guidance. Iโ€™ve read the issue scope guidelines and it has provided me with a clearer understanding of how to proceed.

I agree with your suggestion to separate the changes into different categories. For the instances of โ€˜folderโ€™ that are only in comments with no associated code, I will start by creating a MR to address these.

For the user-facing strings, if any, I will investigate further and if necessary, create a separate child issue as you suggested.

Regarding the InstallStorage class, I understand the complexity due to the use of both โ€˜directoryโ€™ and โ€˜folderโ€™, as well as the presence of the class property $folders, $directory, and the method getAllFolders(). I will conduct a thorough investigation to understand why both terms are used and plan the changes accordingly, keeping in mind the need for deprecation for changing method names and class properties.

Lastly, to prevent the future use of โ€˜foldersโ€™, I believe updating the Drupal coding standards documentation and educating contributors could be effective. Iโ€™m open to suggestions on this.

Thank you again for your guidance. I will proceed with these steps and keep the issue updated.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

In Drupal 11.x., there are 104 mentions of folder/folders in 50 core files (excluding variable names). Is it better to create a mega MR with all the changes at once or with smaller MRs with a batch of filesโ€™ changes?

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Created MR with the proposed changes. Please review.
Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

VinmayiSwamy โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

VinmayiSwamy โ†’ changed the visibility of the branch 3444344-claro-dropdown-menu to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Observed that the autocomplete values are overlapping on scroll.
Created new patch to decrease z-index to 500.

Attached screenshots for reference

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Applied z-index:1000 in the below patch.

Please test in 10.2.x

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hey @kanchan-bhogade,
Updated the reproduce steps and screenshots.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Please review the above patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Attaching the patch to update the modal dialog height

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

VinmayiSwamy โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

VinmayiSwamy โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

VinmayiSwamy โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Verified and tested patch #5 in Drupal 10.1.x.โ€จโ€จ

Patch applied successfully.

Test Result :-
1. New scheme name reflected on save after applying the patch.
2. Status message also displayed after configuration save. โ€จ

Adding screenshot and interdiff for reference.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Hi @MukhtarM,
This issue is a possible duplicate of TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in count() (line 40 of web/modules/contrib/tac_lite/src/Form/SchemeForm.php) ๐Ÿ› TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in count() (line 40 of web/modules/contrib/tac_lite/src/Form/SchemeForm.php) Needs review

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Verified and tested patch #2 in Drupal 10.1.x.โ€จโ€จ

Patch applied successfully.

Testing steps :-โ€จ
1. Go to Drupal 10.1.x fresh installation.โ€จ
2. Install & enable Taxonomy Access Control Lite module.โ€จ
3. Apply the patch #2.โ€จ
4. Clear cache.โ€จ
5. Go to /admin/config/people/tac_lite and create a new schema by increasing the Number of Schemas.
6. Go to the the Scheme <number> tab and give it a name and save it.

Result :- 
1. New scheme name reflected on save after applying the patch.
2. Observed that flushing all the caches on submitting the scheme to make the changes in effect is also effecting to the status message. Please observe the attached before_patch and after_patch screenshots. We can see the status message on scheme save in before_patch screenshot but not in after_patch screenshot. โ€จ

Adding screenshots for reference.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Verified and tested patch #2 in Drupal 10.1.x.โ€จโ€จ
Patch applied successfully.

Testing steps :-โ€จ
1. Go to Drupal 10.1.x fresh installation.โ€จ
2. Install & enable Taxonomy Access Control Lite module.โ€จ
3. Apply the patch #2.โ€จ
4. Clear cache.โ€จ
5. Access the Help page in /admin/help/tac_lite

Result :- Able to access the Help page in /admin/help/tac_lite after applying the patch.โ€จ

Adding screenshots for reference.

๐Ÿ‡ฎ๐Ÿ‡ณIndia VinmayiSwamy

Verified and tested patch #2 in Drupal 10.1.x.โ€จ
Patch applied successfully.

Testing steps :-
1. Go to Drupal 10.1.x fresh installation.โ€จ
2. Install & enable Taxonomy Access Control Lite module.โ€จ
3. Apply the patch #2.
4. Clear cache.
5. Access the scheme1 tab in /admin/config/people/tac_lite without saving any settings.

Result :- Able to access the scheme1 tab in /admin/config/people/tac_lite without saving any settings after applying the patch.โ€จ

Adding screenshots for reference.

Production build 0.69.0 2024