Hi @narendraR,
Thanks for the MR. I’ve tested MR 8477 on Drupal 11.x.
The MR applied cleanly.
Testing steps:
1. Get a local git clone of Drupal core 11.x.
2. composer require drupal/config_inspector
3. composer require drush/drush
4. Run drush config:inspect --filter-keys=search.page.user_search --detail --list-constraints
Test Result:
Search page config entity is fully validated after the changes.
The below are before and after inspections of the search page configuration:
Before:
---------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------
Key Status Validatable Data Validation constraints
---------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------
search.page.user_search Correct 80% ✅❓ ValidKeys: '<infer>'
search.page.user_search: Correct Validatable ✅✅ ValidKeys: '<infer>'
search.page.user_search:_core Correct Validatable ✅✅ ValidKeys:
- default_config_hash
search.page.user_search:_core.default_config_hash Correct Validatable ✅✅ NotNull: { }
Regex: '/^[a-zA-Z0-9\-_]+$/'
Length: 43
↣ PrimitiveType: { }
search.page.user_search:configuration Correct NOT ✅❓ ❌ @todo Add validation constraints to ancestor type: search.plugin.user_search
search.page.user_search:dependencies Correct Validatable ✅✅ ValidKeys: '<infer>'
search.page.user_search:dependencies.module Correct NOT ✅❓ ❌ @todo Add validation constraints to ancestor type: config_dependencies
search.page.user_search:dependencies.module.0 Correct Validatable ✅✅ NotBlank: { }
ExtensionName: { }
ExtensionExists: module
↣ PrimitiveType: { }
search.page.user_search:id Correct Validatable ✅✅ Regex:
pattern: '/^[a-z0-9_]+$/'
message: 'The %value machine name is not valid.'
Length:
max: 166
↣ PrimitiveType: { }
search.page.user_search:label Correct Validatable ✅✅ Regex:
pattern: '/([^\PC])/u'
match: false
message: 'Labels are not allowed to span multiple lines or contain control characters.'
NotBlank: { }
↣ PrimitiveType: { }
search.page.user_search:langcode Correct Validatable ✅✅ NotNull: { }
Choice:
callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllValidLangcodes'
↣ PrimitiveType: { }
search.page.user_search:path Correct NOT ✅❓ ⚠️ @todo Add validation constraints to config entity type: search.page.*
search.page.user_search:plugin Correct Validatable ✅✅ PluginExists:
manager: plugin.manager.search
interface: Drupal\search\Plugin\SearchInterface
↣ PrimitiveType: { }
search.page.user_search:status Correct Validatable ✅✅ ↣ PrimitiveType: { }
search.page.user_search:uuid Correct Validatable ✅✅ Uuid: { }
↣ PrimitiveType: { }
search.page.user_search:weight Correct Validatable ✅✅ Range:
min: -2147483648
max: 2147483647
FullyValidatable: null
↣ PrimitiveType: { }
---------------------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------------------- After:
---------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------
Key Status Validatable Data Validation constraints
---------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------
search.page.user_search Correct 100% ✅✅ ValidKeys: '<infer>'
FullyValidatable: null
search.page.user_search: Correct Validatable ✅✅ ValidKeys: '<infer>'
FullyValidatable: null
search.page.user_search:_core Correct Validatable ✅✅ ValidKeys:
- default_config_hash
↣ NotNull: { }
search.page.user_search:_core.default_config_hash Correct Validatable ✅✅ NotNull: { }
Regex: '/^[a-zA-Z0-9\-_]+$/'
Length: 43
↣ PrimitiveType: { }
search.page.user_search:configuration Correct Validatable ✅✅ ↣ NotNull: { }
search.page.user_search:dependencies Correct Validatable ✅✅ ValidKeys: '<infer>'
↣ NotNull: { }
search.page.user_search:dependencies.module Correct Validatable ✅✅ ↣ NotNull: { }
search.page.user_search:dependencies.module.0 Correct Validatable ✅✅ NotBlank: { }
ExtensionName: { }
ExtensionExists: module
↣ PrimitiveType: { }
↣ NotNull: { }
search.page.user_search:id Correct Validatable ✅✅ Regex:
pattern: '/^[a-z0-9_]+$/'
message: 'The %value machine name is not valid.'
Length:
max: 166
↣ PrimitiveType: { }
↣ NotNull: { }
search.page.user_search:label Correct Validatable ✅✅ Regex:
pattern: '/([^\PC])/u'
match: false
message: 'Labels are not allowed to span multiple lines or contain control characters.'
NotBlank: { }
↣ PrimitiveType: { }
↣ NotNull: { }
search.page.user_search:langcode Correct Validatable ✅✅ NotNull: { }
Choice:
callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllValidLangcodes'
↣ PrimitiveType: { }
search.page.user_search:path Correct Validatable ✅✅ NotBlank: { }
↣ PrimitiveType: { }
↣ NotNull: { }
search.page.user_search:plugin Correct Validatable ✅✅ PluginExists:
manager: plugin.manager.search
interface: Drupal\search\Plugin\SearchInterface
↣ PrimitiveType: { }
↣ NotNull: { }
search.page.user_search:status Correct Validatable ✅✅ ↣ PrimitiveType: { }
↣ NotNull: { }
search.page.user_search:uuid Correct Validatable ✅✅ Uuid: { }
↣ PrimitiveType: { }
↣ NotNull: { }
search.page.user_search:weight Correct Validatable ✅✅ Range:
min: -2147483648
max: 2147483647
FullyValidatable: null
↣ PrimitiveType: { }
↣ NotNull: { }
---------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------Thanks!
Hey @anoopjohn,
It's a fantastic idea! Simplifying the user interface will make navigation more intuitive and enhance the user experience significantly. Count me in—I'm excited to contribute and help bring this to completion. I'm eager to lend a hand, but I could use some guidance on how to get started. Looking forward to collaborating with you all to make this happen!
Thanks!
Hi, I’ve tested MR 7897 on Drupal 11.x.
The MR applied cleanly.
Testing steps:
1. Enable the Navigation module.
2. Goto the module’s settings page.
3. Choose a custom logo from the logo options.
4. Upload a small logo.
5. Check the horizontal alignment of the logo in the collapsed toolbar state.
Test Result:
The logo position has been centered after the MR changes.
Attaching screenshots for reference.
Thanks!
Leaving this issue unassigned, as mentioned in the
Issue etiquette →
It says we should avoid assigning tickets to ourselves unless you're a maintainer.
Thanks!
Hi @silvi.addweb, thanks for the MR.
I've tested MR !4 on Drupal 10.2.x
The MR is applied Cleanly...
Test Result:
The phpcs issues were fixed after the updated changes.
RTBC+1
Hi,
I've reviewed the MR !17 on Drupal 10.2.
MR applied cleanly but there's a trailing whitespace warning.
17.diff:227: trailing whitespace.
Checking patch .gitlab-ci.yml...
Checking patch assets/css/style.css...
Checking patch templates/layout/page.html.twig...
Checking patch templates/node--teaser.html.twig...
Applied patch .gitlab-ci.yml cleanly.
Applied patch assets/css/style.css cleanly.
Applied patch templates/layout/page.html.twig cleanly.
Applied patch templates/node--teaser.html.twig cleanly.
warning: 1 line adds whitespace errors.Testing steps:
- Installed & enabled "Dark Responsive" theme.
- Cleared cache.
- Verified "Breadcrumb" block placed in block layout.
- Checked breadcrumb in the node.
Testing Result: The breadcrumb visibility issue is fixed and it looks good. The bullet point issue before the breadcrumb is also resolved.
Attached the screenshots for reference.
Thanks!
Hi @ silvi.addweb → ,
I reviewed your changes and the changes are updated as suggested in #15 📌 Change README.txt to README.md and update contents Needs review .
Thanks!
Hi @wisemike
Could you please add more details steps/ SS for the issue
Thanks!
@quietone, as previously discussed, I have created a MR (merge request !8313) to address the instances of ‘folder’ and ‘folders’ that are only in comments with no associated code. Kindly please review this MR.
For the next steps, I have identified 149 mentions in 22 files of “folder” or “folders” in the core that are associated with code. I will be investigating these instances further to understand the context and determine the best course of action.
One area that requires special attention is the InstallStorage class, which uses both ‘directory’ and ‘folder’, as well as the presence of the class property $folders, $directory, and the method getAllFolders(). I will conduct a thorough investigation to understand why both terms are used and plan the changes accordingly, keeping in mind the need for deprecation for changing method names and class properties.
Thanks!
@quietone, thank you for your detailed response and guidance. I’ve read the issue scope guidelines and it has provided me with a clearer understanding of how to proceed.
I agree with your suggestion to separate the changes into different categories. For the instances of ‘folder’ that are only in comments with no associated code, I will start by creating a MR to address these.
For the user-facing strings, if any, I will investigate further and if necessary, create a separate child issue as you suggested.
Regarding the InstallStorage class, I understand the complexity due to the use of both ‘directory’ and ‘folder’, as well as the presence of the class property $folders, $directory, and the method getAllFolders(). I will conduct a thorough investigation to understand why both terms are used and plan the changes accordingly, keeping in mind the need for deprecation for changing method names and class properties.
Lastly, to prevent the future use of ‘folders’, I believe updating the Drupal coding standards documentation and educating contributors could be effective. I’m open to suggestions on this.
Thank you again for your guidance. I will proceed with these steps and keep the issue updated.
In Drupal 11.x., there are 104 mentions of folder/folders in 50 core files (excluding variable names). Is it better to create a mega MR with all the changes at once or with smaller MRs with a batch of files’ changes?
Created MR with the proposed changes. Please review.
Thanks!
VinmayiSwamy → made their first commit to this issue’s fork.
VinmayiSwamy → changed the visibility of the branch 3444344-claro-dropdown-menu to hidden.
Observed that the autocomplete values are overlapping on scroll.
Created new patch to decrease z-index to 500.
Attached screenshots for reference
Thanks!
Applied z-index:1000 in the below patch.
Please test in 10.2.x
Thanks!
VinmayiSwamy → created an issue.
Hey @kanchan-bhogade,
Updated the reproduce steps and screenshots.
Thanks!
Please review the above patch
Attaching the patch to update the modal dialog height
VinmayiSwamy → created an issue.
VinmayiSwamy → made their first commit to this issue’s fork.
VinmayiSwamy → made their first commit to this issue’s fork.
VinmayiSwamy → made their first commit to this issue’s fork.
Moving to RTBC.
Verified and tested patch #5 in Drupal 10.1.x.
Patch applied successfully.
Test Result :-
1. New scheme name reflected on save after applying the patch.
2. Status message also displayed after configuration save.
Adding screenshot and interdiff for reference.
Hi @MukhtarM,
This issue is a possible duplicate of
TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in count() (line 40 of web/modules/contrib/tac_lite/src/Form/SchemeForm.php)
🐛
TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in count() (line 40 of web/modules/contrib/tac_lite/src/Form/SchemeForm.php)
Needs review
Moving to Needs work.
Verified and tested patch #2 in Drupal 10.1.x.
Patch applied successfully.
Testing steps :-
1. Go to Drupal 10.1.x fresh installation.
2. Install & enable Taxonomy Access Control Lite module.
3. Apply the patch #2.
4. Clear cache.
5. Go to /admin/config/people/tac_lite and create a new schema by increasing the Number of Schemas.
6. Go to the the Scheme <number> tab and give it a name and save it.
Result :-
1. New scheme name reflected on save after applying the patch.
2. Observed that flushing all the caches on submitting the scheme to make the changes in effect is also effecting to the status message. Please observe the attached before_patch and after_patch screenshots. We can see the status message on scheme save in before_patch screenshot but not in after_patch screenshot.
Adding screenshots for reference.
+1 RTBC
Verified and tested patch #2 in Drupal 10.1.x.
Patch applied successfully.
Testing steps :-
1. Go to Drupal 10.1.x fresh installation.
2. Install & enable Taxonomy Access Control Lite module.
3. Apply the patch #2.
4. Clear cache.
5. Access the Help page in /admin/help/tac_lite
Result :- Able to access the Help page in /admin/help/tac_lite after applying the patch.
Adding screenshots for reference.
Moving to RTBC.
Verified and tested patch #2 in Drupal 10.1.x.
Patch applied successfully.
Testing steps :-
1. Go to Drupal 10.1.x fresh installation.
2. Install & enable Taxonomy Access Control Lite module.
3. Apply the patch #2.
4. Clear cache.
5. Access the scheme1 tab in /admin/config/people/tac_lite without saving any settings.
Result :- Able to access the scheme1 tab in /admin/config/people/tac_lite without saving any settings after applying the patch.
Adding screenshots for reference.
Adding credits.
Adding meeting notes.
VinmayiSwamy → created an issue.
fathima.asmat → credited VinmayiSwamy → .
Gábor Hojtsy → credited VinmayiSwamy → .