Fix the issues reported by phpcs

Created on 3 May 2024, 7 months ago
Updated 22 July 2024, 5 months ago

Problem/Motivation

FILE: /home/addweb/Drupal8-vagrant/web/web/drupal10_10/web/modules/contrib/comment_notify/comment_notify.tokens.inc
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------
38 | WARNING | Unused variable $language_code.
41 | WARNING | Unused variable $language_code.
43 | WARNING | Unused variable $sanitize.
-------------------------------------------------------------------------------------------------------------------

FILE: /home/addweb/Drupal8-vagrant/web/web/drupal10_10/web/modules/contrib/comment_notify/tests/src/Functional/CommentNotifyNotificationsTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------
70 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
75 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
76 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
154 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
166 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
228 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
257 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/addweb/Drupal8-vagrant/web/web/drupal10_10/web/modules/contrib/comment_notify/tests/src/Functional/CommentNotifyTestBase.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
114 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/addweb/Drupal8-vagrant/web/web/drupal10_10/web/modules/contrib/comment_notify/tests/src/Functional/CommentNotifyUserPreferencesTest.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 25 WARNINGS AFFECTING 25 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
57 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
70 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
71 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
72 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
85 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
86 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
102 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
103 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
116 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
117 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
118 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
140 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
144 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
152 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
160 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
178 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
187 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
189 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
192 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
222 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
228 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
230 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/addweb/Drupal8-vagrant/web/web/drupal10_10/web/modules/contrib/comment_notify/tests/src/Functional/CommentNotifyAnonymousTest.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
43 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
74 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/addweb/Drupal8-vagrant/web/web/drupal10_10/web/modules/contrib/comment_notify/src/Form/CommentNotifyUnsubscribe.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
66 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
72 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/addweb/Drupal8-vagrant/web/web/drupal10_10/web/modules/contrib/comment_notify/comment_notify.migrate.inc
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
25 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
26 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
27 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/addweb/Drupal8-vagrant/web/web/drupal10_10/web/modules/contrib/comment_notify/comment_notify.install
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
109 | WARNING | Unused variable $entity_type.
----------------------------------------------------------------------------------------------------------------

FILE: /home/addweb/Drupal8-vagrant/web/web/drupal10_10/web/modules/contrib/comment_notify/comment_notify.module
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
220 | WARNING | Unused variable $field_name.
230 | WARNING | Doc comment indicates hook_form_alter() but function signature is "comment_notify_form_user_form_alter" instead of "comment_notify_form_alter". Did you mean hook_form_FORM_ID_alter()?
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

~/.config/composer/vendor/squizlabs/php_codesniffer/bin/phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml /modules/contrib/comment_notify/

๐Ÿ“Œ Task
Status

Needs work

Version

1.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev16.addweb

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Open in Jenkins โ†’ Open on Drupal.org โ†’
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 7 months ago
    4 pass, 6 fail
  • Issue created by @dev16.addweb
  • The last submitted patch, comment_notify_phpcs.patch, failed testing. View results โ†’
    - codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia dev2.addweb

    nilesh.addweb โ†’ made their first commit to this issueโ€™s fork.

  • First commit to issue fork.
  • Merge request !14Fixed some of the phpcs issues โ†’ (Open) created by cleavinjosh
  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines cleavinjosh

    Hi,

    I fixed some of the phpcs issues. These are the remaining issues:

    โžœ  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml comment_notify
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/comment_notify.install
    ----------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------
     109 | WARNING | Unused variable $entity_type.
    ----------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/comment_notify.migrate.inc
    --------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 4 LINES
    --------------------------------------------------------------------------------------------------------------
     35 | ERROR | Missing parameter type
     37 | ERROR | Missing parameter type
     53 | ERROR | Missing parameter type
     55 | ERROR | Missing parameter type
    --------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/tests/src/Functional/CommentNotifyUserPreferencesTest.php
    ---------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 5 LINES
    ---------------------------------------------------------------------------------------------------------------------------------------------
      60 | ERROR | Unnecessarily gendered language in a comment
      75 | ERROR | Unnecessarily gendered language in a comment
      91 | ERROR | Unnecessarily gendered language in a comment
      92 | ERROR | Unnecessarily gendered language in a comment
     106 | ERROR | Unnecessarily gendered language in a comment
    ---------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/README.md
    ---------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    ---------------------------------------------------------------------------------------------
     14 | WARNING | Line exceeds 80 characters; contains 87 characters
     45 | WARNING | Line exceeds 80 characters; contains 84 characters
     61 | WARNING | Line exceeds 80 characters; contains 83 characters
     88 | WARNING | Line exceeds 80 characters; contains 83 characters
    ---------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/comment_notify.module
    -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AND 5 WARNINGS AFFECTING 9 LINES
    -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
      22 | WARNING | [ ] Global constants should not be used, move it to a class or interface
      23 | WARNING | [ ] Global constants should not be used, move it to a class or interface
      24 | WARNING | [ ] Global constants should not be used, move it to a class or interface
     176 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     220 | WARNING | [ ] Unused variable $field_name.
     230 | WARNING | [ ] Doc comment indicates hook_form_alter() but function signature is "comment_notify_form_user_form_alter" instead of "comment_notify_form_alter". Did you mean
         |         |     hook_form_FORM_ID_alter()?
     268 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     285 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     476 | ERROR   | [ ] Unnecessarily gendered language in a comment
    -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/comment_notify.tokens.inc
    -------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    -------------------------------------------------------------------------------------------------------------
     38 | WARNING | Unused variable $language_code.
     41 | WARNING | Unused variable $language_code.
     43 | WARNING | Unused variable $sanitize.
    -------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/src/Form/CommentNotifyUnsubscribe.php
    -------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------
     40 | ERROR | Parameter $module_handler is not described in comment
    -------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/src/Form/CommentNotifySettings.php
    ----------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------
     65 | ERROR | Parameter $messenger is not described in comment
    ----------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/src/UserNotificationSettings.php
    --------------------------------------------------------------------------------------------------------------------
    FOUND 7 ERRORS AFFECTING 5 LINES
    --------------------------------------------------------------------------------------------------------------------
     27 | ERROR | Parameter $configFactory is not described in comment
     32 | ERROR | Missing parameter comment
     32 | ERROR | Doc comment for parameter $configFactory; does not match actual variable name $configFactory
     91 | ERROR | Missing parameter comment
     91 | ERROR | Missing parameter type
     92 | ERROR | Missing parameter type
     95 | ERROR | Description for the @return value is missing
    --------------------------------------------------------------------------------------------------------------------
    
    Time: 884ms; Memory: 14MB

    Please review.
    Thank you.

  • Status changed to Needs work 5 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia riddhi.addweb

    The patch was applied cleanly and after applying the patch the errors are still not resolved.

    FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/tests/src/Functional/CommentNotifyUserPreferencesTest.php
    -----------------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 5 LINES
    -----------------------------------------------------------------------------------------------------------------------------
      60 | ERROR | Unnecessarily gendered language in a comment
      75 | ERROR | Unnecessarily gendered language in a comment
      91 | ERROR | Unnecessarily gendered language in a comment
      92 | ERROR | Unnecessarily gendered language in a comment
     106 | ERROR | Unnecessarily gendered language in a comment
    -----------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/comment_notify.migrate.inc
    ----------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 4 LINES
    ----------------------------------------------------------------------------------------------
     35 | ERROR | Missing parameter type
     37 | ERROR | Missing parameter type
     53 | ERROR | Missing parameter type
     55 | ERROR | Missing parameter type
    ----------------------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/comment_notify.install
    ------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------
     109 | WARNING | Unused variable $entity_type.
    ------------------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/src/Form/CommentNotifySettings.php
    ------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------
     65 | ERROR | Parameter $messenger is not described in comment
    ------------------------------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/src/Form/CommentNotifyUnsubscribe.php
    ---------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------
     40 | ERROR | Parameter $module_handler is not described in comment
    ---------------------------------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/src/UserNotificationSettings.php
    -----------------------------------------------------------------------------------------------------------
    FOUND 7 ERRORS AFFECTING 5 LINES
    -----------------------------------------------------------------------------------------------------------
     27 | ERROR | Parameter $configFactory is not described in comment
     32 | ERROR | Missing parameter comment
     32 | ERROR | Doc comment for parameter $configFactory; does not match actual variable name $configFactory
     91 | ERROR | Missing parameter comment
     91 | ERROR | Missing parameter type
     92 | ERROR | Missing parameter type
     95 | ERROR | Description for the @return value is missing
    -----------------------------------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/comment_notify.module
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AND 5 WARNINGS AFFECTING 9 LINES
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
      22 | WARNING | [ ] Global constants should not be used, move it to a class or interface
      23 | WARNING | [ ] Global constants should not be used, move it to a class or interface
      24 | WARNING | [ ] Global constants should not be used, move it to a class or interface
     176 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     220 | WARNING | [ ] Unused variable $field_name.
     230 | WARNING | [ ] Doc comment indicates hook_form_alter() but function signature is "comment_notify_form_user_form_alter" instead of "comment_notify_form_alter". Did you mean
         |         |     hook_form_FORM_ID_alter()?
     268 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     285 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     476 | ERROR   | [ ] Unnecessarily gendered language in a comment
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/comment_notify.tokens.inc
    ---------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    ---------------------------------------------------------------------------------------------
     38 | WARNING | Unused variable $language_code.
     41 | WARNING | Unused variable $language_code.
     43 | WARNING | Unused variable $sanitize.
    ---------------------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/README.md
    -----------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    -----------------------------------------------------------------------------
     14 | WARNING | Line exceeds 80 characters; contains 87 characters
     45 | WARNING | Line exceeds 80 characters; contains 84 characters
     61 | WARNING | Line exceeds 80 characters; contains 83 characters
     88 | WARNING | Line exceeds 80 characters; contains 83 characters
    -----------------------------------------------------------------------------
    
  • First commit to issue fork.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia vinmayiswamy

    Fixed most of the issues reported by phpcs in the same MR.

    The below are the remaining issues to be fixed.

    $ ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/comment_notify
    
    FILE: /Users/vinmayi.nidubrolu/projects/drupal103/drupal/modules/contrib/comment_notify/comment_notify.install
    --------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------
     109 | WARNING | Unused variable $entity_type.
    --------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/vinmayi.nidubrolu/projects/drupal103/drupal/modules/contrib/comment_notify/README.md
    -------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    -------------------------------------------------------------------------------------------------
     14 | WARNING | Line exceeds 80 characters; contains 87 characters
     45 | WARNING | Line exceeds 80 characters; contains 84 characters
     61 | WARNING | Line exceeds 80 characters; contains 83 characters
     88 | WARNING | Line exceeds 80 characters; contains 83 characters
    -------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/vinmayi.nidubrolu/projects/drupal103/drupal/modules/contrib/comment_notify/comment_notify.module
    -------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    -------------------------------------------------------------------------------------------------------------
     22 | WARNING | Global constants should not be used, move it to a class or interface
     23 | WARNING | Global constants should not be used, move it to a class or interface
     24 | WARNING | Global constants should not be used, move it to a class or interface
    -------------------------------------------------------------------------------------------------------------
    
    Time: 459ms; Memory: 16MB
    

    Kindly please check and advise.

    Thanks!

Production build 0.71.5 2024