- last update
7 months ago 4 pass, 6 fail - Issue created by @dev16.addweb
The last submitted patch, comment_notify_phpcs.patch, failed testing. View results โ
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- ๐ฎ๐ณIndia dev2.addweb
nilesh.addweb โ made their first commit to this issueโs fork.
- First commit to issue fork.
- Status changed to Needs review
5 months ago 4:41am 18 July 2024 - ๐ต๐ญPhilippines cleavinjosh
Hi,
I fixed some of the phpcs issues. These are the remaining issues:
โ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml comment_notify FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/comment_notify.install ---------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 109 | WARNING | Unused variable $entity_type. ---------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/comment_notify.migrate.inc -------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------------------------------------------- 35 | ERROR | Missing parameter type 37 | ERROR | Missing parameter type 53 | ERROR | Missing parameter type 55 | ERROR | Missing parameter type -------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/tests/src/Functional/CommentNotifyUserPreferencesTest.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 60 | ERROR | Unnecessarily gendered language in a comment 75 | ERROR | Unnecessarily gendered language in a comment 91 | ERROR | Unnecessarily gendered language in a comment 92 | ERROR | Unnecessarily gendered language in a comment 106 | ERROR | Unnecessarily gendered language in a comment --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/README.md --------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------- 14 | WARNING | Line exceeds 80 characters; contains 87 characters 45 | WARNING | Line exceeds 80 characters; contains 84 characters 61 | WARNING | Line exceeds 80 characters; contains 83 characters 88 | WARNING | Line exceeds 80 characters; contains 83 characters --------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/comment_notify.module ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 5 WARNINGS AFFECTING 9 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 22 | WARNING | [ ] Global constants should not be used, move it to a class or interface 23 | WARNING | [ ] Global constants should not be used, move it to a class or interface 24 | WARNING | [ ] Global constants should not be used, move it to a class or interface 176 | ERROR | [x] Use null coalesce operator instead of ternary operator. 220 | WARNING | [ ] Unused variable $field_name. 230 | WARNING | [ ] Doc comment indicates hook_form_alter() but function signature is "comment_notify_form_user_form_alter" instead of "comment_notify_form_alter". Did you mean | | hook_form_FORM_ID_alter()? 268 | ERROR | [x] Use null coalesce operator instead of ternary operator. 285 | ERROR | [x] Use null coalesce operator instead of ternary operator. 476 | ERROR | [ ] Unnecessarily gendered language in a comment ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/comment_notify.tokens.inc ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------- 38 | WARNING | Unused variable $language_code. 41 | WARNING | Unused variable $language_code. 43 | WARNING | Unused variable $sanitize. ------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/src/Form/CommentNotifyUnsubscribe.php ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 40 | ERROR | Parameter $module_handler is not described in comment ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/src/Form/CommentNotifySettings.php ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 65 | ERROR | Parameter $messenger is not described in comment ---------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/comment_notify/src/UserNotificationSettings.php -------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 5 LINES -------------------------------------------------------------------------------------------------------------------- 27 | ERROR | Parameter $configFactory is not described in comment 32 | ERROR | Missing parameter comment 32 | ERROR | Doc comment for parameter $configFactory; does not match actual variable name $configFactory 91 | ERROR | Missing parameter comment 91 | ERROR | Missing parameter type 92 | ERROR | Missing parameter type 95 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------- Time: 884ms; Memory: 14MB
Please review.
Thank you. - Status changed to Needs work
5 months ago 5:42am 18 July 2024 - ๐ฎ๐ณIndia riddhi.addweb
The patch was applied cleanly and after applying the patch the errors are still not resolved.
FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/tests/src/Functional/CommentNotifyUserPreferencesTest.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------------------------- 60 | ERROR | Unnecessarily gendered language in a comment 75 | ERROR | Unnecessarily gendered language in a comment 91 | ERROR | Unnecessarily gendered language in a comment 92 | ERROR | Unnecessarily gendered language in a comment 106 | ERROR | Unnecessarily gendered language in a comment ----------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/comment_notify.migrate.inc ---------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------- 35 | ERROR | Missing parameter type 37 | ERROR | Missing parameter type 53 | ERROR | Missing parameter type 55 | ERROR | Missing parameter type ---------------------------------------------------------------------------------------------- FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/comment_notify.install ------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------ 109 | WARNING | Unused variable $entity_type. ------------------------------------------------------------------------------------------ FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/src/Form/CommentNotifySettings.php ------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------ 65 | ERROR | Parameter $messenger is not described in comment ------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/src/Form/CommentNotifyUnsubscribe.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 40 | ERROR | Parameter $module_handler is not described in comment --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/src/UserNotificationSettings.php ----------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------- 27 | ERROR | Parameter $configFactory is not described in comment 32 | ERROR | Missing parameter comment 32 | ERROR | Doc comment for parameter $configFactory; does not match actual variable name $configFactory 91 | ERROR | Missing parameter comment 91 | ERROR | Missing parameter type 92 | ERROR | Missing parameter type 95 | ERROR | Description for the @return value is missing ----------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/comment_notify.module ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 4 ERRORS AND 5 WARNINGS AFFECTING 9 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 22 | WARNING | [ ] Global constants should not be used, move it to a class or interface 23 | WARNING | [ ] Global constants should not be used, move it to a class or interface 24 | WARNING | [ ] Global constants should not be used, move it to a class or interface 176 | ERROR | [x] Use null coalesce operator instead of ternary operator. 220 | WARNING | [ ] Unused variable $field_name. 230 | WARNING | [ ] Doc comment indicates hook_form_alter() but function signature is "comment_notify_form_user_form_alter" instead of "comment_notify_form_alter". Did you mean | | hook_form_FORM_ID_alter()? 268 | ERROR | [x] Use null coalesce operator instead of ternary operator. 285 | ERROR | [x] Use null coalesce operator instead of ternary operator. 476 | ERROR | [ ] Unnecessarily gendered language in a comment ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/comment_notify.tokens.inc --------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES --------------------------------------------------------------------------------------------- 38 | WARNING | Unused variable $language_code. 41 | WARNING | Unused variable $language_code. 43 | WARNING | Unused variable $sanitize. --------------------------------------------------------------------------------------------- FILE: /var/www/html/web/drupal10/web/modules/contrib/comment_notify/README.md ----------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ----------------------------------------------------------------------------- 14 | WARNING | Line exceeds 80 characters; contains 87 characters 45 | WARNING | Line exceeds 80 characters; contains 84 characters 61 | WARNING | Line exceeds 80 characters; contains 83 characters 88 | WARNING | Line exceeds 80 characters; contains 83 characters -----------------------------------------------------------------------------
- First commit to issue fork.
- ๐ฎ๐ณIndia vinmayiswamy
Fixed most of the issues reported by phpcs in the same MR.
The below are the remaining issues to be fixed.
$ ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/comment_notify FILE: /Users/vinmayi.nidubrolu/projects/drupal103/drupal/modules/contrib/comment_notify/comment_notify.install -------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 109 | WARNING | Unused variable $entity_type. -------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103/drupal/modules/contrib/comment_notify/README.md ------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------- 14 | WARNING | Line exceeds 80 characters; contains 87 characters 45 | WARNING | Line exceeds 80 characters; contains 84 characters 61 | WARNING | Line exceeds 80 characters; contains 83 characters 88 | WARNING | Line exceeds 80 characters; contains 83 characters ------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103/drupal/modules/contrib/comment_notify/comment_notify.module ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------- 22 | WARNING | Global constants should not be used, move it to a class or interface 23 | WARNING | Global constants should not be used, move it to a class or interface 24 | WARNING | Global constants should not be used, move it to a class or interface ------------------------------------------------------------------------------------------------------------- Time: 459ms; Memory: 16MB
Kindly please check and advise.
Thanks!